-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add val address encoder #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughA new value encoder for the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request introduces a new
ValueEncoderimplementation forsdk.ValAddressin thevalue_encoder.gofile, along with corresponding unit tests invalue_encoder_test.go. The changes enhance the encoding and decoding capabilities for validator addresses (sdk.ValAddress) in the codebase.Addition of
sdk.ValAddressValueEncoder:value_encoder.go: AddedValAddressValueEncoderto the list ofValueEncoderimplementations, including methods for encoding, decoding, stringifying, and providing the name of the encoder. [1] [2]Unit tests for
ValAddressValueEncoder:value_encoder_test.go: Added a new test methodTestValAddressValueEncoderto validate the bijectivity (correctness of encoding and decoding) of theValAddressValueEncoderimplementation.