Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically retain fuel and oxidizer species #12

Open
xMestas opened this issue Oct 12, 2018 · 1 comment
Open

Automatically retain fuel and oxidizer species #12

xMestas opened this issue Oct 12, 2018 · 1 comment

Comments

@xMestas
Copy link
Contributor

xMestas commented Oct 12, 2018

Currently, the species listed as fuels and oxidizers in the initial conditions are not automatically retained. If one is removed, the auto ignition simulation is unable to run, This can lead to some unfriendly error messages for the user when trying to perform a reduction without specifying that the fuels and oxidizers should be retained. Fuels and oxidizers from all initial conditions should automatically be added to the retained species list if they are not already in it before the reduction occurs.

@kyleniemeyer
Copy link
Member

This should probably happen early on, after parsing the input file. This could be done pretty easily by looking over all the simulation initial conditions, and seeing if the reactant species are in the retained list—if not, then add them, making sure to avoid duplicates.

kbronstein56 added a commit to kbronstein56/pyMARS that referenced this issue Sep 30, 2021
I fixed issue Niemeyer-Research-Group#12 to automatically retain fuel and oxidizer species. I made a test with 5 example files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants