Merge #77

77: feat(func-tests): re-use uploaded programs r=andreasbros a=andreasbros

## Motivation

Every time you run functional tests, they start with uploading programs (20 of them) which can take couple minutes in mainnet.
This change allows to re-use previously uploaded programs, saving time and money (NIL), especially when you only want to run a single test against remote network from your local machine.

## Solution

- Dump uploaded programs IDs JSON in log output, which then when needed can be copied into a file locally
- Provide uploaded programs IDs file as env var when running tests

Note: this is only to be used when running tests from local dev environment


* [ ] [CONTRIBUTING](https://github.com/NillionNetwork/nillion/blob/main/CONTRIBUTING.md) guidelines followed
* [ ] Unit tests added/updated (if applicable)
* [ ] Breaking change analysis completed (if applicable). "Will this change require all network cluster operators to update? Does it break public APIs?
* [ ] For new features or breaking changes, created a documentation issue in [nillion-docs](https://github.com/NillionNetwork/nillion-docs/issues/new/choose)


Co-authored-by: Andreas Abros <[email protected]>

Author: nilogy-bors[bot]

Cargo.lock

@@ -15,6 +15,7 @@ tempfile = "3.10.1"
 tokio = { version = "1", features = ["macros", "rt-multi-thread", "time"] }
 xshell = "0.2"
 serde_yaml = "0.9"
+serde_json = "1.0"
 tracing = "0.1"
 
 basic-types = { path = "../../../libs/basic-types" }

tests/fixtures/nodes/Cargo.toml

@@ -65,6 +65,7 @@ extern "C" fn cleanup_at_exit() {
 }
 
 /// The set of pre-uploaded test programs.
+#[derive(Serialize, Deserialize, Debug)]
 pub struct UploadedPrograms(pub(crate) HashMap<String, String>);
 
 impl UploadedPrograms {
@@ -508,17 +509,25 @@ pub fn nodes(_tracing: &Tracing) -> Nodes {
     nodes.uploaded_programs = thread::scope(|s| {
         let namespace = s
             .spawn(|| {
-                PAYMENTS_RUNTIME
-                    .block_on(async {
-                        nodes.wait_network_ready().await.expect("network did not become ready in time");
-                        upload_programs(&nodes).await
-                    })
-                    .expect("uploading programs failed")
+                PAYMENTS_RUNTIME.block_on(async {
+                    // nodes fixture needs to wait for the network to be ready to discover the bootnode, regardless of the programs being uploaded
+                    nodes.wait_network_ready().await.expect("network did not become ready in time");
+
+                    if let Ok(file_path) = env::var("UPLOADED_PROGRAMS_ID_FILE") {
+                        let json_data = fs::read_to_string(&file_path)
+                            .unwrap_or_else(|_| panic!("failed to read uploaded programs file: {}", file_path));
+                        serde_json::from_str(&json_data)
+                            .unwrap_or_else(|_| panic!("failed to parse uploaded programs JSON in file: {}", file_path))
+                    } else {
+                        upload_programs(&nodes).await.expect("uploading programs failed")
+                    }
+                })
             })
             .join()
             .expect("program upload thread failed");
         namespace
     });
+
     nodes
 }
 

tests/fixtures/nodes/src/nodes.rs

@@ -35,5 +35,8 @@ pub(crate) async fn upload_programs(nodes: &Nodes) -> anyhow::Result<UploadedPro
     info!("Uploaded {} programs in {:?}", PROGRAMS.metadata.len(), elapsed);
 
     let namespace = UploadedPrograms(ids);
+
+    info!("Uploaded programs JSON:\n{}", serde_json::to_string(&namespace)?);
+
     Ok(namespace)
 }