Skip to content

chore: assert correct typing when using Probabilistic methods with Sparse reconcilers #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elephaint opened this issue Apr 10, 2025 · 0 comments
Assignees
Labels

Comments

@elephaint
Copy link
Contributor

What happened + What you expected to happen

Probalistic methods are generally typed with Numpy arrays, however they also work with Sparse methods. These methods however generate scipy sparse matrices, and we should correctly set the dtype entering the methods to support both np.ndarray and scipy sparse matrices to clarify the code.

Versions / Dependencies

1.2

Reproduction script

n/a

Issue Severity

Low: It annoys or frustrates me.

@elephaint elephaint added the bug label Apr 10, 2025
@elephaint elephaint self-assigned this Apr 10, 2025
@elephaint elephaint added fix and removed bug labels Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant