Skip to content

No Acknowledgment flag (NO_ACK) #3

@rosek86

Description

@rosek86

Hi, thanks for micro-esb, I found it very useful!

It seems that micro-esb sends ACK packets for all packets, even though NO_ACK flag is set. This decreases throughput when only communication in one way is needed.

if(NRF_RADIO->CRCSTATUS != 0 && m_rx_fifo.count < UESB_CORE_RX_FIFO_SIZE)
{
    send_ack = true;
}

shouldn't this be something like this:

if(NRF_RADIO->CRCSTATUS != 0)
{
    if(m_rx_fifo.count < UESB_CORE_RX_FIFO_SIZE && (m_rx_payload_buffer[1] & 1) == 1)
        send_ack = true;
    else
        set_rx_interrupt = true;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions