Improve documentation and default arguments behaviour in CLI #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SumanthRH <[email protected]>
Signed-off-by: SumanthRH <[email protected]>
Signed-off-by: SumanthRH <[email protected]>
SumanthRH
commented
Feb 26, 2025
Signed-off-by: SumanthRH <[email protected]>
lynnliu030
approved these changes
Feb 26, 2025
Member
lynnliu030
left a comment
lynnliu030
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the work!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
hf_transferto dependency since we default to downloading withhf_transfer(it should be pretty safe to use in almost all cases, and can download much faster)updateour default settings. Before, we completely disregarded our defaults for temperature, etc if the user-provided any argument.