Add "auto" dtype to RayLLMEngineArgs and some minor fixes #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SumanthRH <[email protected]>
Signed-off-by: SumanthRH <[email protected]>
Signed-off-by: SumanthRH <[email protected]>
Signed-off-by: SumanthRH <[email protected]>
SumanthRH
commented
Feb 27, 2025
Comment on lines
-54
to
-56
| def _temp_run(problem, generation, debug, result): | ||
| try: | ||
| result.append(taco_run_test(problem, test=generation, debug=debug)) |
Member
Author
There was a problem hiding this comment.
Fixes a multiprocessing error with TACO:
Traceback (most recent call last):
File "/Users/sumanthrh/.local/share/uv/python/cpython-3.10.15-macos-aarch64-none/lib/python3.10/concurrent/futures/process.py", line 246, in _process_worker
r = call_item.fn(*call_item.args, **call_item.kwargs)
File "/Users/sumanthrh/Documents/SkyThought/skythought/evals/tasks/taco/taco_handler.py", line 84, in update_results
curr_res = self.check_correctness(problem, generation=last_code)
File "/Users/sumanthrh/Documents/SkyThought/skythought/evals/tasks/taco/taco_handler.py", line 65, in check_correctness
p.start()
File "/Users/sumanthrh/.local/share/uv/python/cpython-3.10.15-macos-aarch64-none/lib/python3.10/multiprocessing/process.py", line 121, in start
self._popen = self._Popen(self)
File "/Users/sumanthrh/.local/share/uv/python/cpython-3.10.15-macos-aarch64-none/lib/python3.10/multiprocessing/context.py", line 224, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
File "/Users/sumanthrh/.local/share/uv/python/cpython-3.10.15-macos-aarch64-none/lib/python3.10/multiprocessing/context.py", line 288, in _Popen
return Popen(process_obj)
File "/Users/sumanthrh/.local/share/uv/python/cpython-3.10.15-macos-aarch64-none/lib/python3.10/multiprocessing/popen_spawn_posix.py", line 32, in __init__
super().__init__(process_obj)
File "/Users/sumanthrh/.local/share/uv/python/cpython-3.10.15-macos-aarch64-none/lib/python3.10/multiprocessing/popen_fork.py", line 19, in __init__
self._launch(process_obj)
File "/Users/sumanthrh/.local/share/uv/python/cpython-3.10.15-macos-aarch64-none/lib/python3.10/multiprocessing/popen_spawn_posix.py", line 47, in _launch
reduction.dump(process_obj, fp)
File "/Users/sumanthrh/.local/share/uv/python/cpython-3.10.15-macos-aarch64-none/lib/python3.10/multiprocessing/reduction.py", line 60, in dump
ForkingPickler(file, protocol).dump(obj)
AttributeError: Can't pickle local object 'TACOTaskHandler.check_correctness.<locals>._temp_run'
SumanthRH
changed the title
erictang000
approved these changes
Feb 27, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
autodtype to RayLLMEngineArgs.