FindPackageByIdResource.GetAllVersionsAsync() does not close conneection

[nhuethmayr]

Hi,

I'm using FindPackageByIdResource.GetAllVersionsAsync() (version 5.11) to check for available updates and saw that when the task returns, the TCP connection remains established.

/// <summary>
/// Checks for available updates matching the current application's major version.
/// </summary>
public async Task<IAutoUpdateQueryResult> CheckForUpdate()
{
//every update attempt needs its own token(source)
CancellationTokenCleanup();
_tokenSource = new CancellationTokenSource(_packageDownloadTimeout);

IEnumerable<NuGetVersion> versions;
try
{
    var resource = await GetResource();

    var cache = new SourceCacheContext();
    cache.NoCache = true;
    versions = await resource.GetAllVersionsAsync(
        _packageName,
        cache,
        NullLogger.Instance,
        _tokenSource.Token);
}
catch (OperationCanceledException)
{
    return await Task.FromException<IAutoUpdateQueryResult>(
        new AutoUpdateException("Checking for updates was cancelled by the user."));
}
catch (FatalProtocolException fpe)
{
    _logger.Warn(fpe);
    return await Task.FromException<IAutoUpdateQueryResult>(
        new AutoUpdateException("Checking for updates failed with an exception.", fpe));
}

foreach (var version in versions.OrderByDescending(o => o.Version))
{
    //looking for an update of the current major version.
    var currentVersion = new NuGetVersion(_versionInfo.Version);
    if (version > currentVersion && version.Major == currentVersion.Major)
    {
        //update available...
        return await Task.FromResult(
            (IAutoUpdateQueryResult)new AutoUpdateQueryResult(version.ToNormalizedString(), true));
    }
}

If I use said method again (ie: a user tries to look for updates multiple times), I get another connection.

To me, this seems like the HTTP connection is not closed when the async tasks complete. I also could not find a way to close it forcefully (through Dispose()) or the likes.