.NET 10 SDK dotnet clean does not remove packages produced by multi-TFM projects

[adamralph]

NuGet Product Used

dotnet.exe

Product Version

.NET SDK: Version: 10.0.101 Commit: fad253f51b Workload version: 10.0.100.1 MSBuild version: 18.0.6+fad253f51

Worked before?

.NET SDK: Version: 9.x

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Description

When using SDK versions 10.0.100 or 10.0.101 with projects that targets multiple TFM's, dotnet clean does not remove the packages produced by those projects. This seems like a regression, because the 9.x SDK does remove the packages.

To Reproduce

1. git clone https://github.com/adamralph/dotnet-clean-bug.git
2. cd dotnet-clean-bug/sdk-9
3. dotnet build
4. Observe that bin/Debug/test.1.0.0.nupkg is created.
5. dotnet clean
6. Observe that bin/Debug/test.1.0.0.nupkg is deleted.
7. cd ../sdk-10
8. dotnet build
9. Observe that bin/Debug/test.1.0.0.nupkg is created.
10. dotnet clean
11. Observe that bin/Debug/test.1.0.0.nupkg is NOT deleted.

Further technical details

See the triage over at dotnet/sdk#52109 (comment)

details of dotnet --info

.NET SDK: Version: 10.0.101 Commit: fad253f51b Workload version: 10.0.100.1 MSBuild version: 18.0.6+fad253f51

Runtime Environment:
OS Name: Mac OS X
OS Version: 26.1
OS Platform: Darwin
RID: osx-arm64
Base Path: /usr/local/share/dotnet/sdk/10.0.101/

.NET workloads installed:
There are no installed workloads to display.
Configured to use workload sets when installing new manifests.

Host:
Version: 10.0.1
Architecture: arm64
Commit: fad253f51b

.NET SDKs installed:
8.0.204 [/usr/local/share/dotnet/sdk]
9.0.101 [/usr/local/share/dotnet/sdk]
9.0.104 [/usr/local/share/dotnet/sdk]
9.0.200 [/usr/local/share/dotnet/sdk]
9.0.203 [/usr/local/share/dotnet/sdk]
10.0.100-rc.2.25502.107 [/usr/local/share/dotnet/sdk]
10.0.100 [/usr/local/share/dotnet/sdk]
10.0.101 [/usr/local/share/dotnet/sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 8.0.4 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.2 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.3 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.4 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 10.0.0-rc.2.25502.107 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 10.0.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 10.0.1 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 8.0.4 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.2 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.3 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.4 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 10.0.0-rc.2.25502.107 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 10.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 10.0.1 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
None

Environment variables:
Not set

global.json file:
Not found

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

Verbose Logs

[baronfel]

Copying over some analysis from the other issue:

I think this is a regression in some of the dependencies in the NuGet Pack task dependencies. I took your example (thanks!) and checked out the binlogs - you can see here that the _CleanPackageFiles Target isn't Deleting anything:

In 9, the _CleanPackageFiles Target did delete things, because the _GetOutputItemsFromPack Target ran to populate a list of Items to delete. That's not happening in 10 because the PackageReferenceCompatibleProjectStyle Property isn't being set (it's part of the Condition check on _GetOutputItemsFromPack), and it isn't being set because the _GetRestoreProjectStyle Target isn't called. If I manually force that Target to get called the package is cleaned up.

It looks like that Condition check on _GetOutputItemsFromPack didn't exist in 9, but does in 10 - is this due to the consolidation of the Pack targets that happened in 10? If so, should the _GetRestoreProjectStyle be hooked into the dependency chain somehow to ensure that necessary properties are computed before they are consumed?

cc @rainersigwald - here's a case where the 'property used before initialized' buildcheck could have caught a potential regression.

[jebriede]

Thanks for the detailed repro steps! I was able to reproduce the issue.