Skip to content

Contributor statues are broken due to commented-out code #170

@haykam821

Description

@haykam821

Interacting with a contributor statue to open its UI does nothing, and placing a contributor statue with a contributor manually set does not place a player head onto the armor stand. As a result, the intended use of contributor statues is entirely broken.

There seems to be commented-out code related to this issue within the Contributor#loadGameProfileProperties method:

public void loadGameProfileProperties(MinecraftServer server, GameProfile profile, Consumer<GameProfile> callback) {
/*SkullBlockEntityAccessor.callFetchProfileWithTextures(profile).thenAccept(optional -> {
optional.ifPresent(fullProfile -> {
server.getUserCache().add(fullProfile);
callback.accept(fullProfile);
});
});*/
}

The referenced SkullBlockEntityAccessor class contains no accessors, and thus is unused:

@Mixin(SkullBlockEntity.class)
public class SkullBlockEntityAccessor {
}

This issue seems to have been introduced during the Minecraft 1.20.4 port.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions