[IMP] account_financial_discount: black, isort, prettier

Author: grindtildeath

account_financial_discount/__manifest__.py

@@ -5,23 +5,18 @@
     "version": "13.0.1.0.0",
     "category": "Account",
     "website": "camptocamp.com",
-    "author": "Camptocamp",
+    "author": "Camptocamp, Odoo Community Association (OCA)",
     "license": "AGPL-3",
     "installable": True,
-    "depends": [
-        "account",
-        "account_reconcile_model_strict_match_amount",
-    ],
+    "depends": ["account", "account_reconcile_model_strict_match_amount"],
     "data": [
         "views/assets.xml",
         "views/payment_term_form.xml",
         "views/account_move.xml",
         "views/account_payment.xml",
         "views/account_reconcile_model.xml",
         "views/res_config_settings.xml",
-        "views/payment_receipt.xml"
-    ],
-    "qweb": [
-        "static/src/xml/reconciliation_templates.xml",
+        "views/payment_receipt.xml",
     ],
+    "qweb": ["static/src/xml/reconciliation_templates.xml"],
 }

account_financial_discount/models/account_move.py

@@ -6,33 +6,33 @@
 
 
 class AccountMove(models.Model):
-    _inherit = 'account.move'
+    _inherit = "account.move"
 
     has_discount_available = fields.Boolean(
-        'Has discount available',
-        compute='_compute_financial_discount_data',
+        "Has discount available",
+        compute="_compute_financial_discount_data",
         # TODO implement read_group + search because we cannot store the field
         #  as it depends on actual date
     )
     display_force_financial_discount = fields.Boolean(
-        compute='_compute_financial_discount_data'
+        compute="_compute_financial_discount_data"
     )
     force_financial_discount = fields.Boolean(
-        'Force financial discount?',
+        "Force financial discount?",
         default=False,
         help="If marked, financial discount will be applied even if the "
         "discount date is passed",
     )
     payment_blocked = fields.Boolean(
-        'Is payment blocked',
+        "Is payment blocked",
         default=False,
         help="Allows group-by but has no logic linked to it",
     )
 
     # TODO refactor the two functions below together
     def _get_discount_available(self):
         self.ensure_one()
-        if self.state == 'draft':
+        if self.state == "draft":
             if (
                 self.invoice_payment_term_id.days_discount
                 and self.invoice_payment_term_id.percent_discount
@@ -48,25 +48,21 @@ def _get_discount_available(self):
                 )
             ):
                 return True
-        elif self.state == 'posted':
+        elif self.state == "posted":
             disc_date = self._get_first_payment_term_line().date_discount
-            if (
-                disc_date
-                and disc_date >= date.today()
-                or self.force_financial_discount
-            ):
+            if disc_date and disc_date >= date.today() or self.force_financial_discount:
                 return True
         return False
 
     def _get_display_force_financial_discount(self):
         self.ensure_one()
-        if self.state == 'draft':
+        if self.state == "draft":
             if (
                 self.invoice_payment_term_id.days_discount
                 and self.invoice_payment_term_id.percent_discount
             ):
                 return True
-        elif self.state == 'posted':
+        elif self.state == "posted":
             first_payment_term_line = self._get_first_payment_term_line()
             if (
                 first_payment_term_line.date_discount
@@ -87,11 +83,11 @@ def _get_discount_amount(self, amount=None):
         return discount_amount
 
     @api.depends(
-        'invoice_date',
-        'invoice_payment_term_id',
-        'invoice_payment_term_id.days_discount',
-        'invoice_payment_term_id.percent_discount',
-        'force_financial_discount',
+        "invoice_date",
+        "invoice_payment_term_id",
+        "invoice_payment_term_id.days_discount",
+        "invoice_payment_term_id.percent_discount",
+        "force_financial_discount",
     )
     def _compute_financial_discount_data(self):
         """Compute discount financial discount fields"""
@@ -109,14 +105,13 @@ def post(self):
     def _get_first_payment_term_line(self):
         self.ensure_one()
         payment_term_lines = self.line_ids.filtered(
-            lambda line: line.account_id.user_type_id.type
-            in ('receivable', 'payable')
+            lambda line: line.account_id.user_type_id.type in ("receivable", "payable")
         )
-        return fields.first(payment_term_lines.sorted('date_maturity'))
+        return fields.first(payment_term_lines.sorted("date_maturity"))
 
     def _get_taxes_lines(self):
         self.ensure_one()
-        taxes_applied = self.line_ids.mapped('tax_ids')
+        taxes_applied = self.line_ids.mapped("tax_ids")
         taxes_lines = self.line_ids.filtered(
             lambda line: line.tax_line_id in taxes_applied
         )
@@ -134,21 +129,21 @@ def _store_financial_discount(self):
                 and payment_term.percent_discount
                 and len(tax_line) <= 1
                 and (
-                    (move.type == 'out_invoice' and payment_term_line.debit)
-                    or (move.type == 'in_invoice' and payment_term_line.credit)
+                    (move.type == "out_invoice" and payment_term_line.debit)
+                    or (move.type == "in_invoice" and payment_term_line.credit)
                 )
             ):
                 pay_term_vals = move._prepare_discount_vals(payment_term)
                 if tax_line:
                     tax_discount_amount = move._get_discount_amount(
                         tax_line.debit or tax_line.credit
                     )
-                    if move.type == 'in_invoice':
+                    if move.type == "in_invoice":
                         tax_discount_amount = -tax_discount_amount
                     pay_term_vals.update(
                         {
-                            'discount_tax_line_id': tax_line.id,
-                            'amount_discount_tax': tax_discount_amount,
+                            "discount_tax_line_id": tax_line.id,
+                            "amount_discount_tax": tax_discount_amount,
                         }
                     )
                 payment_term_line.write(pay_term_vals)
@@ -159,22 +154,20 @@ def _prepare_discount_vals(self, payment_term):
         if not payment_term.days_discount or not payment_term.percent_discount:
             vals.update(
                 {
-                    'amount_discount': 0,
-                    'amount_discount_currency': 0,
-                    'date_discount': False,
+                    "amount_discount": 0,
+                    "amount_discount_currency": 0,
+                    "date_discount": False,
                 }
             )
         else:
             company_currency = self.company_id.currency_id
             diff_currency = self.currency_id != company_currency
-            date_invoice = (
-                self.date or self.invoice_date or fields.Date.today()
-            )
+            date_invoice = self.date or self.invoice_date or fields.Date.today()
             date_discount = payment_term.calc_discount_date(date_invoice)
             # if there is a discount defined we always want the amount
             # the date is enough to lock it down.
             amount_discount_invoice_currency = self._get_discount_amount()
-            vals['date_discount'] = date_discount
+            vals["date_discount"] = date_discount
             amount_discount_company_currency = False
             if diff_currency:
                 amount_discount_company_currency = self.currency_id._convert(
@@ -183,20 +176,16 @@ def _prepare_discount_vals(self, payment_term):
                     self.company_id,
                     date_invoice,
                 )
-            if self.type == 'out_invoice':
+            if self.type == "out_invoice":
                 if diff_currency:
-                    vals['amount_discount'] = amount_discount_company_currency
-                    vals[
-                        'amount_discount_currency'
-                    ] = amount_discount_invoice_currency
+                    vals["amount_discount"] = amount_discount_company_currency
+                    vals["amount_discount_currency"] = amount_discount_invoice_currency
                 else:
-                    vals['amount_discount'] = amount_discount_invoice_currency
-            elif self.type == 'in_invoice':
+                    vals["amount_discount"] = amount_discount_invoice_currency
+            elif self.type == "in_invoice":
                 if diff_currency:
-                    vals['amount_discount'] = -amount_discount_company_currency
-                    vals[
-                        'amount_discount_currency'
-                    ] = -amount_discount_invoice_currency
+                    vals["amount_discount"] = -amount_discount_company_currency
+                    vals["amount_discount_currency"] = -amount_discount_invoice_currency
                 else:
-                    vals['amount_discount'] = -amount_discount_invoice_currency
+                    vals["amount_discount"] = -amount_discount_invoice_currency
         return vals

account_financial_discount/models/account_move_line.py

@@ -5,16 +5,16 @@
 
 
 class AccountMoveLine(models.Model):
-    _inherit = 'account.move.line'
+    _inherit = "account.move.line"
 
     amount_discount = fields.Monetary(
-        'Financial Discount amount in company currency',
-        currency_field='company_currency_id',
+        "Financial Discount amount in company currency",
+        currency_field="company_currency_id",
     )
     amount_discount_currency = fields.Monetary(
-        'Financial Discount amount in an optional other currency if it is a '
-        'multi-currency entry.'
+        "Financial Discount amount in an optional other currency if it is a "
+        "multi-currency entry."
     )
-    date_discount = fields.Date('Financial Discount date')
-    discount_tax_line_id = fields.Many2one('account.move.line')
-    amount_discount_tax = fields.Monetary(currency_field='company_currency_id')
+    date_discount = fields.Date("Financial Discount date")
+    discount_tax_line_id = fields.Many2one("account.move.line")
+    amount_discount_tax = fields.Monetary(currency_field="company_currency_id")