Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[IMP] account_product_fiscal_classification :
- In a context of product creation, if classification is not provided (in import context for exemple),
link the products to an existing classification, if the taxes match an existing one.
If no classification match, try to create a new classification, based on the product fiscal settings.
(It will fail if user is not member of Accountant group that can create / write on fiscal classifications)
- In a context of product update, apply same logic, linking to existing classification, or creating new classification
This will fix current limitation if account_product_fiscal_classification and pos_sale (for exemple) is installed,
there is an error when making an update, because loading data / demo is failing for the time being if the fields
taxes_id or supplier_taxes_id is defined. See for exemple : pos_sale.default_downpayment_product that contains
{'taxes_id': '[(5,)]'} write.- Loading branch information
1 parent
c2f474e
commit da630aa
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,101 +1,115 @@ | ||
| # Copyright (C) 2014-Today GRAP (http://www.grap.coop) | ||
| # @author: Sylvain LE GAL (https://twitter.com/legalsylvain) | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
| from odoo import Command | ||
| from odoo.exceptions import AccessError, ValidationError | ||
| from odoo.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class Tests(TransactionCase): | ||
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.ProductTemplate = cls.env["product.template"] | ||
| cls.ResCompany = cls.env["res.company"] | ||
| cls.FiscalClassification = cls.env["account.product.fiscal.classification"] | ||
| cls.WizardChange = cls.env["wizard.change.fiscal.classification"] | ||
|
|
||
| cls.main_company = cls.env.ref("base.main_company") | ||
| cls.group_accountant = cls.env.ref("account.group_account_manager") | ||
| cls.group_system = cls.env.ref("base.group_system") | ||
| cls.company_2 = cls.env.ref("account_product_fiscal_classification.company_2") | ||
|
|
||
| cls.classification_A_company_1 = cls.env.ref( | ||
| "account_product_fiscal_classification.fiscal_classification_A_company_1" | ||
| ) | ||
| cls.classification_B_company_1 = cls.env.ref( | ||
| "account_product_fiscal_classification.fiscal_classification_B_company_1" | ||
| ) | ||
| cls.classification_D_global = cls.env.ref( | ||
| "account_product_fiscal_classification.fiscal_classification_D_global" | ||
| ) | ||
| cls.product_template_A_company_1 = cls.env.ref( | ||
| "account_product_fiscal_classification.product_template_A_company_1" | ||
| ) | ||
| cls.account_tax_purchase_20_company_1 = cls.env.ref( | ||
| "account_product_fiscal_classification.account_tax_purchase_20_company_1" | ||
| ) | ||
| cls.account_tax_sale_5_company_1 = cls.env.ref( | ||
| "account_product_fiscal_classification.account_tax_sale_5_company_1" | ||
| ) | ||
| cls.account_tax_sale_20_company_1 = cls.env.ref( | ||
| "account_product_fiscal_classification.account_tax_sale_20_company_1" | ||
| ) | ||
| cls.account_tax_purchase_7_company_2 = cls.env.ref( | ||
| "account_product_fiscal_classification.account_tax_purchase_7_company_2" | ||
| ) | ||
| cls.chart_template = cls.env.ref( | ||
| "account_product_fiscal_classification.chart_template" | ||
| ) | ||
| cls.category_all = cls.env.ref("product.product_category_all") | ||
| cls.category_wine = cls.env.ref( | ||
| "account_product_fiscal_classification.category_wine" | ||
| ) | ||
|
|
||
| cls.initial_classif_count = cls.FiscalClassification.search_count([]) | ||
|
|
||
| vals = { | ||
| "company_id": cls.env.ref("base.main_company").id, | ||
| "name": "New User", | ||
| "login": "new_user", | ||
| "email": "[email protected]", | ||
| "groups_id": [Command.set(cls.env.ref("base.group_system").ids)], | ||
| } | ||
| cls.user_demo = cls.env["res.users"].create(vals) | ||
|
|
||
| def _create_product(self, extra_vals, user=False): | ||
| if not user: | ||
| user = self.env.user | ||
| vals = { | ||
| "name": "Test Product", | ||
| "company_id": self.main_company.id, | ||
| "categ_id": self.category_all.id, | ||
| } | ||
| vals.update(extra_vals) | ||
| return self.ProductTemplate.with_user(user).create(vals) | ||
|
|
||
| # # Test Section | ||
| def test_01_change_classification(self): | ||
| """Test the behaviour when we change Fiscal Classification for | ||
| products.""" | ||
| wizard = self.WizardChange.create( | ||
| { | ||
| "old_fiscal_classification_id": self.classification_A_company_1.id, | ||
| "new_fiscal_classification_id": self.classification_B_company_1.id, | ||
| } | ||
| ) | ||
| wizard.button_change_fiscal_classification() | ||
| self.assertEqual( | ||
| self.product_template_A_company_1.fiscal_classification_id, | ||
| self.classification_B_company_1, | ||
| "Fiscal Classification change has failed for products via Wizard.", | ||
| ) | ||
|
|
||
| def test_02_create_product(self): | ||
| """Test if creating a product with fiscal classification set correct taxes""" | ||
| newTemplate = self._create_product( | ||
| {"fiscal_classification_id": self.classification_D_global.id} | ||
| ) | ||
| # Test that all taxes are set (in sudo mode) | ||
| self.assertEqual( | ||
| set(newTemplate.sudo().taxes_id.ids), | ||
| set(self.classification_D_global.sudo().sale_tax_ids.ids), | ||
| ) | ||
| self.assertEqual( | ||
| set(newTemplate.sudo().supplier_taxes_id.ids), | ||
| set(self.classification_D_global.sudo().purchase_tax_ids.ids), | ||
| ) | ||
|
|
||
| def test_03_update_fiscal_classification(self): | ||
| """Test if changing a Configuration of a Fiscal Classification changes | ||
| the product.""" | ||
| self.classification_A_company_1.write( | ||
| {"sale_tax_ids": [(6, 0, [self.account_tax_sale_20_company_1.id])]} | ||
| ) | ||
| self.assertEqual( | ||
|
|
@@ -107,7 +121,7 @@ def test_03_update_fiscal_classification(self): | |
| def test_05_unlink_fiscal_classification(self): | ||
| """Test if unlinking a Fiscal Classification with products fails.""" | ||
| with self.assertRaises(ValidationError): | ||
| self.classification_A_company_1.unlink() | ||
|
|
||
| def test_10_chart_template(self): | ||
| """Test if installing new CoA creates correct classification""" | ||
|
|
@@ -148,29 +162,85 @@ def test_30_rules(self): | |
|
|
||
| # Create a product without rules should success | ||
| self._create_product( | ||
| {"fiscal_classification_id": self.classification_B_company_1.id} | ||
| ) | ||
| self._create_product( | ||
| {"fiscal_classification_id": self.classification_B_company_1.id}, | ||
| user=self.user_demo, | ||
| ) | ||
|
|
||
| vals = { | ||
| "categ_id": self.category_wine.id, | ||
| "fiscal_classification_id": self.classification_B_company_1.id, | ||
| } | ||
| # create a product not respecting rules should succeed with accountant perfil | ||
| self._create_product(vals) | ||
|
|
||
| # create a product not respecting rules should fail without accountant perfil | ||
| with self.assertRaises(ValidationError): | ||
| self._create_product(vals, user=self.user_demo) | ||
|
|
||
| def test_no_classification_and_find_one(self): | ||
| vals = { | ||
| "taxes_id": self.classification_B_company_1.sale_tax_ids.ids, | ||
| "supplier_taxes_id": self.classification_B_company_1.purchase_tax_ids.ids, | ||
| } | ||
| product = self._create_product(vals, user=self.user_demo) | ||
|
|
||
| # no new classification is created | ||
| classif_count_after = self.FiscalClassification.search_count([]) | ||
| self.assertEqual(classif_count_after, self.initial_classif_count) | ||
| # product is linked to the correct classification | ||
| self.assertEqual( | ||
| product.fiscal_classification_id, self.classification_B_company_1 | ||
| ) | ||
|
|
||
| def test_no_classification_one_more_tax_and_create_one(self): | ||
| """Create a product with fiscal settings that looks like | ||
| classification_B_company_1 but with an additional supplier tax. | ||
| """ | ||
|
|
||
| vals = { | ||
| "taxes_id": self.classification_B_company_1.sale_tax_ids.ids, | ||
| "supplier_taxes_id": self.account_tax_purchase_20_company_1.ids, | ||
| } | ||
|
|
||
| # create a product with fiscal settings that doesn't match | ||
| # existing classification should fail with non accountant user | ||
| with self.assertRaises(AccessError): | ||
| self._create_product(vals, user=self.user_demo) | ||
|
|
||
| # create a product with fiscal settings that doesn't match | ||
| # existing classification should success with accountant user | ||
| product = self._create_product(vals) | ||
| self.assertNotEqual(product.fiscal_classification_id, False) | ||
| classif_count_after = self.FiscalClassification.search_count([]) | ||
| self.assertEqual(classif_count_after, self.initial_classif_count + 1) | ||
|
|
||
| def test_no_classification_one_less_tax_and_create_one(self): | ||
| """Create a product with fiscal settings that looks like | ||
| classification_B_company_1 but with one less tax | ||
| """ | ||
|
|
||
| vals = { | ||
| "taxes_id": self.account_tax_sale_5_company_1.ids, | ||
| "supplier_taxes_id": [], | ||
| } | ||
| # create a product with fiscal settings that doesn't match | ||
| # existing classification should fail with non accountant user | ||
| with self.assertRaises(AccessError): | ||
| self._create_product(vals, user=self.user_demo) | ||
|
|
||
| # create a product with fiscal settings that doesn't match | ||
| # existing classification should success with accountant user | ||
| product = self._create_product(vals) | ||
|
|
||
| self.assertNotEqual(product.fiscal_classification_id, False) | ||
| classif_count_after = self.FiscalClassification.search_count([]) | ||
| self.assertEqual(classif_count_after, self.initial_classif_count + 1) | ||
|
|
||
| def test_no_tax_nor_classification(self): | ||
| product = self._create_product({"taxes_id": [], "supplier_taxes_id": []}) | ||
| classif = product.fiscal_classification_id | ||
| self.assertEqual(classif.purchase_tax_ids.ids, []) | ||
| self.assertEqual(classif.sale_tax_ids.ids, []) | ||