[MIG] partner_invoicing_mode_at_shipping: Migration to 17.0

Author: NICO-SOLUTIONS

partner_invoicing_mode_at_shipping/README.rst

@@ -69,10 +69,15 @@ Contributors
 
 -  Phuc (Tran Thanh) <[email protected]>
 
+-  Nils Coenen <[email protected]>
+
+-  Chau Le <[email protected]>
+
 Other credits
 -------------
 
-The development of this module has been financially supported by:
+The development and migration of this module has been financially
+supported by:
 
 -  Camptocamp
 

partner_invoicing_mode_at_shipping/__manifest__.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 {
     "name": "Partner Invoicing Mode At Shipping",
-    "version": "16.0.1.2.0",
+    "version": "17.0.1.0.0",
     "summary": "Create invoices automatically when goods are shipped.",
     "author": "Camptocamp, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/account-invoicing",
@@ -13,5 +13,8 @@
         "views/res_partner.xml",
     ],
     "depends": ["account", "partner_invoicing_mode", "queue_job", "stock"],
+    "external_dependencies": {
+        "python": ["openupgradelib"],
+    },
     "pre_init_hook": "pre_init_hook",
 }

partner_invoicing_mode_at_shipping/hooks.py

@@ -2,8 +2,6 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 from openupgradelib import openupgrade
 
-from odoo import SUPERUSER_ID, api
-
 
 def _add_one_invoice_per_shipping(env):
     if not openupgrade.column_exists(env.cr, "sale_order", "one_invoice_per_shipping"):
@@ -21,6 +19,5 @@ def _add_one_invoice_per_shipping(env):
         openupgrade.add_fields(env, field_spec)
 
 
-def pre_init_hook(cr):
-    env = api.Environment(cr, SUPERUSER_ID, {})
+def pre_init_hook(env):
     _add_one_invoice_per_shipping(env)

partner_invoicing_mode_at_shipping/migrations/16.0.1.1.0/pre-migrate.py

@@ -1,4 +1,3 @@
 from . import res_partner
-from . import stock_move
 from . import stock_picking
 from . import sale_order

partner_invoicing_mode_at_shipping/models/__init__.py

@@ -1,7 +1,7 @@
 # Copyright 2020 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
-from odoo import _, models
+from odoo import _, api, models
 
 
 class StockPicking(models.Model):
@@ -27,6 +27,7 @@ def _invoicing_at_shipping_validation(self, invoices):
             lambda invoice: invoice.partner_id.invoicing_mode == "at_shipping"
         )
 
+    @api.model
     def _invoicing_at_shipping(self):
         self.ensure_one()
         sales = self._get_sales_order_to_invoice()

partner_invoicing_mode_at_shipping/models/stock_move.py

@@ -3,3 +3,5 @@
   > - Thierry Ducrest \<<[email protected]>\>
 
 - Phuc (Tran Thanh) \<<[email protected]>\>
+- Nils Coenen \<<[email protected]>\>
+- Chau Le \<<[email protected]>\>

partner_invoicing_mode_at_shipping/models/stock_picking.py

@@ -1,3 +1,3 @@
-The development of this module has been financially supported by:
+The development and migration of this module has been financially supported by:
 
 - Camptocamp

partner_invoicing_mode_at_shipping/readme/CONTRIBUTORS.md

@@ -418,11 +418,16 @@ <h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
 </li>
 <li><p class="first">Phuc (Tran Thanh) &lt;<a class="reference external" href="mailto:phuc&#64;trobz.com">phuc&#64;trobz.com</a>&gt;</p>
 </li>
+<li><p class="first">Nils Coenen &lt;<a class="reference external" href="mailto:nils.coenen&#64;nico-solutions.de">nils.coenen&#64;nico-solutions.de</a>&gt;</p>
+</li>
+<li><p class="first">Chau Le &lt;<a class="reference external" href="mailto:chaulb&#64;trobz.com">chaulb&#64;trobz.com</a>&gt;</p>
+</li>
 </ul>
 </div>
 <div class="section" id="other-credits">
 <h2><a class="toc-backref" href="#toc-entry-5">Other credits</a></h2>
-<p>The development of this module has been financially supported by:</p>
+<p>The development and migration of this module has been financially
+supported by:</p>
 <ul class="simple">
 <li>Camptocamp</li>
 </ul>

partner_invoicing_mode_at_shipping/readme/CREDITS.md

@@ -27,7 +27,6 @@ def setUpClass(cls):
                         },
                     )
                 ],
-                "pricelist_id": cls.env.ref("product.list0").id,
             }
         )
 
@@ -51,6 +50,5 @@ def _create_order(cls):
                         },
                     )
                 ],
-                "pricelist_id": cls.env.ref("product.list0").id,
             }
         )

partner_invoicing_mode_at_shipping/static/description/index.html

@@ -19,10 +19,10 @@ def test_invoice_created_at_shipping(self):
         self.so1.action_confirm()
         for picking in self.so1.picking_ids:
             for move in picking.move_ids:
-                move.quantity_done = move.product_uom_qty
+                move.quantity = move.product_uom_qty
             picking.action_assign()
             with mute_logger("odoo.addons.queue_job.delay"):
-                picking.with_context(test_queue_job_no_delay=True).button_validate()
+                picking.with_context(queue_job__no_delay=True).button_validate()
         self.assertEqual(len(self.so1.invoice_ids), 1)
         self.assertEqual(self.so1.invoice_ids.state, "posted")
 
@@ -32,10 +32,10 @@ def test_invoice_not_created_at_shipping(self):
         self.so1.action_confirm()
         for picking in self.so1.picking_ids:
             for move in picking.move_ids:
-                move.quantity_done = move.product_uom_qty
+                move.quantity = move.product_uom_qty
             picking.action_assign()
             with mute_logger("odoo.addons.queue_job.delay"):
-                picking.with_context(test_queue_job_no_delay=True).button_validate()
+                picking.with_context(queue_job__no_delay=True).button_validate()
         self.assertEqual(len(self.so1.invoice_ids), 0)
 
     def test_picking_multi_order_single_invoice(self):
@@ -50,10 +50,10 @@ def test_picking_multi_order_single_invoice(self):
         so2.picking_ids.move_ids.picking_id = picking
         # Transfer the remaining picking with moves
         for move in picking.move_ids:
-            move.quantity_done = move.product_uom_qty
+            move.quantity = move.product_uom_qty
         picking.action_assign()
         with mute_logger("odoo.addons.queue_job.delay"):
-            picking.with_context(test_queue_job_no_delay=True).button_validate()
+            picking.with_context(queue_job__no_delay=True).button_validate()
         self.assertEqual(len(self.so1.invoice_ids), 1)
         self.assertEqual(self.so1.invoice_ids.state, "posted")
         self.assertEqual(self.so1.invoice_ids, so2.invoice_ids)
@@ -70,10 +70,10 @@ def test_picking_multi_order_multi_invoice(self):
         so2.picking_ids.move_ids.picking_id = picking
         # Transfer the remaining picking with moves
         for move in picking.move_ids:
-            move.quantity_done = move.product_uom_qty
+            move.quantity = move.product_uom_qty
         picking.action_assign()
         with mute_logger("odoo.addons.queue_job.delay"):
-            picking.with_context(test_queue_job_no_delay=True).button_validate()
+            picking.with_context(queue_job__no_delay=True).button_validate()
         self.assertEqual(len(self.so1.invoice_ids), 1)
         self.assertEqual(self.so1.invoice_ids.state, "posted")
         self.assertEqual(len(so2.invoice_ids), 1)
@@ -85,20 +85,20 @@ def test_picking_backorder(self):
         self.partner.invoicing_mode = "at_shipping"
         self.so1.action_confirm()
         picking = self.so1.picking_ids
-        picking.move_ids.quantity_done = 2
+        picking.move_ids.quantity = 2
         picking.action_assign()
         with mute_logger("odoo.addons.queue_job.delay"):
             picking.with_context(
-                skip_backorder=True, test_queue_job_no_delay=True
+                skip_backorder=True, queue_job__no_delay=True
             ).button_validate()
         self.assertEqual(len(self.so1.invoice_ids), 1)
         self.assertEqual(self.so1.invoice_ids.state, "posted")
         # Now process the backorder
         backorder = self.so1.picking_ids - picking
-        backorder.move_ids.quantity_done = 2
+        backorder.move_ids.quantity = 2
         backorder.action_assign()
         with mute_logger("odoo.addons.queue_job.delay"):
-            backorder.with_context(test_queue_job_no_delay=True).button_validate()
+            backorder.with_context(queue_job__no_delay=True).button_validate()
         self.assertEqual(len(self.so1.invoice_ids), 2)
         self.assertTrue(
             all(invoice.state == "posted") for invoice in self.so1.invoice_ids

partner_invoicing_mode_at_shipping/tests/common.py

@@ -24,7 +24,7 @@ def test_invoice_created_at_shipping_per_delivery(self):
         picking = self.so1.picking_ids
 
         # Deliver partially
-        picking.move_ids.quantity_done = 2.0
+        picking.move_ids.write({"quantity": 2.0, "picked": True})
         with trap_jobs() as trap:
             picking._action_done()
             trap.assert_enqueued_job(
@@ -43,7 +43,7 @@ def test_invoice_created_at_shipping_per_delivery(self):
         backorder = self.so1.picking_ids - picking
         self.assertTrue(backorder)
 
-        backorder.move_ids.quantity_done = 2.0
+        backorder.move_ids.write({"quantity": 2.0, "picked": True})
         with trap_jobs() as trap:
             backorder._action_done()
             trap.assert_enqueued_job(

partner_invoicing_mode_at_shipping/tests/test_invoice_mode_at_shipping.py

@@ -0,0 +1,2 @@
+# generated from manifests external_dependencies
+openupgradelib