Migration to version 13.0

[OCA-git-bot]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

• agreement --> base_contract - by @newtratip -
• agreement_legal_sale --> contract_legal_sale
• agreement_maintenance - By @olgamarcocb - [MIG] agreement_maintenance: Migration to 13.0 #762
• agreement_mrp --> contract_mrp
• agreement_project --> contract_project
• agreement_repair --> contract_repair
• agreement_sale --> contract_legal
• agreement_serviceprofile --> contract_service
• agreement_stock --> contract_stock
• contract - By @pedrobaeza - [13.0][MIG] contract: Migration to 13.0 #533
• contract_layout_category_hide_detail - By @victoralmau - [13.0] [MIG] contract_layout_category_hide_detail: Migration to v13.0  #554
• contract_mandate - By @Willerr-mo - [13.0][MIG] contract_mandate: Migration to 13.0 #559
• contract_payment_mode - By @Willerr-mo - [13.0][MIG] contract_payment_mode: Migration to 13.0 #558
• contract_price_revision - By @rousseldenis - [13.0][MIG] contract_price_revision + improvements #864
• contract_sale - By @victoralmau - [13.0] [MIG] contract_sale: Migration to v13.0  #555
• contract_sale_generation - By @marionumza - [13.0][MIG] contract_sale_generation #863
• contract_sale_invoicing - By @dantiller2 - [MIG] contract_sale_invoicing: Migration to 13.0 #842
• contract_variable_qty - By @CarlosRoca13 - [13.0] [MIG] contract_variable_quantity: Migration to v13.0 #567
• contract_variable_qty_timesheet - By @flachica - [MIG][13.0] contract_variable_qty_timesheet: Migration to 13.0 #580
• product_contract - By @sbejaoui - [13.0][MIG] - migration product_contract #561

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

[newtratip]

I'm working on agreement

[max3903]

Hello @newtratip

Beware that we are discussing converging contract and agreement in version 13 to have a complete solution with recurring invoices, integration with operations and legal content management.

Please open a specific issue if the migration of contract and contract_sale is not clear and needs to be discussed further.

CC: @alexis-via @sbejaoui

[newtratip]

ok

[gurneyalex]

@max3903

Beware that we are discussing converging contract and agreement in version 13 to have a complete solution with recurring invoices, integration with operations and legal content management.

Hello, can you point me to this discussion? I have some interest in this with the work about service level agreement / terms and conditions (and this is related to #397 and #398 and the work I initiated on #396 for 12.0 and for which I need a migration path to 13.0)

cc @alexis-via @sbejaoui @i-vyshnevska

[max3903]

@gurneyalex The discussion happened during the OCA Days in LLN. The result of the discussion is the description of this issue (renaming/merging modules).

[gurneyalex]

thanks

[sbidoul]

I personally generally agree with the idea of converging contract and agreement, as briefly discussed in LLN. The details on how to do this are far from clear in my mind, though. Would it be worth fleshing out the plan a little bit?

A few notes:

• the contract name is inherited from Odoo <= 8, IIRC
• the contract module it is almost exclusively focusing on recurring invoicing.
• a recurring invoicing "contract" is certainly a kind of agreement, or rather we can see recurring invoicing as something that some type of agreements can require
• most of the recurring invoicing logic of contract is based on contract lines, fields currently on the contract mostly influence the invoice header (invoicing contact, payment term, mandate and so on).

I'm not sure about renaming agreement to base_contract, because agreement sounds as a more generic term that may be a better fit for the polymorphic beast it becomes. So an alternative approach could be rename contract to agreement_recurring_invoicing, with the purpose of adding recurring invoicing logic to the agreement object?

More difficult questions can probably arise if we start thinking about the relationship between sale order and contract / agreement (currently in module product_contract for recurring invoicing). Also do agreement have lines? If yes what is an agreement line exactly? What is the relationship between an agreement line and a recurring invoicing line, if any (probably not a 1-1)? ...

[max3903]

My understanding of the different use cases and a proposal of module name:

@alexis-via needs an object with a name --> base_contract
Some people needs a little more info than just a name --> contract
@ygol and I needs the legal content management --> contract_legal
@sbidoul and @sbejaoui need the recurring invoicing --> contract_account
@gurneyalex and I need integrations with the other Odoo modules --> contract_sale, contract_stock, contract_service, etc.

[ygol]

Another use case is the use of "framework contract" which is an extension of agreement_legal (possibly), where prices and/or cost are set depending on being within/outside of the contract

[bealdav]

Since contract no more depends of analytic, I'm agreed with @sbidoul.
He has my agreement to go on with contract only ;-)

It seems than @alexis-via needs is just above than just the name #144 ;-)

[max3903]

@sbidoul

So an alternative approach could be rename contract to agreement_recurring_invoicing, with the purpose of adding recurring invoicing logic to the agreement object?

I proposed contract because the name is shorter than agreement and I am lazy :)

Also do agreement have lines?

Yes

If yes what is an agreement line exactly?

A pseudo copy of the sale order line that were sold: it only has product and quantity

What is the relationship between an agreement line and a recurring invoicing line, if any (probably not a 1-1)?

There is no relationship yet. Agreement does NOT support recurring invoicing.

[max3903]

@sbidoul @bealdav @gurneyalex

What do you think of:

Requirements	Module Name
Name, Code, Partner, Date	base_contract
Contract lines	contract
Legal content management	contract_legal
Recurring invoicing from contract lines	contract_account
Integrations with other Odoo modules	contract_sale, contract_stock, contract_service, etc.

[bealdav]

I'm not sure about renaming agreement to base_contract, because agreement sounds as a more generic term that may be a better fit for the polymorphic beast it becomes

+ 1

You may have agreement.line depending of a company setting activated by default in agreement module

[max3903]

@sbidoul @bealdav @gurneyalex @ygol

Requirements	Module Name
Name, Code, Partner, Date, Agreement Lines (only shown if you are in a specific group)	agreement
Legal content management	agreement_legal
Recurring invoicing from contract lines	agreement_account
Integrations with other Odoo modules	agreement_sale, agreement_stock, agreement_service, etc.

[sbidoul]

Do agreement_account necessarily mean recurring invoicing? I kind of remember @alexis-via had other requirement wrt to the invoice / agreement relationship.

Regarding lines, I'm not sure at all it is possible to conflate generic agreement lines with lines used for the purpose of recurring invoicing. (note I don't know use cases for generic agreement lines).

If yes what is an agreement line exactly?

A pseudo copy of the sale order line that were sold: it only has product and quantity

Regarding agreement_sale, there is probably a difference between selling such "generic" agreement lines, and selling lines for the purpose of recurring invoicing (as done in product_contract).

It could be we need two sets of lines in agreement for different purposes. Which may or may not be a problem.

[max3903]

Requirements	Module Name
Name, Code, Partner, Date, Agreement Lines (only shown if you are in a specific group)	agreement
Legal content management	agreement_legal
Integration with Accounting	agreement_account
Recurring invoicing from contract lines	agreement_account_recurring_invoice
Integrations with other Odoo modules	agreement_sale, agreement_stock, agreement_service, etc.

The agreement lines define the scope covered by the agreement, what you are supposed to provide. It could be inventory items or services.

[bealdav]

not blocking but agreement_recurring_invoice is sufficient

Everybody know than invoice depends on account whatever accounting refactor ;-)

It's not ambiguous.

[max3903]

Requirements	Module Name
Name, Code, Partner, Date, Agreement Lines (only shown if you are in a specific group)	agreement
Legal content management	agreement_legal
Integration with Accounting	agreement_account
Recurring invoicing from agreement lines	agreement_recurring_invoice
Integrations with other Odoo modules	agreement_sale, agreement_stock, agreement_service, etc.

[pedrobaeza]

@aschlager it depends also on you: if you review current PRs, you can check the state and approve it if it's everything OK for its final inclusion in the repo.

[victoralmau]

I'm working on contract_layout_category_hide_detail #554

[victoralmau]

I'm working on contract_sale #555

[sbejaoui]

contract_mandate #559

[sbejaoui]

contract_payment_mode #558

[sbejaoui]

product_contract #561

[alexis-via]

FYI, due to the failure to introduce a proper base_contract module in odoo v13 (and it seems it will be the same for v14, because there is already a PR to port contract to v14 that don't rely on base_contract), I'll stop my efforts to try to have a base_contract module that fits my (simple) needs. So I won't maintain my "agreement" module in OCA/contract and I'll find other solutions for my (simple) needs. I have very large PRs on other repos that are blocked because of this mess and I don't want to be impacted by this on v14.
In my developments on e-invoicing, I'll make sure that fetching the code of the related contract is easy to inherit, so that you can easily plug the contract module of your choice.

[newtratip]

Hi!! I would like to manage content contract and print contract as module agreement_legal on V12. I looked on the listed modules to migrate it doesn't have module agreement_legal. What is new module name of agreement_legal ?

[kittiu]

Sorry, I am late with the discussion. I and @newtratip was using agreement_legal and contract modules, and they works for us. We will need the equivalent modules soon and wanted to join the party.

But frankly, I am quite lost in the discussion. What is the state of work here? @max3903 Are we agreed upon -> #386 (comment)

@alexis-via do you suggest us to migrate agreement / agreement_legal ? What is your pov?

Thank you!

[ygol]

Sorry, I am late with the discussion. I and @newtratip was using agreement_legal and contract modules, and they works for use. We will need the equivalent modules soon and wanted to join the party.

But frankly, I am quite lost in the discussion. What is the state of work here? @max3903 Are we agreed upon -> #386 (comment)

@alexis-via do you suggest us to migrate agreement / agreement_legal ? What is your pov?

Thank you!

I am also using agreement_legal and also unable to understand where it is heading.
For my use I would prefer having agreement in a separate repo altogether

[kittiu]

@ygol for us, we think they are relevant. When we use it together, we did created a new module agreement_to_contract that convert agreement to contract.

• agreement_legal is used by lawyer, only when it is signed, it is converted to contract.
• contract is used by accountant to create recurring invoice (separation make more sense in our case).

[kittiu]

For my use I would prefer having agreement in a separate repo altogether

@ygol you don't use both agreement and contract?

[ygol]

For my use I would prefer having agreement in a separate repo altogether

@ygol you don't use both agreement and contract?

no. my customers are using agreement_legal (used by lawyer) and linked to extended project and tasks to control that operations take place within a legal agreement in regard of prices and quantities. Invoicing (accounting) comes at a later stage (getting the prices and quantities that where processed)

[kittiu]

Our team will start to migrate agreement / agreement_legal
Note: Please let us know, if we shouldn't do it otherwise.

[rousseldenis]

I will work on contract_price_revision on my free time. I will add enhancement to take into account fix price update.

[BartvandenHout]

Came across an error while upgrading from Odoo 12 to 13 (can't compare bool and datetime with '>')
Resolved the OpenUpgrade error by changing:
contract_recurrency_mixin.py: line 111
if rec.date_end and next_period_date_start and next_period_date_start > rec.date_end:

[victoralmau]

I'm working on agreement_legal #674

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.