Maintainer are not able to merge / rebase their modules when migrating

[legalsylvain]

Describe the bug

• I'm declared maintainer of the module bi_sql_editor in V15 release : https://github.com/OCA/reporting-engine/blob/15.0/bi_sql_editor/__manifest__.py#L23
• I'm migrating the module in V16. See : [16.0][MIG] bi_sql_editor (from 15.0) reporting-engine#670.
• When I try to rebase, the bot say that I'm not the maintainer. See.

Expected behavior

• Since [IMP] Search addons maintainers in other branches. Fix : #122 #183 (comment) has been deployed, I'll have to have the right to rebase and merge.

Additional context
I suspect that the commit of the folder setup is not ignored by the bot.

CC : @sbidoul

[yajo]

I just hit the same issue here: OCA/account-financial-tools#1536 (comment)

[luisg123v]

I also suspect it has to do with the setup folder. Problem is:

• If changes on that folder are not included in PR, it won't pass CI
• If that folder is ignored, (AFAIK) someone could introduce any changes there

[sbidoul]

I think it's safe enough to ignore the setup/{addon_name}/ directory.

Side note: for the future, I'm preparing something to get rid of the setup directory and replace it with a pyproject.toml file at the root of each addon. Hopefully it will be ready for 17.

[legalsylvain]

I think it's safe enough to ignore the setup/{addon_name}/ directory.

I think the algorithm should be :

• if github_login is maintainer of my_module, so allow changes in setup/my_module/ by github_login.

If we can do that, it is quite safe IMO.

Don't know how to implement, thought.

[luisg123v]

if github_login is maintainer of my_module, so allow changes in setup/my_module/ by github_login.

I agree on that

[luisg123v]

if github_login is maintainer of my_module, so allow changes in setup/my_module/ by github_login.

I think this is already working like this, I just merged a case like the described one: OCA/crm#502

[legalsylvain]

OK. I'll make a test !

[legalsylvain]

You're right. It works now !
OCA/geospatial#335 (comment)

[sbidoul]

@legalsylvain any idea of what changed in 6 month to make that work? I don't remember having done something for that myself. Have you?

[legalsylvain]

I don't. I suspect a change of configuration in the server. Is it possible ?

[sbidoul]

I doubt it's related to server configuration. I hope we have not introduced a regression.

[legalsylvain]

I doubt it's related to server configuration.

I'm talking about that param :

https://github.com/OCA/oca-github-bot/blob/master/environment.sample#L84

I hope we have not introduced a regression.

the next time you want to merge something on mis-builder (or other where I have no right), you can ping me and I'll try to call ocabot. Shouldn't work.

[pedrobaeza]

Maybe 16.0 should be in that list?

[sbidoul]

Maybe 16.0 should be in that list?

It is, I just checked.

[yajo]

Sorry, but this should be reopened. Check out OCA/product-attribute#1675 (comment). @Shide maintains the v15 version but can't merge the migration.

[luisg123v]

A recent case: OCA/hr#1397 (comment)