[MIG] pos_product_cost_security: Migration to 17.0

Author: bizzappdev

pos_product_cost_security/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "PoS Product Cost Security",
     "summary": "Compatibility between Point of Sale and Product Cost Security",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "category": "Product",
     "website": "https://github.com/OCA/product-attribute",
     "author": "Tecnativa, Odoo Community Association (OCA)",

pos_product_cost_security/models/product_product.py

@@ -24,6 +24,6 @@ def read(self, fields=None, load="_classic_read"):
             fields=["standard_price"], load=load
         )
         # No we zip both results altogether to feed the PoS data load
-        for res_item, std_price_res_item in zip(result, std_price_result):
+        for res_item, std_price_res_item in zip(result, std_price_result, strict=True):
             res_item["standard_price"] = std_price_res_item["standard_price"]
         return result

pos_product_cost_security/tests/test_pos_product_cost.py

@@ -1,5 +1,6 @@
 # Copyright 2021 Tecnativa - David Vidal
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from odoo.exceptions import AccessError
 from odoo.tests import tagged, users
 
 from odoo.addons.point_of_sale.tests.common import TestPointOfSaleCommon, TestPoSCommon
@@ -11,7 +12,47 @@ class TestPosProductCostSecurity(TestPointOfSaleCommon, TestPoSCommon):
     def setUpClass(cls):
         super().setUpClass()
         cls.config = cls.basic_config
+        cls.product = cls.env.ref("product.product_product_3")
+
+    def _read_product(self, context_values, fields=None):
+        """Read product with given context and fields"""
+        if fields is None:
+            fields = ["name", "standard_price"]
+        return (
+            self.env["product.product"]
+            .with_context(**context_values)
+            .browse(self.product.id)
+            .read(fields)
+        )
+
+    @users("demo")
+    def test_pos_session_open_and_override_loader_params(self):
+        session = self.open_new_session()
+        params = session._loader_params_product_product()
+        product_data = self._read_product(params["context"])
+        self.assertIn("standard_price", product_data[0])
 
     @users("demo")
-    def test_pos_session_open(self):
-        self.session = self.open_new_session()
+    def test_read_without_override_context(self):
+        """User without override should not be able to read standard_price"""
+        with self.assertRaises(
+            AccessError, msg="Should raise AccessError without override"
+        ):
+            self._read_product({"pos_override_cost_security": False})
+
+    @users("demo")
+    def test_read_with_override_context(self):
+        """User with override should see standard_price"""
+        product_data = self._read_product({"pos_override_cost_security": True})
+
+        self.assertIn("name", product_data[0])
+        self.assertIn(
+            "standard_price",
+            product_data[0],
+            "Standard price should be visible with override",
+        )
+        self.assertEqual(
+            product_data[0]["standard_price"],
+            self.env["product.product"].browse(self.product.id).sudo().standard_price,
+            "Standard price should match the product cost",
+        )