[FIX] product_variant_route_mto: rely on stock_route_mto

Author: jbaudoux

product_variant_route_mto/__manifest__.py

@@ -1,4 +1,5 @@
 # Copyright 2023 Camptocamp SA
+# Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
 {
@@ -9,10 +10,10 @@
     "category": "Inventory",
     "website": "https://github.com/OCA/product-attribute",
     "author": "Camptocamp SA, Odoo Community Association (OCA)",
-    "maintainers": ["mmequignon"],
+    "maintainers": ["mmequignon", "jbaudoux"],
     "license": "AGPL-3",
     "installable": True,
     "auto_install": False,
-    "depends": ["stock"],
+    "depends": ["product_route_mto"],
     "data": ["views/product_product.xml"],
 }

product_variant_route_mto/models/product_product.py

@@ -1,4 +1,5 @@
 # Copyright 2023 Camptocamp SA
+# Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
 from odoo import api, fields, models
@@ -16,7 +17,7 @@ class ProductProduct(models.Model):
 
     is_mto = fields.Boolean(
         string="Variant is MTO",
-        compute="_compute_is_mto",
+        related="product_tmpl_id.is_mto",
         store=True,
         readonly=False,
         help=IS_MTO_HELP,
@@ -27,26 +28,28 @@ class ProductProduct(models.Model):
         compute="_compute_route_ids",
         domain="[('product_selectable', '=', True)]",
         store=False,
+        search="_search_route_ids",
     )
 
-    def _compute_is_mto(self):
-        mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False)
-        for product in self:
-            if not mto_route:
-                product.is_mto = False
-                continue
-            product.is_mto = mto_route in product.product_tmpl_id.route_ids
-
     @api.depends("is_mto", "product_tmpl_id.route_ids")
     def _compute_route_ids(self):
-        mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False)
+        mto_routes = self.env["stock.route"].search([("is_mto", "=", True)])
         for product in self:
-            if mto_route and mto_route in product.product_tmpl_id.route_ids:
-                if not product.is_mto:
-                    product.route_ids = product.product_tmpl_id.route_ids - mto_route
-                    continue
-            else:
-                if mto_route and product.is_mto:
-                    product.route_ids = product.product_tmpl_id.route_ids + mto_route
-                    continue
-            product.route_ids = product.product_tmpl_id.route_ids
+            routes = product.product_tmpl_id.route_ids
+            if product.is_mto:
+                routes += mto_routes
+            product.route_ids = routes
+
+    def _search_route_ids(self, operator, value):
+        mto_routes = self.env["stock.route"].search([("is_mto", "=", True)])
+        if operator in ("=", "!=") and value in mto_routes:
+            return [("is_mto", operator, True)]
+        domain = []
+        route_ids = value.copy()
+        for idx, route_id in enumerate(route_ids):
+            if route_id in mto_routes.ids:
+                route_ids.pop(idx)
+                domain = [("is_mto", "=" if operator == "in" else "!=", True)]
+        if route_ids:
+            domain += [("product_tmpl_id.route_ids", operator, route_ids)]
+        return domain

product_variant_route_mto/models/product_template.py

@@ -1,4 +1,5 @@
 # Copyright 2023 Camptocamp SA
+# Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
 from odoo import api, models
@@ -7,33 +8,46 @@
 class ProductTemplate(models.Model):
     _inherit = "product.template"
 
-    def write(self, values):
-        if "route_ids" not in values:
+    def dis_write(self, values):
+        mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False)
+
+        if "route_ids" not in values or not mto_route:
             return super().write(values)
+
         # As _compute_is_mto cannot use api.depends (or it would reset MTO
         # route on variants as soon as there is a change on the template routes),
         # we need to check which template in self had MTO route activated
         # or deactivated to force the recomputation of is_mto on variants
-        mto_route = self.env.ref("stock.route_warehouse0_mto")
-        template_not_mto_before = self.filtered(lambda t: mto_route not in t.route_ids)
+
+        templates_not_mto_before = self.filtered(lambda t: mto_route not in t.route_ids)
+
         res = super().write(values)
+
         templates_mto_after = self.filtered(lambda t: mto_route in t.route_ids)
-        templates_mto_added = template_not_mto_before & templates_mto_after
-        templates_mto_removed = (self - template_not_mto_before) & (
-            self - templates_mto_after
-        )
+        templates_mto_added = templates_not_mto_before & templates_mto_after
+        templates_mto_removed = self - templates_mto_after - templates_not_mto_before
+
         (
             templates_mto_added | templates_mto_removed
         ).product_variant_ids._compute_is_mto()
+
         return res
 
     @api.onchange("route_ids")
     def onchange_route_ids(self):
-        mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False)
-        if (
-            mto_route not in self._origin.route_ids
-            and mto_route in self.route_ids._origin
-        ):
+        mto_routes = self.env["stock.route"].search([("is_mto", "=", True)])
+        if not mto_routes:
+            return
+
+        origin_routes = (
+            self._origin.route_ids if self._origin else self.env["stock.route"]
+        )
+        current_routes = (
+            self.route_ids._origin if self.route_ids else self.env["stock.route"]
+        )
+
+        added_routes = current_routes - origin_routes
+        if set(mto_routes.ids) & set(added_routes.ids):
             # Return warning activating MTO route
             return {
                 "warning": {
@@ -44,10 +58,9 @@ def onchange_route_ids(self):
                     ),
                 }
             }
-        if (
-            mto_route in self._origin.route_ids
-            and mto_route not in self.route_ids._origin
-        ):
+
+        removed_routes = origin_routes - current_routes
+        if set(mto_routes.ids) & set(removed_routes.ids):
             # Return warning deactivating MTO route
             return {
                 "warning": {

product_variant_route_mto/readme/CONTRIBUTORS.md

@@ -1,3 +1,4 @@
 - Matthieu Méquignon \<<[email protected]>\>
 - Akim Juillerat \<<[email protected]>\>
 - Chau Le \<<[email protected]>\>
+- Jacques-Etienne Baudoux (BCIM) \<<[email protected]>\>