[14.0][IMP] product_pricelist_direct_print: allow export product images

[ferran-S73]

Allow exporting the pricelist report with product images. For scaling I set the images dimensions to be 64px at max.

During the development I found some images to be impossible to insert on xlsx, the only way I've found of checking it is by trying the Image.open() with the product image.

Here's an example of the resulting report:

[legalsylvain]

Hi. Thanks for this improvment.
Could you apply changes on the pdf report also ?

[ferran-S73]

Hi. Thanks for this improvment. Could you apply changes on the pdf report also ?

Hey @legalsylvain added support for product images on pdf report too!

[legalsylvain]

Hi. Thanks.
I'd like to test the feature on ruboat, but all the CI is red. (runboat, github actions). See :

from PIL import Image, UnidentifiedImageError
ImportError: cannot import name 'UnidentifiedImageError'

Any idea ?

[ferran-S73]

Hi. Thanks. I'd like to test the feature on ruboat, but all the CI is red. (runboat, github actions). See :

from PIL import Image, UnidentifiedImageError
ImportError: cannot import name 'UnidentifiedImageError'

Any idea ?

Maybe it has to do with the version of PIL that's installed in the runboat? I'll check it out but I'm not sure I can do anything

[legalsylvain]

• On github env, the version is displayed in the log. It is : Pillow 5.4.1
• It is the same version as the Odoo version. (see : https://github.com/odoo/odoo/blob/14.0/requirements.txt#L34)

So, I suspect that you use another more recent version of Pilow.

At the first sight, it seems UnidentifiedImageError that has been introduced in version 7.0.0

[ferran-S73]

• On github env, the version is displayed in the log. It is : Pillow 5.4.1

  • It is the same version as the Odoo version. (see : https://github.com/odoo/odoo/blob/14.0/requirements.txt#L34)

So, I suspect that you use another more recent version of Pilow.

At the first sight, it seems UnidentifiedImageError that has been introduced in version 7.0.0

Hi @legalsylvain , I couldn't find anything equivalent of UndefinedImageError in v5.4.1 so I changed it to a general Exception as it should work as fine here

[legalsylvain]

Yes, v5.4.1 seems quite old !
This will be fixed in more recent version : Version 9.0.1 is pinned for V16 that is quite recent (April 2022).

• https://github.com/odoo/odoo/blob/16.0/requirements.txt#L24
• https://github.com/python-pillow/Pillow/tags

Thanks.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[ferran-S73]

@OCA/product-maintainers could you please review this pr or maybe remove the stale label please?

[legalsylvain]

Hi @ferran-S73. FYI, I'm migrating this module here : #1365

feel free to review this PR.

[pedrobaeza]

Please forward port it to v15

/ocabot merge major

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1231-by-pedrobaeza-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 66e7086. Thanks a lot for contributing to OCA. ❤️

[bosd]

Todo Forward port to:
[ ] V 17 #2105
[ ] V 18 #2106