Skip to content

Conversation

@pfranck
Copy link
Contributor

@pfranck pfranck commented Nov 13, 2024

No description provided.

@pfranck pfranck mentioned this pull request Nov 13, 2024
66 tasks
@pfranck pfranck force-pushed the 18.0-mig-sale_product_template_tags branch from 28a12bb to c3d6b2b Compare January 15, 2025 04:33
@pfranck pfranck force-pushed the 18.0-mig-sale_product_template_tags branch from d26749a to 9335f13 Compare January 16, 2025 03:00
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional 👍🏼

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@JordiMForgeFlow
Copy link
Contributor

@rousseldenis could we get this one merged?

@rousseldenis
Copy link
Contributor

/ocabot migration sale_product_template_tags

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 29, 2025
@OCA-git-bot
Copy link
Contributor

The migration issue (#1741) has not been updated to reference the current pull request because a previous pull request (#1900) is not closed.
Perhaps you should check that there is no duplicate work.
CC @ArnauCForgeFlow

@rousseldenis
Copy link
Contributor

@rousseldenis could we get this one merged?

@JordiMForgeFlow So, we can close #1900 correct ?

@JordiMForgeFlow
Copy link
Contributor

@rousseldenis yes :)

@JordiMForgeFlow
Copy link
Contributor

@rousseldenis could this one get merged? :)

@JordiMForgeFlow
Copy link
Contributor

@pfranck could you rebase?

Copy link
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.