-
-
Notifications
You must be signed in to change notification settings - Fork 781
[18.0][MIG] product_variant_route_mto (was stock_product_variant_mto) #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OCA-git-bot
merged 7 commits into
OCA:18.0
from
jbaudoux:product-attribute-18.0-mig-product_variant_route_mto
May 28, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c6cc07e
Add mto_route_product_variant
mmequignon 90971dc
Refactor mto_route_product_variant
grindtildeath 243f04f
fixup! Refactor mto_route_product_variant
mmequignon fe611da
[IMP] stock_product_variant_mto: pre-commit auto fixes
chaule97 06110c9
[MIG] stock_product_variant_mto: Migration to 18.0
chaule97 c1a124b
[MIG] rename stock_product_variant_mto
chaule97 3b60890
[FIX] product_variant_route_mto: rely on product_route_mto
jbaudoux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| ========================= | ||
| Product Variant Route MTO | ||
| ========================= | ||
|
|
||
| .. | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! This file is generated by oca-gen-addon-readme !! | ||
| !! changes will be overwritten. !! | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| !! source digest: sha256:19127c85672968523ba9dac247eafabed27aaff202e5e8cc20d87b1f6ee204c6 | ||
| !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| .. |badge1| image:: https://img.shields.io/badge/maturity-Alpha-red.png | ||
| :target: https://odoo-community.org/page/development-status | ||
| :alt: Alpha | ||
| .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
| :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
| :alt: License: AGPL-3 | ||
| .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github | ||
| :target: https://github.com/OCA/product-attribute/tree/18.0/product_variant_route_mto | ||
| :alt: OCA/product-attribute | ||
| .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
| :target: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_variant_route_mto | ||
| :alt: Translate me on Weblate | ||
| .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
| :target: https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&target_branch=18.0 | ||
| :alt: Try me on Runboat | ||
|
|
||
| |badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
|
||
| This module allows to define if a product variant can use the Make To | ||
| Order route without any dependency on its template routes settings. | ||
|
|
||
| .. IMPORTANT:: | ||
| This is an alpha version, the data model and design can change at any time without warning. | ||
| Only for development or testing purpose, do not use in production. | ||
| `More details on development status <https://odoo-community.org/page/development-status>`_ | ||
|
|
||
| **Table of contents** | ||
|
|
||
| .. contents:: | ||
| :local: | ||
|
|
||
| Bug Tracker | ||
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/product-attribute/issues>`_. | ||
| In case of trouble, please check there if your issue has already been reported. | ||
| If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
| `feedback <https://github.com/OCA/product-attribute/issues/new?body=module:%20product_variant_route_mto%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
|
||
| Do not contact contributors directly about support or help with technical issues. | ||
|
|
||
| Credits | ||
| ======= | ||
|
|
||
| Authors | ||
| ------- | ||
|
|
||
| * Camptocamp SA | ||
|
|
||
| Contributors | ||
| ------------ | ||
|
|
||
| - Matthieu Méquignon <[email protected]> | ||
| - Akim Juillerat <[email protected]> | ||
|
|
||
| Maintainers | ||
| ----------- | ||
|
|
||
| This module is maintained by the OCA. | ||
|
|
||
| .. image:: https://odoo-community.org/logo.png | ||
| :alt: Odoo Community Association | ||
| :target: https://odoo-community.org | ||
|
|
||
| OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
| mission is to support the collaborative development of Odoo features and | ||
| promote its widespread use. | ||
|
|
||
| .. |maintainer-mmequignon| image:: https://github.com/mmequignon.png?size=40px | ||
| :target: https://github.com/mmequignon | ||
| :alt: mmequignon | ||
|
|
||
| Current `maintainer <https://odoo-community.org/page/maintainer-role>`__: | ||
|
|
||
| |maintainer-mmequignon| | ||
|
|
||
| This module is part of the `OCA/product-attribute <https://github.com/OCA/product-attribute/tree/18.0/product_variant_route_mto>`_ project on GitHub. | ||
|
|
||
| You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| from . import models |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Copyright 2023 Camptocamp SA | ||
| # Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]> | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl) | ||
|
|
||
| { | ||
| "name": "Product Variant Route MTO", | ||
| "summary": "Allow to individually set variants as MTO", | ||
| "version": "18.0.1.0.0", | ||
| "development_status": "Alpha", | ||
| "category": "Inventory", | ||
| "website": "https://github.com/OCA/product-attribute", | ||
| "author": "Camptocamp SA, Odoo Community Association (OCA)", | ||
| "maintainers": ["mmequignon", "jbaudoux"], | ||
| "license": "AGPL-3", | ||
| "installable": True, | ||
| "auto_install": False, | ||
| "depends": ["product_route_mto"], | ||
| "data": ["views/product_product.xml"], | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| from . import product_product | ||
| from . import product_template |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| # Copyright 2023 Camptocamp SA | ||
| # Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]> | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl) | ||
|
|
||
| from odoo import api, fields, models | ||
| from odoo.exceptions import ValidationError | ||
|
|
||
| IS_MTO_HELP = """ | ||
| Check or Uncheck this field to enable the Make To Order on the variant, | ||
| independantly from its template configuration.\n | ||
| Please note that activating or deactivating Make To Order on the template, | ||
| will reset this setting on its variants. | ||
| """ | ||
|
|
||
|
|
||
| class ProductProduct(models.Model): | ||
| _inherit = "product.product" | ||
|
|
||
| is_mto = fields.Boolean( | ||
| string="Variant is MTO", | ||
| compute="_compute_is_mto", | ||
| store=True, | ||
| readonly=False, | ||
| help=IS_MTO_HELP, | ||
| ) | ||
|
|
||
| route_ids = fields.Many2many( | ||
| "stock.route", | ||
| compute="_compute_route_ids", | ||
| domain="[('product_selectable', '=', True)]", | ||
| store=False, | ||
| search="_search_route_ids", | ||
| ) | ||
|
|
||
| def _compute_is_mto(self): | ||
| for product in self: | ||
| product.is_mto = product.product_tmpl_id.is_mto | ||
|
|
||
| @api.depends("is_mto", "product_tmpl_id.route_ids") | ||
| def _compute_route_ids(self): | ||
| mto_routes = self.env["stock.route"].search([("is_mto", "=", True)]) | ||
| for product in self: | ||
| routes = product.product_tmpl_id.route_ids | ||
| if product.is_mto: | ||
| routes += mto_routes | ||
| product.route_ids = routes | ||
|
|
||
| def _search_route_ids(self, operator, value): | ||
| mto_routes = self.env["stock.route"].search([("is_mto", "=", True)]) | ||
| if operator in ("=", "!=") and value in mto_routes: | ||
| return [("is_mto", operator, True)] | ||
| domain = [] | ||
| route_ids = value.copy() | ||
| for idx, route_id in enumerate(route_ids): | ||
| if route_id in mto_routes.ids: | ||
| route_ids.pop(idx) | ||
| domain = [("is_mto", "=" if operator == "in" else "!=", True)] | ||
| if route_ids: | ||
| domain += [("product_tmpl_id.route_ids", operator, route_ids)] | ||
| return domain | ||
|
|
||
| @api.constrains("is_mto") | ||
| def _check_template_is_mto(self): | ||
| for product in self: | ||
| if not product.is_mto and product.product_tmpl_id.is_mto: | ||
| raise ValidationError( | ||
| self.env._( | ||
| "You cannot mark a variant as non MTO when the product is MTO" | ||
| ) | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| # Copyright 2023 Camptocamp SA | ||
| # Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]> | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl) | ||
|
|
||
| from odoo import api, models | ||
|
|
||
|
|
||
| class ProductTemplate(models.Model): | ||
| _inherit = "product.template" | ||
|
|
||
| def write(self, values): | ||
| if "route_ids" not in values: | ||
| return super().write(values) | ||
|
|
||
| # As _compute_is_mto cannot use api.depends (or it would reset MTO | ||
| # route on variants as soon as there is a change on the template routes), | ||
| # we need to check which template in self had MTO route activated | ||
| # or deactivated to force the recomputation of is_mto on variants | ||
| templates_mto_before = self.filtered("is_mto") | ||
| templates_not_mto_before = self - templates_mto_before | ||
|
|
||
| res = super().write(values) | ||
|
|
||
| templates_mto_after = self.filtered("is_mto") | ||
| templates_not_mto_after = self - templates_mto_after | ||
|
|
||
| templates_mto_added = templates_not_mto_before & templates_mto_after | ||
| templates_mto_removed = templates_not_mto_after & templates_mto_before | ||
|
|
||
| ( | ||
| templates_mto_added | templates_mto_removed | ||
| ).product_variant_ids._compute_is_mto() | ||
|
|
||
| return res | ||
|
|
||
| @api.onchange("route_ids") | ||
| def onchange_route_ids(self): | ||
| mto_routes = self.env["stock.route"].search([("is_mto", "=", True)]) | ||
| if not mto_routes: | ||
| return | ||
|
|
||
| origin_routes = ( | ||
| self._origin.route_ids if self._origin else self.env["stock.route"] | ||
| ) | ||
| current_routes = ( | ||
| self.route_ids._origin if self.route_ids else self.env["stock.route"] | ||
| ) | ||
|
|
||
| added_routes = current_routes - origin_routes | ||
| if set(mto_routes.ids) & set(added_routes.ids): | ||
| # Return warning activating MTO route | ||
| return { | ||
| "warning": { | ||
| "title": self.env._("Warning"), | ||
| "message": self.env._( | ||
| "Activating MTO route will reset `Variant is MTO` " | ||
| "setting on the variants." | ||
| ), | ||
| } | ||
| } | ||
|
|
||
| removed_routes = origin_routes - current_routes | ||
| if set(mto_routes.ids) & set(removed_routes.ids): | ||
| # Return warning deactivating MTO route | ||
| return { | ||
| "warning": { | ||
| "title": self.env._("Warning"), | ||
| "message": self.env._( | ||
| "Deactivating MTO route will reset `Variant is MTO` " | ||
| "setting on the variants." | ||
| ), | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [build-system] | ||
| requires = ["whool"] | ||
| build-backend = "whool.buildapi" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| The checkbox `Variant is MTO` on the product variant allows | ||
| to force usage or non-usage of the MTO route for the variant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| - Matthieu Méquignon \<<[email protected]>\> | ||
| - Akim Juillerat \<<[email protected]>\> | ||
| - Chau Le \<<[email protected]>\> | ||
| - Jacques-Etienne Baudoux (BCIM) \<<[email protected]>\> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| The development and migration of this module has been financially supported by: | ||
|
|
||
| - Camptocamp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| This module allows to set a product variant as MTO (enabling the Make To | ||
| Order route on that variant only) while the related product is not MTO. | ||
| However, you cannot mark a variant has non MTO when the template is MTO. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.