[18.0][REF] product_pricelist_direct_print_xlsx #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code refactoring made with purpose of making the module easier to extend. Since `xlsxwriter` is "write only" library, there was no way to easily change the properties of printed table. The changes are focused on separating preparation of data / labels / formats. That way any extension module can change the order of the columns, data formats or add new columns anywhere in the table. For example, prior to this change, to add a new column before the "Description" column, only way was to override `_create_product_pricelist_sheet` and `_fill_data` methods or rewrite whole workbook from scratch after the original methods are done.
maciej-wichowski
force-pushed
the
18.0-ref_product_pricelist_direct_print_xlsx
branch
from
0b3b528 to
975ffcf
Compare
Author
|
ping @CarlosRoca13 @pedrobaeza @carlosdauden @eduezerouali-tecnativa |
Member
|
OK about the initial purpose. Please check CI. |
maciej-wichowski
force-pushed
the
18.0-ref_product_pricelist_direct_print_xlsx
branch
from
43f9334 to
975ffcf
Compare
Author
|
@pedrobaeza CI is failing, but it's not related to current changes. |
carlosdauden
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code refactoring made with purpose of making the module easier to extend. Since
xlsxwriteris "write only" library, there was no way to easily change the properties of printed table. The changes are focused on separating preparation of data / labels / formats.That way any extension module can change the order of the columns, data formats or add new columns anywhere in the table. For example, prior to this change, to add a new column before the "Description" column, only way was to override
_create_product_pricelist_sheetand_fill_datamethods or rewrite whole workbook from scratch after the original methods are done.