[16.0][IMP] product_lot_sequence: product sequence exceptions

[chienandalu]

There might be cases where we don't want to assign specific sequences to our
product and keep the core behavior. For that we've created a flag that allows
to do so.

• The flag Use specific sequence is on by default.
• Set it off and the product will behave as in Odoo core.
• Once you do so, you can remove the product's lot sequence as well.

(TODO: remove this vídeo, as it's an old version of the change)
https://www.loom.com/share/4edde17a26ef4d2f9d909e59ea538f7b?sid=86bbaefb-926b-46a8-982f-c9b1a800e364

cc @moduon MT-12305

please review @rafaelbn @fcvalgar @Shide

[Shide]

Would be great to have this variable inversed in meaning with a migration script.
Seems more readable and less confusing

Suggested change

	disallow_lot_sequence = fields.Boolean(
	help="Don't use an specific lot sequence for this product"
	)
	use_specific_lot_sequence = fields.Boolean(
	help="Use an specific lot sequence for this product",
	default=True,
	)

[chienandalu]

Done

[yajo]

IMHO the fact that checking (or unchecking, as per https://github.com/OCA/product-attribute/pull/2109/files#r2451880343) a checkbox removes or creates a record is a bit surprising.

I think that we can do a better UI:

When removing, add a confirm="Are you sure?" or similar to the button.

This way, the effect and usability is nearly the same, but we avoid surprises.

[chienandalu]

@Shide @yajo changes done. Take a look

[fcvalgar]

Functional Review,

LGTM, thank you @chienandalu

[yajo]

When creating a new product, I think this is inconsistent:

Then, if you do this:

1. Select "by lots"
2. Create sequence
3. Uncheck "use specific lot sequence".

You get another inconsistency:

I think the problem is that the check box is now unnecessary. See comments below. If we remove the checkbox, it's gonna be less code and simpler UX.

Thanks!

[yajo]

This field can be removed now, and all other uses of it.

Since the creation or removal is done by buttons, then the presence or absence of a sequence is enough to make the module work.

[chienandalu]

No, because there's an automation that creates the sequence on every write if it isn't one and we want to avoid that (and I don't want to change that behavior that might affect other users of the module)

[yajo]

Even in that case, the behavior is inconsistent if we have 2 ways to do the same.

However, if that's the goal, there's an easier way to achieve it. Just add support for a new system parameter that disables the automatic creation of sequences, so if the user wants one, they just have to click on the create button.

[yajo]

This method should start by checking that if tracking == "none", then product.display_lot_sequence_fields = False.

Otherwise, just use the default value from config, since the checkbox should be removed.

[yajo]

Suggested change

@api.model