[16.0][MIG] uom_extra_data: Migration to 16.0 #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huguesdk
reviewed
Nov 5, 2025
| <field name="uom_type">smaller</field> | ||
| </record> | ||
|
|
||
| <record id="product_uom_millilitre" model="uom.uom"> |
Member
There was a problem hiding this comment.
this id uses the british spelling, while the millimeter one uses the us spelling. i think it would be better to rename this to product_uom_milliliter for consistency. this needs a pre-migration script using openupgradelib.openupgrade.rename_xmlids().
Member
There was a problem hiding this comment.
the same discrepancy exists in odoo: uom.product_uom_meter and uom.product_uom_litre, so lgtm like this.
huguesdk
approved these changes
Nov 5, 2025
| <field name="uom_type">smaller</field> | ||
| </record> | ||
|
|
||
| <record id="product_uom_millilitre" model="uom.uom"> |
Member
There was a problem hiding this comment.
the same discrepancy exists in odoo: uom.product_uom_meter and uom.product_uom_litre, so lgtm like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing had to be changed, I just had to update the version in the manifest.