[MIG] purchase_tag: Migration to 18.0

Author: apami0111

purchase_tag/README.rst

@@ -17,13 +17,13 @@ Purchase Tags
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github
-    :target: https://github.com/OCA/purchase-workflow/tree/17.0/purchase_tag
+    :target: https://github.com/OCA/purchase-workflow/tree/18.0/purchase_tag
     :alt: OCA/purchase-workflow
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_tag
+    :target: https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_tag
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&target_branch=17.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -46,7 +46,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/purchase-workflow/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_tag%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_tag%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -61,7 +61,7 @@ Authors
 Contributors
 ------------
 
--  Jasmin Solanki <[email protected]>
+- Jasmin Solanki <[email protected]>
 
 Maintainers
 -----------
@@ -76,6 +76,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/purchase-workflow <https://github.com/OCA/purchase-workflow/tree/17.0/purchase_tag>`_ project on GitHub.
+This module is part of the `OCA/purchase-workflow <https://github.com/OCA/purchase-workflow/tree/18.0/purchase_tag>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

purchase_tag/__manifest__.py

@@ -5,7 +5,7 @@
 {
     "name": "Purchase Tags",
     "summary": "Allows to add multiple tags to purchase orders",
-    "version": "17.0.1.1.1",
+    "version": "18.0.1.0.0",
     "author": "ForgeFlow, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/purchase-workflow",
     "category": "Purchases",

purchase_tag/models/purchase_tag.py

@@ -4,8 +4,7 @@
 
 from random import randint
 
-from odoo import _, api, fields, models
-from odoo.exceptions import ValidationError
+from odoo import api, fields, models
 
 
 class PurchaseTag(models.Model):
@@ -20,34 +19,24 @@ def _get_default_color(self):
     color = fields.Integer(default=lambda self: self._get_default_color())
     parent_id = fields.Many2one("purchase.tag", index=True, ondelete="cascade")
     child_ids = fields.One2many("purchase.tag", "parent_id")
-    parent_path = fields.Char(index=True, unaccent=False)
+    parent_path = fields.Char(index=True)
 
     _sql_constraints = [
         ("tag_name_uniq", "unique (name)", "Tag name already exists !"),
     ]
 
-    def name_get(self):
-        res = []
+    def _compute_display_name(self):
         for tag in self:
             names = []
             current = tag
             while current:
-                names.append(current.name)
+                if current.name:
+                    names.append(current.name)
                 current = current.parent_id
-            res.append((tag.id, " / ".join(reversed(names))))
-        return res
+            display_name = " / ".join(reversed(names))
+            tag.display_name = display_name
 
     @api.model
-    def _name_search(
-        self, name="", domain=None, operator="ilike", limit=100, order=None
-    ):
-        if name:
-            domain = [("name", operator, name.split(" / ")[-1])] + list(domain or [])
-        return super()._name_search(
-            name=name, domain=domain, operator=operator, limit=limit, order=order
-        )
-
-    @api.constrains("parent_id")
-    def _check_parent_recursion(self):
-        if not self._check_recursion("parent_id"):
-            raise ValidationError(_("Tags cannot be recursive."))
+    def _search_display_name(self, operator, value):
+        domain = [("name", operator, value.split(" / ")[-1])]
+        return domain

purchase_tag/static/description/index.html

@@ -369,7 +369,7 @@ <h1 class="title">Purchase Tags</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:4fcd5e13e2e203e5e2591ebf21012a4ccae8a559594d518ccc40c71ae9440aad
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/purchase-workflow/tree/17.0/purchase_tag"><img alt="OCA/purchase-workflow" src="https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_tag"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/purchase-workflow/tree/18.0/purchase_tag"><img alt="OCA/purchase-workflow" src="https://img.shields.io/badge/github-OCA%2Fpurchase--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/purchase-workflow-18-0/purchase-workflow-18-0-purchase_tag"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/purchase-workflow&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module allows to add multiple tags to purchase orders</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
@@ -393,7 +393,7 @@ <h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/purchase-workflow/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_tag%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/purchase-workflow/issues/new?body=module:%20purchase_tag%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -419,7 +419,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/purchase-workflow/tree/17.0/purchase_tag">OCA/purchase-workflow</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/purchase-workflow/tree/18.0/purchase_tag">OCA/purchase-workflow</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

purchase_tag/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_purchase_tag

purchase_tag/tests/test_purchase_tag.py

@@ -0,0 +1,39 @@
+from odoo.exceptions import UserError
+
+from odoo.addons.base.tests.common import BaseCommon
+
+
+class TestPurchaseTag(BaseCommon):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        PurchaseTag = cls.env["purchase.tag"]
+        cls.tag_parent = PurchaseTag.create({"name": "Parent"})
+        cls.tag_child = PurchaseTag.create(
+            {"name": "Child", "parent_id": cls.tag_parent.id}
+        )
+        cls.tag_grandchild = PurchaseTag.create(
+            {"name": "Grandchild", "parent_id": cls.tag_child.id}
+        )
+
+    def test_display_name_computation(self):
+        # Verify the hierarchical display_name.
+        self.assertEqual(
+            self.tag_grandchild.display_name, "Parent / Child / Grandchild"
+        )
+        self.assertEqual(self.tag_child.display_name, "Parent / Child")
+        self.assertEqual(self.tag_parent.display_name, "Parent")
+
+    def test_name_search(self):
+        # Perform a search using part of the display_name.
+        results = self.env["purchase.tag"].name_search(
+            name="Parent / Child / Grandchild"
+        )
+        self.assertTrue(results)
+        self.assertEqual(results[0][0], self.tag_grandchild.id)
+        self.assertEqual(results[0][1], "Parent / Child / Grandchild")
+
+    def test_recursion_error(self):
+        # Trigger recursion to raise a UserError from Odoo's core.
+        with self.assertRaisesRegex(UserError, "Recursion Detected."):
+            self.tag_parent.write({"parent_id": self.tag_grandchild.id})

purchase_tag/views/purchase_tag_view.xml

@@ -32,11 +32,11 @@
         <field name="name">purchase.tag.view.tree</field>
         <field name="model">purchase.tag</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="parent_id" optional="hide" />
                 <field name="color" widget="color_picker" />
-            </tree>
+            </list>
         </field>
     </record>