[ADD] deprecated-name-get: name_get deprecated since v17

'name_get' is deprecated since v17. More info at odoo/odoo#122085.

Author: sbejaoui

README.md

@@ -26,6 +26,7 @@ bad-builtin-groupby | Used builtin function `itertools.groupby`. Prefer `odoo.to
 category-allowed | Category "%s" not allowed in manifest file. | C8114
 consider-merging-classes-inherited | Consider merging classes inherited to "%s" from %s. | R8180
 context-overridden | Context overridden using dict. Better using kwargs `with_context(**%s)` or `with_context(key=value)` | W8121
+deprecated-name-get | 'name_get' is deprecated. Use '_compute_display_name' instead. More info at https://github.com/odoo/odoo/pull/122085. | E8146
 deprecated-odoo-model-method | %s has been deprecated by Odoo. Please look for alternatives. | W8160
 development-status-allowed | Manifest key development_status "%s" not allowed. Use one of: %s. | C8111
 except-pass | pass into block except. If you really need to use the pass consider logging that exception | W8138
@@ -176,6 +177,10 @@ Checks valid only for odoo <= 13.0
     - https://github.com/OCA/pylint-odoo/blob/v9.3.2/testing/resources/test_repo/broken_module/models/broken_model.py#L197 Context overridden using dict. Better using kwargs `with_context(**ctx)` or `with_context(key=value)`
     - https://github.com/OCA/pylint-odoo/blob/v9.3.2/testing/resources/test_repo/broken_module/models/broken_model.py#L199 Context overridden using dict. Better using kwargs `with_context(**ctx2)` or `with_context(key=value)`
 
+ * deprecated-name-get
+
+    - https://github.com/OCA/pylint-odoo/blob/v9.3.2/testing/resources/test_repo/twelve_module/models.py#L7 'name_get' is deprecated. Use '_compute_display_name' instead. More info at https://github.com/odoo/odoo/pull/122085.
+
  * deprecated-odoo-model-method
 
     - https://github.com/OCA/pylint-odoo/blob/v9.3.2/testing/resources/test_repo/broken_module/models/broken_model.py#L94 fields_view_get has been deprecated by Odoo. Please look for alternatives.

src/pylint_odoo/checkers/odoo_addons.py

@@ -190,6 +190,11 @@
         "manifest-behind-migrations",
         "Update your manifest version, otherwise the migration script won't run",
     ),
+    "E8146": (
+        "'name_get' is deprecated. Use '_compute_display_name' instead. More info at https://github.com/odoo/odoo/pull/122085.",
+        "deprecated-name-get",
+        CHECK_DESCRIPTION,
+    ),
     "F8101": ('File "%s": "%s" not found.', "resource-not-exist", CHECK_DESCRIPTION),
     "R8101": (
         "`odoo.exceptions.Warning` is a deprecated alias to `odoo.exceptions.UserError` "
@@ -580,6 +585,7 @@ class OdooAddons(OdooBaseChecker, BaseChecker):
         },
         "no-raise-unlink": {"odoo_minversion": "15.0"},
         "prefer-env-translation": {"odoo_minversion": "18.0"},
+        "deprecated-name-get": {"odoo_minversion": "17.0"},
     }
 
     def __init__(self, linter: PyLinter):
@@ -1244,7 +1250,11 @@ def check_deprecated_odoo_method(self, node: NodeNG) -> bool:
         return node.name in self._deprecated_odoo_methods
 
     @utils.only_required_for_messages(
-        "method-required-super", "prohibited-method-override", "missing-return", "deprecated-odoo-model-method"
+        "method-required-super",
+        "prohibited-method-override",
+        "missing-return",
+        "deprecated-odoo-model-method",
+        "deprecated-name-get",
     )
     def visit_functiondef(self, node):
         """Check that `api.one` and `api.multi` decorators not exists together
@@ -1256,7 +1266,8 @@ def visit_functiondef(self, node):
 
         if self.is_odoo_message_enabled("deprecated-odoo-model-method") and self.check_deprecated_odoo_method(node):
             self.add_message("deprecated-odoo-model-method", node=node, args=(node.name,))
-
+        if self.is_odoo_message_enabled("deprecated-name-get") and node.name == "name_get":
+            self.add_message("deprecated-name-get", node=node)
         if node.name in self.linter.config.method_required_super:
             calls = [
                 call_func.func.name

testing/resources/test_repo/twelve_module/models.py

@@ -2,4 +2,8 @@
 
 
 class TwelveModel(models.Model):
-    _name = 'twelve.model'
+    _name = "twelve.model"
+
+    def name_get(self):
+        # do staff
+        return super().name_get()

tests/test_main.py

@@ -24,6 +24,7 @@
     "bad-builtin-groupby": 2,
     "consider-merging-classes-inherited": 2,
     "context-overridden": 3,
+    "deprecated-name-get": 1,
     "development-status-allowed": 1,
     "except-pass": 3,
     "external-request-timeout": 51,
@@ -159,6 +160,7 @@ def test_25_checks_excluding_by_odoo_version(self):
             "translation-too-few-args",
             "translation-too-many-args",
             "translation-unsupported-format",
+            "deprecated-name-get",
         }
         self.default_extra_params += ["--valid-odoo-versions=13.0"]
         pylint_res = self.run_pylint(self.paths_modules)
@@ -177,6 +179,7 @@ def test_35_checks_emiting_by_odoo_version(self):
         expected_errors = self.expected_errors.copy()
         expected_errors.update({"manifest-version-format": 6})
         excluded_msgs = {
+            "deprecated-name-get",
             "deprecated-odoo-model-method",
             "no-raise-unlink",
             "prefer-env-translation",