[MIG] sql_export: Migration to 19.0

Author: feketemihai

sql_export/README.rst

@@ -21,13 +21,13 @@ SQL Export
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Freporting--engine-lightgray.png?logo=github
-    :target: https://github.com/OCA/reporting-engine/tree/18.0/sql_export
+    :target: https://github.com/OCA/reporting-engine/tree/19.0/sql_export
     :alt: OCA/reporting-engine
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export
+    :target: https://translation.odoo-community.org/projects/reporting-engine-19-0/reporting-engine-19-0-sql_export
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/reporting-engine&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/reporting-engine&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -81,7 +81,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/reporting-engine/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/reporting-engine/issues/new?body=module:%20sql_export%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/reporting-engine/issues/new?body=module:%20sql_export%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -135,6 +135,6 @@ Current `maintainers <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-legalsylvain| |maintainer-florian-dacosta| 
 
-This module is part of the `OCA/reporting-engine <https://github.com/OCA/reporting-engine/tree/18.0/sql_export>`_ project on GitHub.
+This module is part of the `OCA/reporting-engine <https://github.com/OCA/reporting-engine/tree/19.0/sql_export>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sql_export/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
     "name": "SQL Export",
-    "version": "18.0.1.1.1",
+    "version": "19.0.0.0.0",
     "author": "Akretion,GRAP,Odoo Community Association (OCA)",
     "maintainers": ["legalsylvain", "florian-dacosta"],
     "website": "https://github.com/OCA/reporting-engine",

sql_export/security/sql_export_security.xml

@@ -9,6 +9,6 @@
         <field eval="0" name="perm_unlink" />
         <field
             name="domain_force"
-        >['|', ('user_ids','=',user.id), ('group_ids','in', [x.id for x in user.groups_id])]</field>
+        >['|', ('user_ids','=',user.id), ('group_ids','in', [x.id for x in user.group_ids])]</field>
     </record>
 </odoo>

sql_export/static/description/index.html

@@ -374,7 +374,7 @@ <h1>SQL Export</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:4f5b18eab71ba067ea88439b72cfd484c0c761faa38f715000ea4ced8f78725c
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/reporting-engine/tree/18.0/sql_export"><img alt="OCA/reporting-engine" src="https://img.shields.io/badge/github-OCA%2Freporting--engine-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_export"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/reporting-engine&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/reporting-engine/tree/19.0/sql_export"><img alt="OCA/reporting-engine" src="https://img.shields.io/badge/github-OCA%2Freporting--engine-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/reporting-engine-19-0/reporting-engine-19-0-sql_export"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/reporting-engine&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Allow to export data in csv files FROM sql requests. There are some
 restrictions in the sql query, you can only read datas. No update,
 deletion or creation are possible. A new sub menu named Sql Export is
@@ -432,7 +432,7 @@ <h2><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/reporting-engine/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/reporting-engine/issues/new?body=module:%20sql_export%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/reporting-engine/issues/new?body=module:%20sql_export%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -474,7 +474,7 @@ <h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainers</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/legalsylvain"><img alt="legalsylvain" src="https://github.com/legalsylvain.png?size=40px" /></a> <a class="reference external image-reference" href="https://github.com/florian-dacosta"><img alt="florian-dacosta" src="https://github.com/florian-dacosta.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/reporting-engine/tree/18.0/sql_export">OCA/reporting-engine</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/reporting-engine/tree/19.0/sql_export">OCA/reporting-engine</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

sql_export/tests/test_sql_query.py

@@ -15,12 +15,55 @@ def setUpClass(cls):
         super().setUpClass()
         cls.sql_export_obj = cls.env["sql.export"]
         cls.wizard_obj = cls.env["sql.file.wizard"]
-        cls.sql_report_demo = cls.env.ref("sql_export.sql_export_partner")
+        cls.sql_export_partner = cls.sql_export_obj.create(
+            {
+                "name": "Export Partners",
+                "query": "SELECT name, street FROM res_partner",
+            }
+        )
+        cls.sql_export_partner.button_validate_sql_expression()
+        cls.sql_export_partner_variables = cls.sql_export_obj.create(
+            {
+                "name": "Export Partners with variables",
+                "query": """
+SELECT p.id
+FROM res_partner p
+LEFT JOIN res_partner_res_partner_category_rel rel
+    ON rel.partner_id = p.id
+WHERE create_date > %(Date)s
+    AND id = %(ID)s
+    AND rel.category_id in %(Categories)s
+                """,
+                "query_properties_definition": [
+                    {
+                        "name": "630eca383bc142e6",
+                        "string": "Date",
+                        "type": "date",
+                        "default": "",
+                    },
+                    {
+                        "name": "ec0556e22932334b",
+                        "string": "Categories",
+                        "type": "many2many",
+                        "default": False,
+                        "comodel": "res.partner.category",
+                        "domain": False,
+                    },
+                    {
+                        "name": "907ac618eccbab74",
+                        "string": "ID",
+                        "type": "integer",
+                        "default": False,
+                    },
+                ],
+            }
+        )
+        cls.sql_export_partner_variables.button_validate_sql_expression()
 
     def test_sql_query(self):
         wizard = self.wizard_obj.create(
             {
-                "sql_export_id": self.sql_report_demo.id,
+                "sql_export_id": self.sql_export_partner.id,
             }
         )
         wizard.export_sql()
@@ -61,12 +104,15 @@ def test_authorized_queries(self):
             )
 
     def test_sql_query_with_params(self):
-        query = self.env.ref("sql_export.sql_export_partner_with_variables")
-        query.write({"state": "sql_valid"})
-        categ_id = self.env.ref("base.res_partner_category_0").id
+        categ = self.env["res.partner.category"].search([], limit=1)
+        if not categ:
+            categ = self.env["res.partner.category"].create(
+                {"name": "Consulting Services"}
+            )
+        categ_id = categ.id
         wizard = self.wizard_obj.create(
             {
-                "sql_export_id": query.id,
+                "sql_export_id": self.sql_export_partner_variables.id,
             }
         )
         wizard.write(

sql_export/wizard/wizard_file.py

@@ -4,7 +4,7 @@
 
 from datetime import datetime
 
-from odoo import _, fields, models
+from odoo import fields, models
 from odoo.exceptions import UserError
 from odoo.tools import DEFAULT_SERVER_DATETIME_FORMAT
 
@@ -31,10 +31,11 @@ def export_sql(self):
         bad_props = [x for x in properties if not x["value"]]
         if bad_props:
             raise UserError(
-                _("Please enter a values for the following properties : %s")
-                % (",".join([x["string"] for x in bad_props]))
+                self.env._(
+                    "Please enter a values for the following properties : %(props)s",
+                    {"props": ", ".join([x["string"] for x in bad_props])},
+                )
             )
-
         sql_export = self.sql_export_id
 
         # Manage Params
@@ -73,21 +74,22 @@ def export_sql(self):
         self.env.cr.execute(
             """
             UPDATE sql_export
-            SET last_execution_date = %s, last_execution_uid = %s
-            WHERE id = %s
+            SET last_execution_date = %(last_date)s, last_execution_uid = %(last_uid)s
+            WHERE id = %(id)s
         """,
-            (
-                fields.Datetime.to_string(fields.Datetime.now()),
-                self.env.user.id,
-                sql_export.id,
-            ),
+            {
+                "last_date": fields.Datetime.to_string(fields.Datetime.now()),
+                "last_uid": self.env.user.id,
+                "id": sql_export.id,
+            },
         )
+        url = f"""web/content/?model={self._name}&id={self.id}&
+            filename_field=file_name&"field=binary_file&download=true&
+            filename={self.file_name}"""
         action = {
             "name": "SQL Export",
             "type": "ir.actions.act_url",
-            "url": "web/content/?model=%s&id=%d&filename_field=filename&"
-            "field=binary_file&download=true&filename=%s"
-            % (self._name, self.id, self.file_name),
+            "url": url,
             "target": "self",
         }
         return action