Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] 14.0 rma_sale: questions about quantities #268

Closed
francesco-ooops opened this issue May 3, 2022 · 4 comments
Closed

[RFC] 14.0 rma_sale: questions about quantities #268

francesco-ooops opened this issue May 3, 2022 · 4 comments
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@francesco-ooops
Copy link
Contributor

Hi, I noticed two behaviors I'm unsure about:

  1. RMA from SO for more products than those ordered

STEPS TO REPRODUCE

  • create SO with deliverable products > confirm > validate picking
  • back in SO: create RMA > input in popup a quantity higher than the one displayed >accept

CURRENT BEHAVIOR
RMA is created for qty inputted

REQUIRED BEHAVIOR
Is there a scenario where user would willfully create an RMA for more quantities than those ordered? Probably a warning of qty in RMA > qty ordered after clicking "accept" could be good to make sure

  1. RMA from SO for more products than those delivered

STEPS TO REPRODUCE

  • create SO with deliverable products > confirm > do NOT validate picking
  • back in SO: create RMA > input in popup a quantity higher than the one displayed (0) >accept

CURRENT BEHAVIOR
RMA is created for qty inputted

REQUIRED BEHAVIOR
Again, I'm not sure what is the use case for creating RMAs for products that have not yet been delivered, but a warning could be useful in preventing errors.

@ernestotejeda what is your opinion on this? Thanks!

@pedrobaeza
Copy link
Member

Always indicate Odoo version, and both behavior were not allowed back in v12/v13 where we created it.

@francesco-ooops francesco-ooops changed the title [RFC] rma_sale: questions about quantities [RFC] 14.0 rma_sale: questions about quantities May 3, 2022
@francesco-ooops
Copy link
Contributor Author

Always indicate Odoo version, and both behavior were not allowed back in v12/v13 where we created it.

Thank you, you're right! @ernestotejeda do you think it's an intended change or something lost in migration? Shall we fix v.14?

@francesco-ooops
Copy link
Contributor Author

Always indicate Odoo version, and both behavior were not allowed back in v12/v13 where we created it.

Hmm, I see that behavior is currently the same in v.13 (user can create RMAs in SO for qty > ordered/delivered qty). I just think a warning can be a good compromise rather than blocking the action for user

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

2 participants