From c178a004f00e182b1ea065d70ad08fdb958cd6c8 Mon Sep 17 00:00:00 2001 From: Ethan Hildick Date: Mon, 21 Aug 2023 13:10:52 +0200 Subject: [PATCH] [IMP] sale_triple_discount: Compute amount with decimal precision of 16 Equivalent to the current computation in invoices https://github.com/OCA/account-invoicing/blob/d2e12c03b50011bb788cf482346710f0fefe0de3/account_invoice_triple_discount/models/account_move_line.py#L73-L74 --- sale_triple_discount/models/sale_order_line.py | 5 +++++ sale_triple_discount/tests/test_sale_triple_discount.py | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/sale_triple_discount/models/sale_order_line.py b/sale_triple_discount/models/sale_order_line.py index a23b3e3d2cf5..e3798e1826df 100644 --- a/sale_triple_discount/models/sale_order_line.py +++ b/sale_triple_discount/models/sale_order_line.py @@ -103,6 +103,9 @@ def triple_discount_preprocess(self): Updating the cache provides consistency through re-computations.""" prev_values = dict() self.invalidate_cache(fnames=self._discount_fields(), ids=self.ids) + digits = self._fields["discount"]._digits + self.env["sale.order.line"]._fields["discount"]._digits = (16, 16) + prev_values["discount_digits"] = digits for line in self: prev_values[line] = { fname: line[fname] for fname in self._discount_fields() @@ -118,10 +121,12 @@ def triple_discount_preprocess(self): def triple_discount_postprocess(self, prev_values): """Restore the discounts of the lines in the dictionary prev_values. Updating the cache provides consistency through re-computations.""" + digits = prev_values.pop("discount_digits") self.invalidate_cache( fnames=self._discount_fields(), ids=[line.id for line in list(prev_values.keys())], ) + self.env["sale.order.line"]._fields["discount"]._digits = digits for line, prev_vals_dict in list(prev_values.items()): line.update(prev_vals_dict) diff --git a/sale_triple_discount/tests/test_sale_triple_discount.py b/sale_triple_discount/tests/test_sale_triple_discount.py index 069e796cb1e2..199673bbc848 100644 --- a/sale_triple_discount/tests/test_sale_triple_discount.py +++ b/sale_triple_discount/tests/test_sale_triple_discount.py @@ -208,3 +208,11 @@ def test_06_discount_0(self): self.assertAlmostEqual(self.so_line2.price_subtotal, 600.0) self.assertAlmostEqual(self.order.amount_untaxed, 1200.0) self.assertAlmostEqual(self.order.amount_tax, 180.0) + + def test_07_discount_16_digits(self): + self.so_line1.product_uom_qty = 2.0 + self.so_line1.price_unit = 138.0 + self.so_line1.discount = 45.0 + self.so_line1.discount2 = 5.0 + self.so_line1.discount3 = 10.0 + self.assertAlmostEqual(self.so_line1.price_subtotal, 129.79)