[MIG] base_substate: Migration to 18.0

absal-smile · absal-smile · commit 5434dee808b1 · 2025-03-25T14:31:43.000Z
diff --git a/base_substate/i18n/it.po b/base_substate/i18n/it.po
@@ -6,15 +6,15 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 16.0\n"
 "Report-Msgid-Bugs-To: \n"
-"PO-Revision-Date: 2025-02-21 18:06+0000\n"
+"PO-Revision-Date: 2024-01-03 09:36+0000\n"
 "Last-Translator: mymage <stefano.consolaro@mymage.it>\n"
 "Language-Team: none\n"
 "Language: it\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
 "Plural-Forms: nplurals=2; plural=n != 1;\n"
-"X-Generator: Weblate 5.6.2\n"
+"X-Generator: Weblate 4.17\n"
 
 #. module: base_substate
 #: model:ir.model.fields,field_description:base_substate.field_base_substate__active
@@ -224,7 +224,7 @@ msgid ""
 "The substate %(name)s is not defined for the state %(state)s but for "
 "%(target_state)s "
 msgstr ""
-"Il substato %(name)s non è definito per lo stato %(state)s ma per "
+"il substato %(name)s non è definito per lo sato %(state)s ma per "
 "%(target_state)s "
 
 #. module: base_substate
diff --git a/base_substate/models/base_substate_mixin.py b/base_substate/models/base_substate_mixin.py
@@ -28,19 +28,19 @@ def check_substate_id_value(self):
                     }
                 )
 
-    def _track_template(self, changes):
-        res = super()._track_template(changes)
-        track = self[0]
-        if "substate_id" in changes and track.substate_id.mail_template_id:
+    def _track_template(self, tracking):
+        res = super()._track_template(tracking)
+        first_rec = self[0]
+        changes, tracking_value_ids = tracking[first_rec.id]
+        if "substate_id" in changes and first_rec.substate_id.mail_template_id:
             res["substate_id"] = (
-                track.substate_id.mail_template_id,
+                first_rec.substate_id.mail_template_id,
                 {
-                    "composition_mode": "comment",
-                    "auto_delete": True,
-                    "subtype_id": self.env["ir.model.data"]._xmlid_to_res_id(
+                    "auto_delete_message": True,
+                    "subtype_id": self.env["ir.model.data"].xmlid_to_res_id(
                         "mail.mt_note"
                     ),
-                    "email_layout_xmlid": "mail.mail_notification_light",
+                    "notif_layout": "mail.mail_notification_light",
                 },
             )
         return res
@@ -72,17 +72,13 @@ def _get_default_substate_domain(self, state_val=False):
         ]
         return domain
 
-    def _get_default_state_value(
-        self,
-    ):
+    def _get_default_state_value(self):
         """Override this method
         to change state_value
         """
         return "draft"
 
-    def _get_substate_type(
-        self,
-    ):
+    def _get_substate_type(self):
         """Override this method
         to change substate_type (get by xml id for example)
         """
@@ -95,18 +91,18 @@ def _get_substate_type(
         string="Sub State",
         ondelete="restrict",
         default=lambda self: self._get_default_substate_id(),
-        tracking=5,
         index=True,
         domain=lambda self: [("model", "=", self._name)],
         copy=False,
+        tracking=True,  # Add tracking parameter here
     )
 
     @api.constrains("substate_id")
     def check_substate_id_consistency(self):
         for mixin_obj in self:
             if mixin_obj.substate_id and mixin_obj.substate_id.model != self._name:
                 raise ValidationError(
-                    _("This substate is not define for this object but for %s")
+                    _("This substate is not defined for this object but for %s")
                     % mixin_obj.substate_id.model
                 )
 
@@ -129,3 +125,9 @@ def create(self, vals_list):
             vals = self._update_before_write_create(vals)
         res = super().create(vals_list)
         return res
+
+    @classmethod
+    def _valid_field_parameter(cls, field, name):
+        if name == "tracking":
+            return True
+        return super()._valid_field_parameter(field, name)
diff --git a/base_substate/tests/sale_test.py b/base_substate/tests/sale_test.py
@@ -30,8 +30,9 @@ class SaleTest(models.Model, TestMixin):
     @api.depends("line_ids")
     def _compute_amount_total(self):
         for record in self:
-            for line in record.line_ids:
-                record.amount_total += line.amount * line.qty
+            record.amount_total = sum(
+                line.amount * line.qty for line in record.line_ids
+            )
 
     def button_confirm(self):
         self.write({"state": "sale"})
diff --git a/base_substate/tests/test_base_substate.py b/base_substate/tests/test_base_substate.py
@@ -20,9 +20,12 @@ def setUpClass(cls):
         cls.base_substate = cls.env["base.substate.mixin"]
         cls.substate_type = cls.env["base.substate.type"]
 
-        cls.substate_type._fields["model"].selection.append(
-            ("base.substate.test.sale", "Sale Order")
+        selection = (
+            cls.substate_type._fields["model"]._description_selection(cls.env) or []
         )
+        if isinstance(selection, list):
+            selection.append(("base.substate.test.sale", "Sale Order"))
+            cls.substate_type._fields["model"].selection = selection
 
         cls.substate_type = cls.env["base.substate.type"].create(
             {
diff --git a/base_substate/views/base_substate_type_views.xml b/base_substate/views/base_substate_type_views.xml
@@ -5,11 +5,11 @@
     <record id="base_substate_type_view_tree" model="ir.ui.view">
         <field name="model">base.substate.type</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="model" />
                 <field name="target_state_field" />
-            </tree>
+            </list>
         </field>
     </record>
     <record id="base_substate_type_view_form" model="ir.ui.view">
@@ -47,7 +47,7 @@
         <field name="name">Sub State Type</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">base.substate.type</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="search_view_id" ref="base_substate_type_view_search" />
         <field name="domain">[]</field>
         <field name="context">{}</field>
@@ -67,7 +67,7 @@
     >
         <field name="act_window_id" ref="act_open_base_substate_type_view" />
         <field name="sequence" eval="10" />
-        <field name="view_mode">tree</field>
+        <field name="view_mode">list</field>
         <field name="view_id" ref="base_substate_type_view_tree" />
     </record>
     <menuitem
diff --git a/base_substate/views/base_substate_value_views.xml b/base_substate/views/base_substate_value_views.xml
@@ -5,11 +5,11 @@
     <record id="target_state_value_view_tree" model="ir.ui.view">
         <field name="model">target.state.value</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="base_substate_type_id" />
                 <field name="target_state_value" />
-            </tree>
+            </list>
         </field>
     </record>
     <record id="target_state_value_view_form" model="ir.ui.view">
@@ -51,7 +51,7 @@
         <field name="name">Target State Value</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">target.state.value</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="search_view_id" ref="target_state_value_view_search" />
         <field name="domain">[]</field>
         <field name="context">{}</field>
@@ -71,7 +71,7 @@
     >
         <field name="act_window_id" ref="act_open_target_state_value_view" />
         <field name="sequence" eval="10" />
-        <field name="view_mode">tree</field>
+        <field name="view_mode">list</field>
         <field name="view_id" ref="target_state_value_view_tree" />
     </record>
     <menuitem
diff --git a/base_substate/views/base_substate_views.xml b/base_substate/views/base_substate_views.xml
@@ -5,13 +5,13 @@
     <record id="base_substate_view_tree" model="ir.ui.view">
         <field name="model">base.substate</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
                 <field name="description" />
                 <field name="sequence" widget="handle" />
                 <field name="target_state_value_id" />
                 <field name="active" widget="boolean_toggle" />
-            </tree>
+            </list>
         </field>
     </record>
     <record id="base_substate_view_form" model="ir.ui.view">
@@ -62,7 +62,7 @@
         <field name="name">Base Substate</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">base.substate</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="search_view_id" ref="base_substate_view_search" />
         <field name="domain">[]</field>
         <field name="context">{}</field>
@@ -76,7 +76,7 @@
     <record model="ir.actions.act_window.view" id="act_open_base_substate_view_tree">
         <field name="act_window_id" ref="act_open_base_substate_view" />
         <field name="sequence" eval="10" />
-        <field name="view_mode">tree</field>
+        <field name="view_mode">list</field>
         <field name="view_id" ref="base_substate_view_tree" />
     </record>
     <menuitem

Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,12 @@ def setUpClass(cls):`
`20`	`20`	`cls.base_substate = cls.env["base.substate.mixin"]`
`21`	`21`	`cls.substate_type = cls.env["base.substate.type"]`
`22`	`22`
`23`		`- cls.substate_type._fields["model"].selection.append(`
`24`		`- ("base.substate.test.sale", "Sale Order")`
	`23`	`+ selection = (`
	`24`	`+ cls.substate_type._fields["model"]._description_selection(cls.env) or []`
`25`	`25`	`)`
	`26`	`+ if isinstance(selection, list):`
	`27`	`+ selection.append(("base.substate.test.sale", "Sale Order"))`
	`28`	`+ cls.substate_type._fields["model"].selection = selection`
`26`	`29`
`27`	`30`	`cls.substate_type = cls.env["base.substate.type"].create(`
`28`	`31`	`{`