[16.0][MIG]stock_orderpoint_route: migration to `16.0` #23

PicchiSeba · 2024-09-27T14:45:31Z

This module was originally from https://github.com/OCA/stock-logistics-warehouse/tree/14.0/ but for 16.0 it has been moved to this repo

To avoid executing the setup for each test

* performance (less queries executed) * disable tracking in tests (faster) * use with_user instead of sudo * the double for loop in _compute_route_ids actually generates one more query as the simple one in this commit (thanks to the cache) * extract a method * the parent locations can be found using 'parent_of' which will use the parent_path under the hood (example: 1/7/8 will return locations 1, 7, 8) [UPD] Update stock_orderpoint_route.pot

[UPD] Update stock_orderpoint_route.pot

This is to avoid issue below for any module that inherits tree view of the model `stock.warehouse.orderpoint`. Example: `stock_orderpoint_manual_procurement` Field route_ids used in field route_id default domain ([('id', 'in', route_ids)]) must be present in view but is missing.

Complete the fix done in 06dfeedc66

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_orderpoint_route Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_orderpoint_route/

rousseldenis

Code review

rousseldenis · 2024-09-27T15:17:27Z

/ocabot migration stock_orderpoint_route

OCA-git-bot · 2024-09-27T15:17:36Z

There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment.

yvaucher

LGTM

Thanks you @PicchiSeba

yvaucher · 2024-09-30T13:39:59Z

/ocabot merge nobump

OCA-git-bot · 2024-09-30T13:40:07Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-23-by-yvaucher-bump-nobump, awaiting test results.

Signed-off-by yvaucher

OCA-git-bot · 2024-09-30T13:44:04Z

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-23-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

yvaucher · 2024-09-30T13:52:16Z

@PicchiSeba seems the merge failed due to the following error:

2024-09-30 13:42:03,203 259 ERROR odoo odoo.addons.stock_location_orderpoint.tests.test_location_orderpoint: ERROR: TestLocationOrderpoint.test_cron_replenishment
Traceback (most recent call last):
  File "/__w/stock-logistics-orderpoint/stock-logistics-orderpoint/stock_location_orderpoint/tests/test_location_orderpoint.py", line 99, in test_cron_replenishment
    tomorrow = now.replace(day=now.day + 1)
ValueError: day is out of range for month

I would advice to use freezegun to get a fixed date in the tests. It most likely fails because today is the 30 september and tomorrow is not the 31 of september ;)

Or you can more simply use fields.Date.add(today, days=1) (thanks @sebalix for the tip)

PicchiSeba · 2024-10-01T08:24:24Z

@PicchiSeba seems the merge failed due to the following error:
2024-09-30 13:42:03,203 259 ERROR odoo odoo.addons.stock_location_orderpoint.tests.test_location_orderpoint: ERROR: TestLocationOrderpoint.test_cron_replenishment
Traceback (most recent call last):
  File "/__w/stock-logistics-orderpoint/stock-logistics-orderpoint/stock_location_orderpoint/tests/test_location_orderpoint.py", line 99, in test_cron_replenishment
    tomorrow = now.replace(day=now.day + 1)
ValueError: day is out of range for month
I would advice to use freezegun to get a fixed date in the tests. It most likely fails because today is the 30 september and tomorrow is not the 31 of september ;)

Or you can more simply use fields.Date.add(today, days=1) (thanks @sebalix for the tip)

The problem lies in the stock_location_orderpoint module. In particular line 99 of tests/test_location_orderpoint.py

stock-logistics-orderpoint/stock_location_orderpoint/tests/test_location_orderpoint.py

Line 99 in e387e1e

tomorrow = now.replace(day=now.day + 1)

This statement will always fail if we test on the last day of the month

PicchiSeba · 2024-10-01T08:25:43Z

@yvaucher we can merge this now. Later in the day I will fix the base module test

yvaucher · 2024-10-01T10:27:41Z

/ocabot merge nobump

OCA-git-bot · 2024-10-01T10:27:49Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-23-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot · 2024-10-01T10:32:13Z

Congratulations, your PR was merged at a471175. Thanks a lot for contributing to OCA. ❤️

JordiBForgeFlow and others added 23 commits August 26, 2024 10:34

stock_orderpoint_route

736c116

Migrate stock_orderpoint_route to 12.0

b2a90e6

Use SavepointCase in tests

5dbb93e

To avoid executing the setup for each test

stock_orderpoint_route: black, isort

2050752

stock_orderpoint_route: Migration to 13.0

9e6cd96

run pre-commit with new prettiers

e6503af

README.rst

32b9ca6

Eficent -> ForgeFlow

0489060

README.rst

7e3cd18

[UPD] Update stock_orderpoint_route.pot

stock_orderpoint_route: black, isort, prettier

db86f1e

stock_orderpoint_route: Migration to 14.0

6c82bc5

Update stock_orderpoint_route.pot

0f048d3

README.rst

9aa2171

stock_orderpoint_route 14.0.1.1.0

b496720

stock_orderpoint_route: avoid missing route_ids field issue (bis)

eb21765

Complete the fix done in 06dfeedc66

stock_orderpoint_route 14.0.1.1.1

8b64af4

README.rst

892b76c

Added translation using Weblate (Italian)

d51406c

Update stock_orderpoint_route.pot

b22549b

stock_orderpoint_route: Migration to 16.0

6688005

PicchiSeba force-pushed the 16.0-mig-stock_orderpoint_route branch from 59c57c6 to 6688005 Compare September 27, 2024 15:11

PicchiSeba marked this pull request as ready for review September 27, 2024 15:13

rousseldenis approved these changes Sep 27, 2024

View reviewed changes

OCA-git-bot added this to the 16.0 milestone Sep 27, 2024

yvaucher approved these changes Sep 30, 2024

View reviewed changes

OCA-git-bot added the approved label Sep 30, 2024

OCA-git-bot added a commit that referenced this pull request Sep 30, 2024

Merge PR #23 into 16.0

77c8739

Signed-off-by yvaucher

OCA-git-bot added the bot is merging ⏳ label Sep 30, 2024

OCA-git-bot removed the bot is merging ⏳ label Sep 30, 2024

OCA-git-bot added the bot is merging ⏳ label Oct 1, 2024

OCA-git-bot merged commit 26f9f3c into OCA:16.0 Oct 1, 2024
6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 1, 2024

PicchiSeba deleted the 16.0-mig-stock_orderpoint_route branch October 1, 2024 11:39

Uh oh!

[16.0][MIG]stock_orderpoint_route: migration to 16.0 #23

[16.0][MIG]stock_orderpoint_route: migration to 16.0 #23

Uh oh!

Conversation

PicchiSeba commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Sep 27, 2024

Uh oh!

OCA-git-bot commented Sep 27, 2024

Uh oh!

yvaucher left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yvaucher commented Sep 30, 2024

Uh oh!

OCA-git-bot commented Sep 30, 2024

Uh oh!

OCA-git-bot commented Sep 30, 2024

Uh oh!

yvaucher commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PicchiSeba commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PicchiSeba commented Oct 1, 2024

Uh oh!

yvaucher commented Oct 1, 2024

Uh oh!

OCA-git-bot commented Oct 1, 2024

Uh oh!

Uh oh!

OCA-git-bot commented Oct 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

[16.0][MIG]stock_orderpoint_route: migration to `16.0` #23

[16.0][MIG]stock_orderpoint_route: migration to `16.0` #23

PicchiSeba commented Sep 27, 2024 •

edited

Loading

yvaucher left a comment •

edited

Loading

yvaucher commented Sep 30, 2024 •

edited

Loading

PicchiSeba commented Oct 1, 2024 •

edited

Loading