Skip to content

[18.0][MIG] stock_orderpoint_no_horizon: Migration to 18.0 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2025
Merged

[18.0][MIG] stock_orderpoint_no_horizon: Migration to 18.0 #37

merged 4 commits into from
Aug 25, 2025

Conversation

@henrybackman
Copy link
Contributor

@henrybackman henrybackman commented May 27, 2025

No description provided.

@henrybackman henrybackman marked this pull request as ready for review June 2, 2025 06:08
@henrybackman henrybackman force-pushed the 18.0-mig-stock_orderpoint_no_horizon branch from de2ca29 to 102f260 Compare June 2, 2025 06:13
@henrybackman henrybackman mentioned this pull request Jun 2, 2025
Closed
@henrybackman
Copy link
Contributor Author

henrybackman commented Jun 2, 2025

The tests still don't pass on CI, but they work for me locally so not certain how to proceed with it

@henrybackman henrybackman force-pushed the 18.0-mig-stock_orderpoint_no_horizon branch from 102f260 to 42c6241 Compare June 2, 2025 06:24
@jbaudoux
Copy link
Contributor

jbaudoux commented Jun 19, 2025

@henrybackman install stock_orderpoint_purchase_link and test will fail. Can you investigate?

@henrybackman
Copy link
Contributor Author

henrybackman commented Jul 15, 2025

I looked into the tests and they fail when puchase_stock module is installed but it wasn't clear to me how this module should work with purchase_stock as it changes how the stock moves are generated

@jbaudoux jbaudoux force-pushed the 18.0-mig-stock_orderpoint_no_horizon branch from 767e637 to 5c12ece Compare August 6, 2025 08:31
@jbaudoux
Copy link
Contributor

jbaudoux commented Aug 6, 2025

@henrybackman I pushed a fix. I also removed the delay on the rule, otherwise it was inside the horizon

@simahawk
Copy link
Contributor

simahawk commented Aug 25, 2025

/ocabot migration stock_orderpoint_no_horizon

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 25, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 25, 2025
Open
7 tasks
@simahawk
Copy link
Contributor

simahawk commented Aug 25, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 25, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-37-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1666067 into OCA:18.0 Aug 25, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 25, 2025

Congratulations, your PR was merged at 239c3e9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@henrybackman @jbaudoux @simahawk @OCA-git-bot