[18.0][MIG] stock_orderpoint_mto_as_mts: Migration to v18.0 + IMP #39

jbaudoux · 2025-06-07T08:18:09Z

Depends on:

[18.0][MIG] stock_orderpoint_default_location: Migration to v18.0 #40

Tested

Improvements:

Improve performance on each product create/write
Fix changing a product category as the route is propagated to children categories
Allow to process lots of products linked to a product category change
Better manage multi-company

stock_orderpoint_mto_as_mts/models/stock_route.py

stock_orderpoint_mto_as_mts/tests/test_stock_warehouse_mto_as_mts.py

stock_orderpoint_mto_as_mts/models/product_category.py

ivantodorovich · 2025-06-09T12:16:32Z

stock_orderpoint_mto_as_mts/models/product_category.py

+        # Update orderpoints for MTO / not MTO products that are linked to
+        # these categories. A category is not bound to a company, search
+        # products accross all companies.
+        _logger.debug("Search products already as MTO")


What's the deal with all these debug comments?
Left-over from debugging session? or do we really want to keep them?

There can be really a lot of products under that category. Showing some progress in the debug log is convenient.

Hm yes, but there seems to be a lot of them. It's a bit messy, but maybe it's just me.

ivantodorovich · 2025-06-09T12:22:58Z

stock_orderpoint_mto_as_mts/models/product_product.py

+        if warehouses:
+            # Find all MTO products that changed to non MTO
+            _logger.debug("Search products not MTO anymore")
+            products_not_mto = original_mto_products.filtered_domain(


Same comment as before:

use filtered_domain only when you truly need it, otherwise prefer filtered for perf

if you can avoid it, especially when dealing with a potentially large number of records, filter them with search instead

filtered domain is making a search limited to the records subset. I have the feeling I'm doing what you suggest as second point?

filtered_domain is not doing a search, it's fetching all records data and filtering in python. Maybe that's the confusion?

oh indeed, I wrongly interpreted that method. I'm replacing by a search !

stock_orderpoint_mto_as_mts/models/product_product.py

ivantodorovich · 2025-06-09T12:32:53Z

stock_orderpoint_mto_as_mts/models/product_product.py

+            _logger.debug(f"Create orderpoint for MTO - chunck {i}")
+            ops = op_obj.create(op_vals_list_chunk)
+            # free memory usage
+            ops.invalidate_model()


Does it actually improve something?

AFAICS the only thing in the loop is op_obj.create(op_vals_list_chunk), and create is flushed immediately so there's nothing really cached.

You'd probably get better peformance not spliting at all, and letting the ORM created everything on a single query

IMO this pattern only makes sense when you're reading & writing on records:

Reading (specially with prefetching) can easily consume lots of RAM as you keep iterating on records

Writing (without flushing) can also do the same, on a much smaller scale

What I measured is that increasing the chunk size is not making it faster

My suggestion is actually to just don't split in chunks, and my point is that splitting and processing in chunks here seems pointless

the benefit it too see it's progressing in the logs :/

invalidate_model may still be useful is there are computed fields that are triggered after create, isn't it?

Yeah, but, I mean.. KISS
Anyway, not blocking over this

stock_orderpoint_mto_as_mts/models/product_template.py

stock_orderpoint_mto_as_mts/models/product_product.py

jbaudoux · 2025-06-10T12:10:56Z

@ivantodorovich Thanks a lot for your review. I tried to improve the code. Can you drop another review before I squash the fixup commits ?

ivantodorovich · 2025-06-10T18:15:23Z

stock_orderpoint_mto_as_mts/models/product_product.py

+            _logger.debug(f"Create orderpoint for MTO - chunck {i}")
+            ops = op_obj.create(op_vals_list_chunk)
+            # free memory usage
+            ops.invalidate_model()


Yeah, but, I mean.. KISS
Anyway, not blocking over this

stock_orderpoint_mto_as_mts/models/product_category.py

ivantodorovich · 2025-06-10T18:20:55Z

stock_orderpoint_mto_as_mts/models/product_product.py

+        if warehouses:
+            # Find all MTO products that changed to non MTO
+            _logger.debug("Search products not MTO anymore")
+            products_not_mto = original_mto_products.filtered_domain(


filtered_domain is not doing a search, it's fetching all records data and filtering in python. Maybe that's the confusion?

…as_mts_orderpoint

Currently translated at 100.0% (8 of 8 strings) Translation: stock-logistics-orderpoint-16.0/stock-logistics-orderpoint-16.0-stock_orderpoint_mto_as_mts Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-orderpoint-16-0/stock-logistics-orderpoint-16-0-stock_orderpoint_mto_as_mts/it/

Currently translated at 87.5% (7 of 8 strings) Translation: stock-logistics-orderpoint-16.0/stock-logistics-orderpoint-16.0-stock_orderpoint_mto_as_mts Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-orderpoint-16-0/stock-logistics-orderpoint-16-0-stock_orderpoint_mto_as_mts/fr/

Currently translated at 100.0% (8 of 8 strings) Translation: stock-logistics-orderpoint-16.0/stock-logistics-orderpoint-16.0-stock_orderpoint_mto_as_mts Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-orderpoint-16-0/stock-logistics-orderpoint-16-0-stock_orderpoint_mto_as_mts/tr/

sebalix · 2025-06-11T13:20:14Z

/ocabot migration stock_orderpoint_mto_as_mts

Improve performace on each product create/write Fix the route on the category as it is propagated to children categories

jbaudoux · 2025-06-11T13:48:28Z

I removed the wrong .pot file

jbaudoux · 2025-06-11T14:05:14Z

/ocabot merge nobump

OCA-git-bot · 2025-06-11T14:05:21Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-39-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot · 2025-06-11T14:10:23Z

Congratulations, your PR was merged at 2c5bbbd. Thanks a lot for contributing to OCA. ❤️

jbaudoux force-pushed the 18-mig-stock_orderpoint_mto_as_mts branch 2 times, most recently from e2f0413 to cc5c911 Compare June 7, 2025 08:43

jbaudoux marked this pull request as ready for review June 7, 2025 08:46

jbaudoux force-pushed the 18-mig-stock_orderpoint_mto_as_mts branch 4 times, most recently from d65e46f to 02b58a9 Compare June 7, 2025 18:35

jbaudoux changed the title ~~[18.0][MIG] stock_orderpoint_mto_as_mts: Migration to v18.0~~ [18.0][MIG] stock_orderpoint_mto_as_mts: Migration to v18.0 + IMP Jun 7, 2025

simahawk requested changes Jun 9, 2025

View reviewed changes

stock_orderpoint_mto_as_mts/models/stock_route.py Outdated Show resolved Hide resolved

ivantodorovich reviewed Jun 9, 2025

View reviewed changes

jbaudoux commented Jun 9, 2025

View reviewed changes

stock_orderpoint_mto_as_mts/models/product_product.py Outdated Show resolved Hide resolved

ivantodorovich approved these changes Jun 10, 2025

View reviewed changes

simahawk self-requested a review June 11, 2025 08:37

tuantrantg and others added 10 commits June 11, 2025 11:23

[REF] stock_orderpoint_mto_as_mts: Rename module from sale_stock_mto_…

18931bd

…as_mts_orderpoint

[IMP] stock_orderpoint_mto_as_mts

4a08e8c

[UPD] Update stock_orderpoint_mto_as_mts.pot

704fa5d

[BOT] post-merge updates

5da7b63

Added translation using Weblate (French)

389e938

Added translation using Weblate (Turkish)

73e4265

[IMP] stock_orderpoint_mto_as_mts: pre-commit auto fixes

98afbcc

jbaudoux force-pushed the 18-mig-stock_orderpoint_mto_as_mts branch 4 times, most recently from 8f3f260 to da2b4fd Compare June 11, 2025 09:47

OCA-git-bot added this to the 18.0 milestone Jun 11, 2025

OCA-git-bot mentioned this pull request Jun 11, 2025

Migration to version 18.0 #25

Open

7 tasks

sebalix added the migration label Jun 11, 2025

sebalix approved these changes Jun 11, 2025

View reviewed changes

jbaudoux added 2 commits June 11, 2025 15:47

[MIG] stock_orderpoint_mto_as_mts: Migration to 18.0

77a9781

[IMP] stock_orderpoint_mto_as_mts: perf & categ

6a98ae6

Improve performace on each product create/write Fix the route on the category as it is propagated to children categories

jbaudoux force-pushed the 18-mig-stock_orderpoint_mto_as_mts branch from da2b4fd to 6a98ae6 Compare June 11, 2025 13:47

OCA-git-bot added the bot is merging ⏳ label Jun 11, 2025

OCA-git-bot merged commit c42f992 into OCA:18.0 Jun 11, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 11, 2025

Uh oh!

[18.0][MIG] stock_orderpoint_mto_as_mts: Migration to v18.0 + IMP #39

[18.0][MIG] stock_orderpoint_mto_as_mts: Migration to v18.0 + IMP #39

Uh oh!

Conversation

jbaudoux commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jbaudoux commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebalix commented Jun 11, 2025

Uh oh!

jbaudoux commented Jun 11, 2025

Uh oh!

jbaudoux commented Jun 11, 2025

Uh oh!

OCA-git-bot commented Jun 11, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Jun 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

jbaudoux commented Jun 7, 2025 •

edited

Loading

ivantodorovich Jun 9, 2025 •

edited

Loading

jbaudoux commented Jun 10, 2025 •

edited

Loading