[FIX] stock_valuation_fifo_lot

AungKoKoLin1997 · AungKoKoLin1997 · commit 07a5f6358538 · 2024-08-22T06:57:39.000Z
This commit fixes the incorrect stock_valuation_layer values for deliveries when the product was received before this module was installed. The issue occurs because the old stock_valuation_layer records do not have lot_ids values, which leads to incorrect valuation during the delivery process. Issue link: #1350 (comment)
diff --git a/stock_valuation_fifo_lot/models/product.py b/stock_valuation_fifo_lot/models/product.py
@@ -44,8 +44,11 @@ def _run_fifo(self, quantity, company):
             qty_to_take_on_candidates = move_line.product_uom_id._compute_quantity(
                 move_line.qty_done, move.product_id.uom_id
             )
+            # Find incoming stock valuation layers that have lot_ids on their moves
+            # Check with stock_move_id.lot_ids to cover the situation where the stock
+            # was received either before or after the installation of this module
             candidates = self._get_fifo_candidates(company).filtered(
-                lambda l: move_line.lot_id in l.lot_ids
+                lambda l: move_line.lot_id in l.stock_move_id.lot_ids
             )
             for candidate in candidates:
                 qty_taken_on_candidate = min(

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,11 @@ def _run_fifo(self, quantity, company):`
`44`	`44`	`qty_to_take_on_candidates = move_line.product_uom_id._compute_quantity(`
`45`	`45`	`move_line.qty_done, move.product_id.uom_id`
`46`	`46`	`)`
	`47`	`+ # Find incoming stock valuation layers that have lot_ids on their moves`
	`48`	`+ # Check with stock_move_id.lot_ids to cover the situation where the stock`
	`49`	`+ # was received either before or after the installation of this module`
`47`	`50`	`candidates = self._get_fifo_candidates(company).filtered(`
`48`		`- lambda l: move_line.lot_id in l.lot_ids`
	`51`	`+ lambda l: move_line.lot_id in l.stock_move_id.lot_ids`
`49`	`52`	`)`
`50`	`53`	`for candidate in candidates:`
`51`	`54`	`qty_taken_on_candidate = min(`