[MIG] stock_picking_auto_create_package: migration to 18.0

Author: JordiMForgeFlow

stock_picking_auto_create_package/__manifest__.py

@@ -6,7 +6,7 @@
     "name": "Stock Picking Auto Create Package",
     "summary": """
         Put all move lines in packs on validation.""",
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "BCIM,MT Software,Raumschmiede,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/stock-logistics-workflow",

stock_picking_auto_create_package/models/stock_picking.py

@@ -4,6 +4,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 from odoo import api, models
+from odoo.tools import float_compare, float_round
 
 
 class StockPicking(models.Model):
@@ -24,31 +25,63 @@ def _auto_create_delivery_package_filter(self, move_lines):
         return move_lines.filtered(
             lambda ml: not ml.result_package_id
             and ml.state not in ("cancel", "done")
-            and ml.qty_done
+            and ml.quantity
         )
 
+    def _split_move_line_package_qty(self, ml, package_qty):
+        """
+        Split move line if the package quantity is less than the move line
+        quantity.
+        """
+        if (
+            float_compare(
+                package_qty, ml.quantity, precision_rounding=ml.product_uom_id.rounding
+            )
+            >= 0
+        ):
+            return False
+        quantity_left_todo = float_round(
+            ml.quantity - package_qty,
+            precision_rounding=ml.product_uom_id.rounding,
+            rounding_method="HALF-UP",
+        )
+        new_move_line = ml.copy(default={"quantity": quantity_left_todo})
+        vals = {}
+        if self.picking_type_id.code == "incoming":
+            if ml.lot_id:
+                vals["lot_id"] = False
+            if ml.lot_name:
+                vals["lot_name"] = False
+        new_move_line.write(vals)
+        return new_move_line
+
     def _auto_create_delivery_package_per_smallest_packaging(self) -> None:
         """
         Put each done smallest product packaging in a package
         """
         for picking in self:
-            for move_line in picking.move_line_ids:
+            picking_move_lines = picking.move_line_ids
+            for move_line in picking_move_lines:
                 move_line = self._auto_create_delivery_package_filter(move_line)
                 if not move_line:
                     continue
-                qty_to_pack = move_line.qty_done
+                qty_to_pack = move_line.quantity
                 max_pack_qty = 1
                 packagings = move_line.product_id.packaging_ids.filtered(
                     lambda pack: pack.qty > 0
                 )
                 if packagings:
                     smallest_packaging = packagings.sorted("qty")[0]
                     max_pack_qty = smallest_packaging.qty
-                while qty_to_pack:
+                current_line = move_line
+                new_line = None
+                while qty_to_pack and current_line:
                     pack_qty = min(qty_to_pack, max_pack_qty)
+                    new_line = self._split_move_line_package_qty(current_line, pack_qty)
                     qty_to_pack -= pack_qty
-                    move_line.qty_done = pack_qty
-                    move_line.picking_id._put_in_pack(move_line)
+                    current_line.quantity = pack_qty
+                    current_line.picking_id._put_in_pack(current_line)
+                    current_line = new_line
 
     def _auto_create_delivery_package_single(self) -> None:
         """

stock_picking_auto_create_package/tests/test_automatic_package.py

@@ -2,18 +2,19 @@
 # Copyright 2023 ACSONE SA/NV
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo.tests import TransactionCase
+from odoo.addons.base.tests.common import BaseCommon
 
 
-class TestAutomaticPackage(TransactionCase):
+class TestAutomaticPackage(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
         cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.product = cls.env["product.product"].create(
             {
                 "name": "Product Test",
-                "type": "product",
+                "type": "consu",
+                "is_storable": True,
             }
         )
         cls.product_packaging = cls.env["product.packaging"].create(
@@ -37,7 +38,7 @@ def setUpClass(cls):
             10,
         )
         cls.picking = cls._create_picking()
-        cls.picking.move_ids.update({"quantity_done": 5.0})
+        cls.picking.move_ids.update({"quantity": 5.0})
 
     @classmethod
     def _create_picking(cls):