[MIG] stock_picking_batch_extended: finish migration to 18.0

Author: celm1990

stock_picking_batch_extended/README.rst

@@ -7,7 +7,7 @@ Stock batch picking extended
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:2a60deeaeb86880a5da8255ca2d35888776a39724817647f7406defa489f28ab
+   !! source digest: sha256:145e388b3d5a20965b2351bf7d4edf791aae2d90869e15803c0b995739910cdc
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Mature-brightgreen.png
@@ -46,17 +46,17 @@ deactivate which approach for batch handling will be used per company.
 By default after installation this option will be activated for all
 companies.
 
-|image1|
+|settings|
 
-.. |image1| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/picking_batch_configuration_settings.png
+.. |settings| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/picking_batch_configuration_settings.png
 
 Usage
 =====
 
 When you create a batch pick, the creation wizard will appear with the
 new fields added.
 
-|image1|
+|wizard|
 
 1. Name: Allows to rename the batch. But be careful, if this is done, it
    overwrites the name that Odoo assigns to the batch by default.
@@ -68,7 +68,7 @@ Adds to the form view of batch picking:
 
 **In "Draft" status:**
 
-|image2|
+|draft|
 
 1. Delete all delivery notes in the batch whose status is not done or
    canceled.
@@ -84,7 +84,7 @@ Adds to the form view of batch picking:
 
 **"In progress" status:**
 
-|image3|
+|in_progress|
 
 1. Delete all pickings in the batch whose status is not done or
    cancelled.
@@ -102,7 +102,7 @@ validation approach in the inventory settings.
 
 **In "Done" status:**
 
-|image4|
+|done|
 
 1. Print pickings.
 2. Smart button with counting and access to pickings.
@@ -111,10 +111,10 @@ validation approach in the inventory settings.
 4. Notes. Reflects the notes that have been entered from the wizard and
    allows you to modify them.
 
-.. |image1| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/batch_wizard.png
-.. |image2| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/batch_form_draft.png
-.. |image3| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/batch_form_in_progress.png
-.. |image4| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/batch_form_done.png
+.. |wizard| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/batch_wizard.png
+.. |draft| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/batch_form_draft.png
+.. |in_progress| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/batch_form_in_progress.png
+.. |done| image:: https://raw.githubusercontent.com/OCA/stock-logistics-workflow/18.0/stock_picking_batch_extended/static/batch_form_done.png
 
 Bug Tracker
 ===========
@@ -164,6 +164,7 @@ Contributors
   - Carlos Dauden
   - Sergio Teruel
   - César A. Sánchez
+  - Carlos Lopez
 
 - `Trobz <https://trobz.com>`__:
 

stock_picking_batch_extended/models/stock_batch_picking.py

@@ -10,13 +10,9 @@ class StockPickingBatch(models.Model):
 
     _inherit = "stock.picking.batch"
 
-    name = fields.Char(
-        index=True,
-        readonly=False,  # allow edition in draft state
-    )
+    name = fields.Char(index=True)
     date = fields.Date(
         required=True,
-        readonly=False,  # allow edition in draft,in_progress state
         index=True,
         default=fields.Date.context_today,
         help="date on which the batch picking is to be processed",
@@ -42,14 +38,13 @@ class StockPickingBatch(models.Model):
 
     def _compute_picking_count(self):
         """Calculate number of pickings."""
-        groups = self.env["stock.picking"].read_group(
-            domain=[("batch_id", "in", self.ids)],
-            fields=["batch_id"],
-            groupby=["batch_id"],
+        counts = dict(
+            self.env["stock.picking"]._read_group(
+                [("batch_id", "in", self.ids)], ["batch_id"], ["__count"]
+            )
         )
-        counts = {g["batch_id"][0]: g["batch_id_count"] for g in groups}
         for batch in self:
-            batch.picking_count = counts.get(batch.id, 0)
+            batch.picking_count = counts.get(batch, 0)
 
     def action_cancel(self):
         """Call action_cancel for all batches pickings
@@ -91,7 +86,7 @@ def action_picking_move_tree(self):
         action["views"] = [
             (
                 self.env.ref("stock_picking_batch.view_picking_move_tree_inherited").id,
-                "tree",
+                "list",
             ),
         ]
         return action
@@ -103,7 +98,7 @@ def action_picking_move_line_tree(self):
         action["views"] = [
             (
                 self.env.ref("stock_picking_batch_extended.view_move_line_tree").id,
-                "tree",
+                "list",
             ),
         ]
         ctx = self.env.context.copy()

stock_picking_batch_extended/models/stock_move.py

@@ -10,4 +10,5 @@ class StockMove(models.Model):
         comodel_name="stock.picking.batch",
         related="picking_id.batch_id",
         store=True,
+        index=True,
     )

stock_picking_batch_extended/models/stock_move_line.py

@@ -6,8 +6,8 @@
 class StockMoveLine(models.Model):
     _inherit = "stock.move.line"
 
-    def _add_to_wave(self, wave=False):
-        super()._add_to_wave(wave)
+    def _add_to_wave(self, wave=False, description=False):
+        super()._add_to_wave(wave, description)
         return self.env["stock.picking.to.batch"].action_view_batch_picking(
             self.batch_id
         )

stock_picking_batch_extended/readme/CONFIGURE.md

@@ -3,4 +3,4 @@ deactivate which approach for batch handling will be used per company.
 By default after installation this option will be activated for all
 companies.
 
-![](../static/picking_batch_configuration_settings.png)
+![settings](../static/picking_batch_configuration_settings.png)

stock_picking_batch_extended/readme/CONTRIBUTORS.md

@@ -24,6 +24,7 @@
   - Carlos Dauden
   - Sergio Teruel
   - César A. Sánchez
+  - Carlos Lopez
 
 - [Trobz](https://trobz.com):
 

stock_picking_batch_extended/readme/USAGE.md

@@ -1,7 +1,7 @@
 When you create a batch pick, the creation wizard will appear with the
 new fields added.
 
-![](../static/batch_wizard.png)
+![wizard](../static/batch_wizard.png)
 
 1.  Name: Allows to rename the batch. But be careful, if this is done,
     it overwrites the name that Odoo assigns to the batch by default.
@@ -13,7 +13,7 @@ Adds to the form view of batch picking:
 
 **In "Draft" status:**
 
-![](../static/batch_form_draft.png)
+![draft](../static/batch_form_draft.png)
 
 1.  Delete all delivery notes in the batch whose status is not done or
     canceled.
@@ -29,7 +29,7 @@ Adds to the form view of batch picking:
 
 **"In progress" status:**
 
-![](../static/batch_form_in_progress.png)
+![in_progress](../static/batch_form_in_progress.png)
 
 1.  Delete all pickings in the batch whose status is not done or
     cancelled.
@@ -47,7 +47,7 @@ validation approach in the inventory settings.
 
 **In "Done" status:**
 
-![](../static/batch_form_done.png)
+![done](../static/batch_form_done.png)
 
 1.  Print pickings.
 2.  Smart button with counting and access to pickings.

stock_picking_batch_extended/report/batch_report.py

@@ -1,11 +1,7 @@
 # Copyright 2018 Tecnativa - Carlos Dauden
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-import logging
 
 from odoo import api, fields, models
-from odoo.tools.float_utils import float_is_zero
-
-_logger = logging.getLogger(__name__)
 
 
 class ReportPrintBatchPicking(models.AbstractModel):
@@ -22,8 +18,8 @@ def key_level_1(self, operation):
 
     @api.model
     def new_level_0(self, operation):
-        location_name = operation.location_id.name_get()[0][1]
-        location_dest_name = operation.location_dest_id.name_get()[0][1]
+        location_name = operation.location_id.display_name
+        location_dest_name = operation.location_dest_id.display_name
         level_0_name = f"{location_name} \u21e8 {location_dest_name}"
         return {
             "name": level_0_name,
@@ -32,28 +28,17 @@ def new_level_0(self, operation):
             "l1_items": {},
         }
 
-    @api.model
-    def _get_operation_qty(self, operation):
-        return (
-            float_is_zero(
-                operation.reserved_qty,
-                precision_rounding=operation.product_uom_id.rounding,
-            )
-            and operation.qty_done
-            or operation.reserved_qty
-        )
-
     @api.model
     def new_level_1(self, operation):
         return {
             "product": operation.product_id,
-            "product_qty": self._get_operation_qty(operation),
+            "product_qty": operation.quantity,
             "operations": operation,
         }
 
     @api.model
     def update_level_1(self, group_dict, operation):
-        group_dict["product_qty"] += self._get_operation_qty(operation)
+        group_dict["product_qty"] += operation.quantity
         group_dict["operations"] += operation
 
     @api.model