[MIG] stock_move_line_expiration_date_required: Migration to 18.0

Author: Andrii9090

stock_move_line_expiration_date_required/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Stock Move Line Expiration Date Required",
     "Summary": "Expiration date is required to enter manually on Move Lines.",
-    "version": "16.0.1.0.2",
+    "version": "18.0.1.0.0",
     "author": "Moduon, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/stock-logistics-workflow",
     "category": "Warehouse Management",

stock_move_line_expiration_date_required/models/stock_move.py

@@ -17,7 +17,7 @@ def _compute_all_expiry_dates_set(self):
         """Check if all move lines have an expiration date set."""
         for record in self:
             record.all_expiry_dates_set = not record.use_expiration_date or all(
-                record.move_line_ids.filtered("qty_done").mapped("expiration_date")
+                record.move_line_ids.filtered("quantity").mapped("expiration_date")
             )
 
     def _generate_serial_move_line_commands(self, lot_names, origin_move_line=None):

stock_move_line_expiration_date_required/models/stock_picking.py

@@ -15,7 +15,7 @@ def _sanity_check(self, separate_pickings=True):
             move_lines = self.env["stock.move.line"].browse()
             for move in picking.move_ids:
                 # For assigned moves
-                move_lines |= move._get_move_lines()
+                move_lines |= move.move_line_ids
             move_lines_wo_expiration_date = move_lines.filtered_domain(
                 [
                     ("use_expiration_date", "=", True),

stock_move_line_expiration_date_required/tests/test_expiration_date_required.py

@@ -15,7 +15,7 @@ def setUpClass(cls):
         cls.product = cls.env["product.product"].create(
             {
                 "name": "Test Expiration Product",
-                "type": "product",
+                "type": "consu",
                 "use_expiration_date": True,
                 "expiration_time": 0,
                 "tracking": "lot",
@@ -39,11 +39,11 @@ def test_expiration_date_required_and_not_auto_calculated(self):
             view="stock.view_stock_move_operations",
         )
         with self.assertRaisesRegex(
-            AssertionError, "expiration_date is a required field"
+            AssertionError, "'expiration_date' is a required field"
         ):
-            with move_form.move_line_ids.new() as move_line_tree:
+            with move_form.move_line_ids.edit(0) as move_line_tree:
                 move_line_tree.lot_name = "TLE1"
-                move_line_tree.qty_done = 1
+                move_line_tree.quantity = 1
                 self.assertEqual(move_line_tree.expiration_date, False)
 
     def test_expiration_date_auto_caulculated(self):
@@ -55,9 +55,9 @@ def test_expiration_date_auto_caulculated(self):
             self.picking.move_ids_without_package,
             view="stock.view_stock_move_operations",
         )
-        with move_form.move_line_ids.new() as move_line_tree:
+        with move_form.move_line_ids.edit(0) as move_line_tree:
             move_line_tree.lot_name = "TLE2"
-            move_line_tree.qty_done = 1
+            move_line_tree.quantity = 1
             self.assertNotEqual(move_line_tree.expiration_date, False)
         move_form.save()
 
@@ -76,9 +76,8 @@ def test_expiration_date_generate_serials(self):
         picking.action_confirm()
         # Prepare serial generation
         move = picking.move_ids_without_package
-        move.next_serial = "001"
         move.next_serial_count = move.product_uom_qty
-        picking.move_ids_without_package._generate_serial_numbers()
+        picking.move_ids_without_package._generate_serial_numbers("001")
         # Check expiration date is empty
         for move_line in picking.move_line_ids:
             self.assertEqual(move_line.expiration_date, False)
@@ -95,9 +94,9 @@ def test_lot_no_expiration_date(self):
             self.picking.move_ids_without_package,
             view="stock.view_stock_move_operations",
         )
-        with move_form.move_line_ids.new() as move_line_tree:
+        with move_form.move_line_ids.edit(0) as move_line_tree:
             move_line_tree.lot_name = "TLE3"
-            move_line_tree.qty_done = 10
+            move_line_tree.quantity = 10
         move_form.save()
         self.picking.with_context(skip_sanity_check=False).button_validate()
 
@@ -116,7 +115,6 @@ def test_serials_no_expiration_date(self):
         picking.action_confirm()
         # Prepare serial generation
         move = picking.move_ids_without_package
-        move.next_serial = "001"
         move.next_serial_count = move.product_uom_qty
-        picking.move_ids_without_package._generate_serial_numbers()
+        picking.move_ids_without_package._generate_serial_numbers("001")
         picking.with_context(skip_sanity_check=False).button_validate()

stock_move_line_expiration_date_required/views/stock_move_line_view.xml

@@ -9,11 +9,15 @@
         />
         <field name="arch" type="xml">
             <xpath expr="//field[@name='expiration_date']" position="attributes">
-                <attribute name="attrs">{
-                    'column_invisible': ['|', ('parent.use_expiration_date', '!=', True), ('parent.picking_code', '!=', 'incoming')],
-                    'readonly': [('picking_type_use_existing_lots', '=', True)],
-                    'required': [('parent.use_expiration_date', '=', True), ('parent.picking_code', '=', 'incoming')]
-                }</attribute>
+                <attribute name="column_invisible">
+                    not parent.use_expiration_date or parent.picking_code != 'incoming'
+                </attribute>
+                <attribute name="readonly">
+                    picking_type_use_existing_lots
+                </attribute>
+                <attribute name="required">
+                   parent.use_expiration_date and parent.picking_code == 'incoming'
+                </attribute>
             </xpath>
         </field>
     </record>

stock_move_line_expiration_date_required/views/stock_move_view.xml

@@ -1,16 +1,16 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <record id="view_stock_move_nosuggest_operations" model="ir.ui.view">
-        <field name="name">stock.move.operations.nosuggest.form</field>
+    <record id="view_stock_move_operations" model="ir.ui.view">
+        <field name="name">stock.move.form</field>
         <field name="model">stock.move</field>
-        <field name="inherit_id" ref="stock.view_stock_move_nosuggest_operations" />
+        <field name="inherit_id" ref="stock.view_stock_move_operations" />
         <field name="arch" type="xml">
             <xpath expr="//form/*[1]" position="before">
                 <field name="all_expiry_dates_set" invisible="1" />
                 <div
                     class="alert alert-warning"
                     role="alert"
-                    attrs="{'invisible': [('all_expiry_dates_set', '=', True)]}"
+                    invisible="all_expiry_dates_set"
                 >
                     You won't be able to confirm the parent picking until all Expiry dates are set
                 </div>