[IMP] stock_picking_operation_loss_quantity: cancel loss reservation on inventory

 When an inventory is validated, we need to cancel any remaining pending moves created to make the quantity no more available in case of loss declaration.

Author: lmignon

stock_picking_operation_loss_quantity/models/stock_move_line.py

@@ -106,9 +106,11 @@ def _prepare_values_for_loss_movement(self, group_key):
             "reserved_uom_qty": loss_quantity,
             "product_id": group_key.product_id.id,
             "picking_type_id": pick_type_id.id,
+            "package_id": group_key.package_id.id,
             "location_id": group_key.location_id.id,
             "location_dest_id": pick_type_id.default_location_dest_id.id,
             "lot_id": group_key.lot_id.id,
+            "owner_id": group_key.owner_id.id,
             "origin": "Operator: %s / Pickings: %s"
             % (
                 self.env.user.name,

stock_picking_operation_loss_quantity/models/stock_quant.py

@@ -20,3 +20,33 @@ def _lock_quants_for_loss(self):
             "SELECT id FROM stock_quant WHERE id in %s FOR UPDATE NOWAIT",
             (tuple(self.ids),),
         )
+
+    def _apply_inventory(self):
+        """When an inventory is validated, we need to cancel any remaining
+        pending moves created to make the quantity no more available
+        in case of loss declaration.
+        """
+        moves_to_cancel = self.env["stock.move"]
+        if self.env.context.get("inventory_mode"):
+            for quant in self:
+                loss_picking_type = quant.warehouse_id.loss_type_id
+                search_domain = [
+                    ("reserved_uom_qty", ">", 0.0),
+                    ("product_id", "=", quant.product_id.id),
+                    ("package_id", "=", quant.package_id.id),
+                    ("location_id", "=", quant.location_id.id),
+                    ("picking_type_id", "=", loss_picking_type.id),
+                    (
+                        "location_dest_id",
+                        "=",
+                        loss_picking_type.default_location_dest_id.id,
+                    ),
+                    ("lot_id", "=", quant.lot_id.id),
+                    ("owner_id", "=", quant.owner_id.id),
+                ]
+                lines = self.env["stock.move.line"].search(search_domain)
+                if lines:
+                    moves_to_cancel |= lines.mapped("move_id")
+            if moves_to_cancel:
+                moves_to_cancel._action_cancel()
+        return super(StockQuant, self)._apply_inventory()

stock_picking_operation_loss_quantity/tests/common.py

@@ -151,13 +151,16 @@ def initiate_values_no_tracking(cls):
         cls._create_quantities(cls.product_3, 5.0)
 
     @classmethod
-    def _create_quantities(cls, product, quantity, location=None, lot=None):
+    def _create_quantities(
+        cls, product, quantity, location=None, lot=None, package=None
+    ):
         cls.quant_obj.with_context(inventory_mode=True).create(
             {
                 "product_id": product.id,
                 "inventory_quantity": quantity,
                 "location_id": location.id if location else cls.location.id,
                 "lot_id": lot.id if lot else False,
+                "package_id": package.id if package else False,
             }
         )._apply_inventory()
 

stock_picking_operation_loss_quantity/tests/test_picking_operation_loss.py

@@ -96,6 +96,17 @@ def test_loss_line_no_tracking(self):
         self.assertTrue(loss_pickings.activity_ids)
         self.assertEqual(self.user_demo, loss_pickings.activity_user_id)
 
+        # make an inventory adjustment and check that the loss picking is now
+        # cancelled
+        self._create_quantities(
+            new_line_2.product_id,
+            new_line_2.reserved_uom_qty,
+            location=new_line_2.location_id,
+            lot=new_line_2.lot_id,
+            package=new_line_2.package_id,
+        )
+        self.assertEqual(loss_pickings.state, "cancel")
+
     def test_loss_line_no_tracking_multi(self):
         """
         Product 2: 1.0 quantity done (demand 6.0)

stock_picking_operation_loss_quantity/tests/test_picking_operation_loss_tracking.py

@@ -37,17 +37,27 @@ def test_loss_line_tracking(self):
         loss_pickings = self._get_loss_pickings()
 
         self.assertEqual(1, len(loss_pickings))
-        line = loss_pickings.move_line_ids.filtered(
+        loss_line_lot_a = loss_pickings.move_line_ids.filtered(
             lambda line: line.lot_id == self.product_1_lotA
         )
-        self.assertTrue(line)
-        self.assertEqual(line.state, "assigned")
-        self.assertEqual(line.reserved_uom_qty, 2)
+        self.assertTrue(loss_line_lot_a)
+        self.assertEqual(loss_line_lot_a.state, "assigned")
+        self.assertEqual(loss_line_lot_a.reserved_uom_qty, 2)
 
-        line = loss_pickings.move_line_ids.filtered(
+        loss_line_lot_b = loss_pickings.move_line_ids.filtered(
             lambda line: line.lot_id == self.product_1_lotB
         )
-        self.assertFalse(line)
+        self.assertFalse(loss_line_lot_b)
+        # make an inventory adjustment and check that the loss picking is now
+        # cancelled
+        self._create_quantities(
+            loss_line_lot_a.product_id,
+            loss_line_lot_a.reserved_uom_qty,
+            location=loss_line_lot_a.location_id,
+            lot=loss_line_lot_a.lot_id,
+            package=loss_line_lot_a.package_id,
+        )
+        self.assertEqual(loss_pickings.state, "cancel")
 
     def test_loss_line_tracking_with_pack(self):
         """
@@ -95,14 +105,25 @@ def test_loss_line_tracking_with_pack(self):
         loss_pickings = self._get_loss_pickings()
 
         self.assertEqual(1, len(loss_pickings))
-        line = loss_pickings.move_line_ids.filtered(
+        loss_line_lot_a = loss_pickings.move_line_ids.filtered(
             lambda line: line.lot_id == self.product_1_lotA
         )
-        self.assertTrue(line)
-        self.assertEqual(line.state, "assigned")
-        self.assertEqual(line.reserved_uom_qty, 2)
+        self.assertTrue(loss_line_lot_a)
+        self.assertEqual(loss_line_lot_a.state, "assigned")
+        self.assertEqual(loss_line_lot_a.reserved_uom_qty, 2)
 
         line = loss_pickings.move_line_ids.filtered(
             lambda line: line.lot_id == self.product_1_lotB
         )
         self.assertFalse(line)
+
+        # make an inventory adjustment and check that the loss picking is now
+        # cancelled
+        self._create_quantities(
+            loss_line_lot_a.product_id,
+            loss_line_lot_a.reserved_uom_qty,
+            location=loss_line_lot_a.location_id,
+            lot=loss_line_lot_a.lot_id,
+            package=loss_line_lot_a.package_id,
+        )
+        self.assertEqual(loss_pickings.state, "cancel")