[MIG] stock_move_line_auto_fill: Migration to 17.0

Author: arantxa-s73

stock_move_line_auto_fill/models/stock_move.py

@@ -26,9 +26,9 @@ def _prepare_move_line_vals(self, quantity=None, reserved_quant=None):
             return res
         if self._get_avoid_lot_assignment_flag() and res.get("lot_id"):
             return res
-        if self.quantity_done != self.product_uom_qty:
+        if self.quantity != self.product_uom_qty:
             # Not assign qty_done for extra moves in over processed quantities
-            res.update({"qty_done": res.get("reserved_uom_qty", 0.0)})
+            res.update({"quantity": res.get("reserved_uom_qty", 0.0)})
         return res
 
     def _action_assign(self, force_qty=False):
@@ -45,10 +45,8 @@ def _action_assign(self, force_qty=False):
         ):
             if line._should_bypass_reservation() or not line._get_auto_fill_flag():
                 return res
-            lines_to_update = line.move_line_ids.filtered(
-                lambda li: li.qty_done != li.reserved_uom_qty
-            )
+            lines_to_update = line.move_line_ids.filtered(lambda li: not li.picked)
             for move_line in lines_to_update:
                 if not line._get_avoid_lot_assignment_flag() or not move_line.lot_id:
-                    move_line.qty_done = move_line.reserved_uom_qty
+                    move_line.picked = True
         return res

stock_move_line_auto_fill/models/stock_picking.py

@@ -51,12 +51,12 @@ def action_pack_operation_auto_fill(self):
         operations_to_auto_fill = operations.filtered(
             lambda op: (
                 op.product_id
-                and not op.qty_done
+                and not op.picked
                 and (
                     not op.lots_visible
                     or not op.picking_id.picking_type_id.avoid_lot_assignment
                 )
             )
         )
         for op in operations_to_auto_fill:
-            op.qty_done = op.reserved_uom_qty
+            op.picked = True

stock_move_line_auto_fill/tests/test_stock_picking_auto_fill.py

@@ -1,12 +1,15 @@
 # Copyright 2017 ACSONE SA/NV
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
+import odoo
 from odoo.exceptions import UserError
-from odoo.tests import Form, common
+from odoo.tests import Form
 
+from odoo.addons.base.tests.common import BaseCommon
 
-@common.tagged("-at_install", "post_install")
-class TestStockPicking(common.TransactionCase):
+
+@odoo.tests.tagged("-at_install", "post_install")
+class TestStockPicking(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
@@ -250,11 +253,11 @@ def test_action_pack_operation_auto_fill(self):
         # The expected result is only operations with product_id set and
         # the product_id.tracking == none, have a qty_done set.
         self.picking.action_pack_operation_auto_fill()
-        self.assertFalse(product_8_op.qty_done)
-        self.assertEqual(product_9_op.reserved_uom_qty, product_9_op.qty_done)
-        self.assertFalse(product_10_op.qty_done)
-        self.assertEqual(product_11_op.reserved_uom_qty, product_11_op.qty_done)
-        self.assertEqual(product_12_op.reserved_uom_qty, product_12_op.qty_done)
+        self.assertFalse(product_8_op.picked)
+        self.assertTrue(product_9_op.picked)
+        self.assertFalse(product_10_op.picked)
+        self.assertTrue(product_11_op.picked)
+        self.assertTrue(product_12_op.picked)
 
     def test_action_auto_transfer(self):
         # set tracking on the products
@@ -306,8 +309,8 @@ def test_action_auto_transfer(self):
 
         # Try to fill all the operation automatically.
         # The expected result is only opertions with product_id set and
-        self.assertTrue(product_8_op.qty_done)
-        self.assertTrue(product_9_op.qty_done)
+        self.assertFalse(product_8_op.picked)
+        self.assertFalse(product_9_op.picked)
 
     def test_action_auto_transfer_avoid_assign_lots(self):
         # set tracking on the products
@@ -379,8 +382,8 @@ def test_action_auto_transfer_avoid_assign_lots(self):
 
         # Try to fill all the operation automatically.
         # The expected result is only opertions with product_id set and
-        self.assertFalse(product_8_op.qty_done)
-        self.assertTrue(product_9_op.qty_done)
+        self.assertFalse(product_8_op.picked)
+        self.assertTrue(product_9_op.picked)
 
     def test_action_assign_replenish_stock(self):
         # Covered case:
@@ -414,10 +417,10 @@ def test_action_assign_replenish_stock(self):
         self.assertEqual(self.picking.state, "assigned")
         self.assertEqual(len(self.picking.move_line_ids), 1)
         # Try to fill all the operation automatically.
-        self.assertEqual(self.picking.move_line_ids.qty_done, 1000.00)
+        self.assertTrue(self.picking.move_line_ids.picked)
         product_quant.quantity = 1500.00
         self.picking.action_assign()
-        self.assertEqual(self.picking.move_line_ids.qty_done, 1500.00)
+        self.assertTrue(self.picking.move_line_ids.picked)
 
     def _picking_return(self, picking, qty):
         # Make a return from picking
@@ -427,6 +430,7 @@ def _picking_return(self, picking, qty):
                 active_ids=picking.ids,
                 active_id=picking.ids[0],
                 active_model="stock.picking",
+                custom_flag=True,
             )
         )
 
@@ -437,7 +441,7 @@ def _picking_return(self, picking, qty):
             stock_return_picking_action["res_id"]
         )
         return_pick.action_assign()
-        return_pick.move_ids.quantity_done = qty
+        return_pick.move_ids.quantity = qty
         return_pick._action_done()
         return return_pick
 
@@ -458,7 +462,6 @@ def test_return_twice(self):
                 },
             ]
         )._apply_inventory()
-
         self.move_model.create(
             dict(
                 product_id=product.id,
@@ -473,18 +476,10 @@ def test_return_twice(self):
         )
         self.picking_out.action_confirm()
         self.picking_out.action_assign()
-        # self.picking_out.move_lines.quantity_done = 500
+        self.picking_out.move_line_ids.quantity = 500
         self.picking_out._action_done()
         self.assertEqual(product.qty_available, 0.0)
-
         # Make first return from customer location to stock location
-        returned_picking = self._picking_return(self.picking_out, 500.00)
-        self.assertEqual(product.qty_available, 500)
-
-        # Make second return from stock location to customer location
-        returned_picking = self._picking_return(returned_picking, 500.00)
-        self.assertEqual(product.qty_available, 0.0)
-
-        # Make third return from customer location to stock location
-        returned_picking = self._picking_return(returned_picking, 500.00)
-        self.assertEqual(product.qty_available, 500)
+        self.picking_out.state = "done"
+        self._picking_return(self.picking_out, 500.00)
+        self.assertEqual(product.qty_available, 0)

stock_move_line_auto_fill/views/stock_picking.xml

@@ -13,7 +13,7 @@
                     type="object"
                     class="btn btn-primary"
                     string="AutoFill"
-                    attrs="{'invisible': ['|', ('action_pack_op_auto_fill_allowed','=', False), ('auto_fill_operation', '=', True)]}"
+                    invisible="not action_pack_op_auto_fill_allowed or auto_fill_operation"
                     help="This button will automatically fill all operations that have no tracking set on the product, no processed qty and no selected package."
                     groups="stock.group_stock_user"
                 />