-
-
Notifications
You must be signed in to change notification settings - Fork 729
[16.0][ADD] stock_picking_low_priority #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
f404898 to
78956f9
Compare
e30af06 to
5af1c70
Compare
| @@ -0,0 +1,2 @@ | |||
| * Nans Lefebvre <[email protected]> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glitchov You can remove Nans from the author....
stock_picking_low_priority/tests/test_stock_picking_low_priority.py
Outdated
Show resolved
Hide resolved
stock_picking_low_priority/tests/test_stock_picking_low_priority.py
Outdated
Show resolved
Hide resolved
lmignon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glitchov Thank you for this addon. Some comments but seems to be on the right track.
5af1c70 to
732ea00
Compare
|
@glitchov tests are failing |
|
I know. I've already changed a lot of things but they still fail on OCA but not locally... |
|
@glitchov ok I'll take a look |
abb08eb to
d9e6c06
Compare
lmignon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and functional tests
rousseldenis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Code review
jbaudoux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This PR has the |
d9e6c06 to
a3b368d
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
a3b368d to
ffaa42c
Compare
|
@glitchov Could you fix tests ? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@jbaudoux I'll look at tests for this |
e0c34ed to
842b189
Compare
jbaudoux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move the changes to stock_move_priority_picking_assign in another PR as I don't see the link with the other new module
842b189 to
7586a22
Compare
…rity through picking one
This module reintriduces a 'Not urgent' low priority on stock_picking/stock_move