Skip to content

Conversation

@Saran440
Copy link
Member

@Saran440 Saran440 commented May 15, 2024

This PR migrated from version15 and enhance to supported backdate scrap

@Saran440 Saran440 force-pushed the 16.0-mig-stock_move_backdating branch from 5996980 to d49ebcc Compare May 15, 2024 11:00
@rousseldenis
Copy link
Contributor

/ocabot migration stock_move_backdating

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 16, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 16, 2024
75 tasks
@Saran440 Saran440 force-pushed the 16.0-mig-stock_move_backdating branch from 4eb6454 to 361ac67 Compare May 24, 2024 03:06
@rousseldenis
Copy link
Contributor

@Saran440 Could you fix pre-commit and enhance your commit messages ? Thanks

@alessandro-fiorino
Copy link

I've made a pull to fix the pre-commit errors ecosoft-odoo#2

@Saran440 Saran440 force-pushed the 16.0-mig-stock_move_backdating branch from f7200b3 to ca8e33d Compare August 1, 2024 09:20
@Saran440
Copy link
Member Author

Saran440 commented Aug 1, 2024

@alessandro-fiorino Thank you for your contribution.
Now, I fixes it. Could you help review please?

@alessandro-fiorino
Copy link

It fails some test. I think the problem is in the test itself https://github.com/ecosoft-odoo/stock-logistics-workflow/blob/ca8e33d35f67f5716e349230eda9285074873212/stock_move_backdating/tests/common.py#L66
standard_price is enabled only if the product has variants.

@Saran440
Copy link
Member Author

Updated:

  • Change method update date in account move from _backdating_account_moves to _account_entry_move, Fixed for case backdating previous month it will error doesn't match date and sequence move
  • Fixed test script

Copy link

@arielbarreiros96 arielbarreiros96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed if from a functional perspective and it looks good, I tested mainly the backdating at the moment of making inventory adjustments. I do think the Readme file could include a Usage section, I literally had to read the code to know what to do.

@github-actions
Copy link

github-actions bot commented Apr 6, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 6, 2025
@bosd
Copy link
Contributor

bosd commented Apr 8, 2025

@arielbarreiros96 Is this one ok for you now? Can you update your review?

@Saran440
Copy link
Member Author

Saran440 commented Apr 8, 2025

@arielbarreiros96 I updated the README. Can you check it?

@Saran440 Saran440 force-pushed the 16.0-mig-stock_move_backdating branch from 1ee527b to 7378d60 Compare April 8, 2025 10:15
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 13, 2025
@bosd
Copy link
Contributor

bosd commented Apr 14, 2025

@Saran440 Can you fix this one?
Would like to start working on the migration.

@Saran440
Copy link
Member Author

@bosd it error from module stock_valuation_layer_usage
Selection_017

I never use this module. So, i can't fixed it.

Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@bosd
Copy link
Contributor

bosd commented Apr 18, 2025

v18 migration in stock_move_backdating #1921

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While working on the v18 migration I noticed some unit tests are disabled and needs fixing. (Fixes are applied in V18 migration)

The issue is solely with the unit tests. The module itself is working perfectly. 👍

@arielbarreiros96
Copy link

@arielbarreiros96 I updated the README. Can you check it?

Thanks for the update. Checked README after edits, seems much better now, simple and pretty straight forward👌

SirTakobi and others added 21 commits June 11, 2025 15:56
Currently translated at 95.4% (21 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
Currently translated at 95.4% (21 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
Currently translated at 100.0% (22 of 22 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_move_backdating
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_move_backdating/it/
@Saran440 Saran440 force-pushed the 16.0-mig-stock_move_backdating branch from adc6d3e to 4bfea2d Compare June 11, 2025 08:57
@Saran440
Copy link
Member Author

Fixed error test script.

@map-240221 @bosd Could you check please? and cherry-pick commit 4bfea2d to version17, 18

@map-240221
Copy link

4bfea2d

Works fine here, added to the version 17 migration.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 19, 2025
@bosd
Copy link
Contributor

bosd commented Oct 19, 2025

Can we get a merge?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.