-
-
Notifications
You must be signed in to change notification settings - Fork 729
[16.0][ADD] stock_account_fifo_return_origin #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] stock_account_fifo_return_origin #1649
Conversation
yostashiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review + functional test. LGTM. 👍
|
|
||
| def _get_fifo_candidates(self, company): | ||
| candidates = super()._get_fifo_candidates(company) | ||
| returned_moves = self._context.get("origin_returned_moves") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| returned_moves = self._context.get("origin_returned_moves") | |
| returned_moves = self.env.context.get("origin_returned_moves") |
|
@AungKoKoLin1997 Shouldn't this integrated in Odoo core ? |
@rousseldenis I don't think odoo will accept to apply in the stable versions. May be they will consider using in future versions. |
|
@AungKoKoLin1997 Can we propose this change in the master branch of Odoo? |
3d9bfd9 to
53ead1d
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@rousseldenis Can you please reopen this PR and merge it if you have no concerns? |
|
@rousseldenis |
53ead1d to
6dc3d27
Compare
|
This PR has the |
kanda999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test
This module is already in use in the production environment
This module makes adjustment to the standard behavior with regards to candidate SVLs that are used in purchase returns; if the SVL linked to the origin move (receipt) has remaining quantity, that SVL should be consumed first.
@qrtl QT4657