Skip to content

Conversation

@AungKoKoLin1997
Copy link
Contributor

This module makes adjustment to the standard behavior with regards to candidate SVLs that are used in purchase returns; if the SVL linked to the origin move (receipt) has remaining quantity, that SVL should be consumed first.

@qrtl QT4657

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + functional test. LGTM. 👍

@rousseldenis rousseldenis added this to the 16.0 milestone Jul 11, 2024

def _get_fifo_candidates(self, company):
candidates = super()._get_fifo_candidates(company)
returned_moves = self._context.get("origin_returned_moves")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
returned_moves = self._context.get("origin_returned_moves")
returned_moves = self.env.context.get("origin_returned_moves")

@rousseldenis
Copy link
Contributor

@AungKoKoLin1997 Shouldn't this integrated in Odoo core ?

@AungKoKoLin1997
Copy link
Contributor Author

Shouldn't this integrated in Odoo core ?

@rousseldenis I don't think odoo will accept to apply in the stable versions. May be they will consider using in future versions.

@yostashiro
Copy link
Member

@AungKoKoLin1997 Can we propose this change in the master branch of Odoo?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024
@github-actions github-actions bot closed this Dec 22, 2024
@yostashiro
Copy link
Member

@rousseldenis Can you please reopen this PR and merge it if you have no concerns?

@kanda999
Copy link

kanda999 commented Oct 7, 2025

@rousseldenis
Could you please reopen this PR? We would like to merge it afterward.

@rousseldenis rousseldenis reopened this Oct 7, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-stock_account_fifo_return_origin branch from 53ead1d to 6dc3d27 Compare October 7, 2025 09:01
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test
This module is already in use in the production environment

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants