[17.0][MIG] stock_move_line_auto_fill #1709

arantxa-s73 · 2024-09-13T08:31:03Z

Module migrated to version 17.0

rousseldenis · 2024-09-30T11:43:54Z

/ocabot migration stock_move_line_auto_fill

github-actions · 2025-03-23T12:42:46Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rrebollo · 2025-04-11T19:05:42Z

@arantxa-s73 is this ready to be merged?

arantxa-s73 · 2025-05-15T15:25:56Z

@rrebollo yes

rrebollo · 2025-05-15T21:48:08Z

@rrebollo yes

could you rebase it so we can test it in runboat?

arantxa-s73 · 2025-06-09T10:39:41Z

@rrebollo done

syci · 2025-07-23T10:16:39Z

@arantxa-s73 is this ready to be merged?

?¿

arantxa-s73 · 2025-07-23T11:15:28Z

@syci yes

syci · 2025-07-23T11:52:59Z

@arantxa-s73 ok, but some tests are failing... we should probably add another commit to restart.

arantxa-s73 · 2025-07-25T10:57:27Z

@syci test ready

eugenios73

Functional review OK

eugenios73 · 2025-07-29T11:08:00Z

@syci @rrebollo @bealdav , can you review? Please

arantxa-s73 · 2025-09-11T10:46:42Z

@syci @rrebollo @bealdav can you review? Please

rrebollo · 2025-09-30T22:20:31Z

@arantxa-s73 there is no runboat again

rrebollo

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

stock_move_line_auto_fill/tests/test_stock_picking_auto_fill.py

arantxa-s73 · 2025-10-01T06:18:13Z

@rrebollo Runbott ready and test modifications too

…nature

Currently translated at 8.3% (1 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/it/

Currently translated at 75.0% (9 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/es/

Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/

Currently translated at 91.6% (11 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/pt/

… mrp & stock_barcode apps exist on the db This commit is to ensure that this module can be installed when the database already has the 'mrp' and 'stock_barcode' modules installed. both of the modules are inheriting the stock_picking_type_views.xml.

Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/it/

Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/ja/

Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/it/

Currently translated at 91.6% (11 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/pt_BR/

Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/pt_BR/

Currently translated at 100.0% (12 of 12 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_move_line_auto_fill Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_move_line_auto_fill/it/

Reyes4711-S73

LGTM

Reyes4711-S73 · 2025-11-11T16:34:05Z

@OCA/logistics-maintainers Please, can you merge this PR?

hparfr

Some remarks about the tests

stock_move_line_auto_fill/models/stock_picking.py

hparfr · 2025-11-12T09:55:34Z

stock_move_line_auto_fill/tests/test_stock_picking_auto_fill.py

        product_quant.quantity = 1500.00
        self.picking.action_assign()
-        self.assertEqual(self.picking.move_line_ids.qty_done, 1500.00)
+        self.assertTrue(self.picking.move_line_ids.picked)


With this change, what do you test now ?

@hparfr to verify that the lines remain picked

If I understand correctly, before the test was checking the quantity picked/qty_done (1000), then increasing the quantiy available from 1000 to 1500, finally ensuring the picked/qty_done was increasing as well.
Now, it checks if everything is picked without ensuring what happens when the quantity available increase.

hparfr · 2025-11-12T09:56:43Z

stock_move_line_auto_fill/tests/test_stock_picking_auto_fill.py

+        self.assertEqual(self.picking.state, "assigned")
+        self.assertEqual(len(self.picking.move_line_ids), 1)
+        # Try to fill all the operation automatically.
+        self.assertTrue(self.picking.move_line_ids.picked)


With this change, I don't get what you test

Are you referring to the same thing as above?

The test is about making a delivery, return it, make the delivery again, return it again.

def test_return_twice(self): # Covered case: # Return more than one times not duplicate quant units in stock

stock_move_line_auto_fill/tests/test_stock_picking_auto_fill.py

arantxa-s73 changed the title ~~17.0-mig-stock_move_line_autofill~~ 17.0-mig-stock_move_line_auto_fill Sep 13, 2024

OCA-git-bot added this to the 17.0 milestone Sep 30, 2024

OCA-git-bot mentioned this pull request Sep 30, 2024

Migration to version 17.0 #1421

Open

74 tasks

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 23, 2025

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 13, 2025

arantxa-s73 force-pushed the 17.0-mig-stock_move_line_auto_fill branch from e3c084c to 05587f1 Compare May 16, 2025 05:59

arantxa-s73 force-pushed the 17.0-mig-stock_move_line_auto_fill branch 3 times, most recently from 3f66d36 to 4514cbe Compare July 25, 2025 10:47

arantxa-s73 changed the title ~~17.0-mig-stock_move_line_auto_fill~~ [17.0][MIG} stock_move_line_auto_fill Jul 29, 2025

arantxa-s73 changed the title ~~[17.0][MIG} stock_move_line_auto_fill~~ [17.0][MIG] stock_move_line_auto_fill Jul 29, 2025

eugenios73 approved these changes Jul 29, 2025

View reviewed changes

rrebollo approved these changes Sep 30, 2025

View reviewed changes

stock_move_line_auto_fill/tests/test_stock_picking_auto_fill.py Outdated Show resolved Hide resolved

stock_move_line_auto_fill/tests/test_stock_picking_auto_fill.py Outdated Show resolved Hide resolved

OCA-git-bot added the approved label Sep 30, 2025

arantxa-s73 force-pushed the 17.0-mig-stock_move_line_auto_fill branch from 4514cbe to ab87a33 Compare October 1, 2025 06:12

OCA-git-bot added the ready to merge label Oct 1, 2025

OCA-git-bot and others added 24 commits November 11, 2025 16:52

[UPD] README.rst

28822a5

stock_move_line_auto_fill 16.0.1.0.1

164f3e8

[FIX] stock_move_line_auto_fill: Use proper _action_assign method sig…

d421a8e

…nature

[FIX] stock_move_line_auto_fill: Improve tests

6c1d36f

stock_move_line_auto_fill 16.0.1.0.2

157bc1b

[UPD] README.rst

3501e2d

[BOT] post-merge updates

6538314

Added translation using Weblate (Japanese)

d61e29f

[REF] stock_move_line_auto_fill

372d2cb

[BOT] post-merge updates

f75e3de

[IMP] stock_move_line_auto_fill: pre-commit auto fixes

1488b96

arantxa-s73 force-pushed the 17.0-mig-stock_move_line_auto_fill branch from ab87a33 to f6fdb41 Compare November 11, 2025 15:52

Reyes4711-S73 approved these changes Nov 11, 2025

View reviewed changes

hparfr reviewed Nov 12, 2025

View reviewed changes

[MIG] stock_move_line_auto_fill: Migration to 17.0

bd4960a

arantxa-s73 force-pushed the 17.0-mig-stock_move_line_auto_fill branch from f6fdb41 to bd4960a Compare November 12, 2025 15:22

Uh oh!

[17.0][MIG] stock_move_line_auto_fill #1709

Are you sure you want to change the base?

[17.0][MIG] stock_move_line_auto_fill #1709

Uh oh!

Conversation

arantxa-s73 commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rousseldenis commented Sep 30, 2024

Uh oh!

github-actions bot commented Mar 23, 2025

Uh oh!

rrebollo commented Apr 11, 2025

Uh oh!

arantxa-s73 commented May 15, 2025

Uh oh!

rrebollo commented May 15, 2025

Uh oh!

arantxa-s73 commented Jun 9, 2025

Uh oh!

syci commented Jul 23, 2025

Uh oh!

arantxa-s73 commented Jul 23, 2025

Uh oh!

syci commented Jul 23, 2025

Uh oh!

arantxa-s73 commented Jul 25, 2025

Uh oh!

eugenios73 left a comment

Choose a reason for hiding this comment

Uh oh!

eugenios73 commented Jul 29, 2025

Uh oh!

arantxa-s73 commented Sep 11, 2025

Uh oh!

rrebollo commented Sep 30, 2025

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

arantxa-s73 commented Oct 1, 2025

Uh oh!

Reyes4711-S73 left a comment

Choose a reason for hiding this comment

Uh oh!

Reyes4711-S73 commented Nov 11, 2025

Uh oh!

hparfr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hparfr Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

arantxa-s73 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

hparfr Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

hparfr Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

arantxa-s73 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

hparfr Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

arantxa-s73 commented Sep 13, 2024 •

edited

Loading