[16.0][IMP] stock_owner_restriction #1854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
16.0-imp-stock_owner_restriction
branch
from
f1f757d to
3d6f6c8
Compare
AungKoKoLin1997
force-pushed
the
16.0-imp-stock_owner_restriction
branch
from
ed15d3e to
a49fd85
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
kanda999
force-pushed
the
16.0-imp-stock_owner_restriction
branch
from
a49fd85 to
d7cc954
Compare
kanda999
approved these changes
Jul 7, 2025
kanda999
left a comment
kanda999
left a comment
There was a problem hiding this comment.
LGTM: This update has been used in production for a year.
yostashiro
reviewed
Jul 7, 2025
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
Could we perhaps make the intention of adding _compute_restrict_partner_id() clearer?
AungKoKoLin1997
force-pushed
the
16.0-imp-stock_owner_restriction
branch
3 times, most recently
from
79b9c2d to
5bdabf6
Compare
yostashiro
reviewed
Jul 11, 2025
AungKoKoLin1997
force-pushed
the
16.0-imp-stock_owner_restriction
branch
from
5bdabf6 to
dfec985
Compare
… logic to support owner restriction - Extend _update_available_quantity() and _update_reserved_quantity() in stock.quant to handle scenarios where owner_restriction should be enforced. - Create a separate _get_owner_restriction() method to improve clarity and extensibility for other modules. - Fix read_group() in stock.quant, which was incorrectly assigning the owner record instead of the owner ID in the domain. - Add compute method for restrict_partner_id to dynamically control owner assignment based on picking type restrictions. - Unlink stock.move.line records when owner_id is updated and owner_restriction is set. - Update test cases.
AungKoKoLin1997
force-pushed
the
16.0-imp-stock_owner_restriction
branch
from
dfec985 to
1b873b6
Compare
yostashiro
reviewed
Jul 11, 2025
| @api.depends("picking_type_id", "picking_id.owner_id", "move_dest_ids") | ||
| def _compute_restrict_partner_id(self): | ||
| for move in self: | ||
| if move.picking_type_id.owner_restriction == "picking_partner": |
Member
There was a problem hiding this comment.
Please check the validity of this suggestion.
Suggested change
| if move.picking_type_id.owner_restriction == "picking_partner": | |
| if move.picking_type_id.owner_restriction in ("picking_partner", "partner_or_unassigned"): |
Contributor
Author
There was a problem hiding this comment.
I think this is not valid. Even if we have move lines from an unassigned owner together with move lines from an assigned owner, the move will still be assigned to the partner. Therefore, we should continue allowing False for this restriction type.
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #1385.
This PR does the following:
to handle scenarios where owner_restriction should be enforced.
instead of the owner ID in the domain.
based on picking type restrictions.
@qrtl QT4207