[18.0][MIG] stock_picking_batch_extended: Migration to 18.0 #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankinmax
force-pushed
the
18.0-mig-stock_picking_batch_extended
branch
from
13ea03a to
3d36345
Compare
yankinmax
commented
Jan 28, 2025
stock_picking_batch_extended/migrations/18.0.1.0.0/pre-migrate.py
Outdated
Show resolved
Hide resolved
yankinmax
commented
Jan 28, 2025
yankinmax
commented
Jan 28, 2025
yankinmax
commented
Jan 28, 2025
yankinmax
commented
Jan 28, 2025
yankinmax
commented
Jan 28, 2025
yankinmax
commented
Jan 28, 2025
Contributor
|
/ocabot migration stock_picking_batch_extended |
gaetan-vaujour
approved these changes
Jan 29, 2025
Contributor
|
IMHO those kind of modules should be avoided. As it is very difficult for users to determine what is the real purpose of it. |
jbaudoux
requested changes
Jan 31, 2025
Contributor
jbaudoux
left a comment
jbaudoux
left a comment
There was a problem hiding this comment.
Warf! This module is doing too many different things.
Can you split in several modules? One meaningful group of features per module.
And try to find meaningful module names
| class ProductTemplate(models.Model): | ||
| _inherit = "product.template" | ||
|
|
||
| description_picking = fields.Text(string="Warehouse Description", translate=True) |
Contributor
There was a problem hiding this comment.
I don't see where this is used. Should be in a separate module
| class Company(models.Model): | ||
| _inherit = "res.company" | ||
|
|
||
| use_oca_batch_validation = fields.Boolean() |
Contributor
There was a problem hiding this comment.
What is the OCA way? This is not clear, help missing. Rename field
3 tasks
|
leemannd
reviewed
Mar 6, 2025
|
|
||
| def migrate(cr, version): | ||
| cr.execute(""" | ||
| UPDATE product_template |
leemannd
reviewed
Mar 6, 2025
| class ProductTemplate(models.Model): | ||
| _inherit = "product.template" | ||
|
|
||
| description_picking = fields.Text(string="Warehouse Description", translate=True) |
There was a problem hiding this comment.
This field is actually exists, the override is about the string
- Converts old stock.batch.picking in stock.picking.batch - Restore link in stock.picking - Other needed stuff
…er and activities
…Picking group [REF] stock_picking_batch_extended: update picking_batch_configuration_settings img configuration
Currently translated at 22.2% (14 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/
Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/
Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/
Currently translated at 84.1% (53 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/pt_BR/
Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/
Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/
Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/pt_BR/
Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/
…icking report on "print deliveries" button TT50661
leemannd
force-pushed
the
18.0-mig-stock_picking_batch_extended
branch
from
79aed17 to
e3377c6
Compare
leemannd
force-pushed
the
18.0-mig-stock_picking_batch_extended
branch
from
e3377c6 to
0569479
Compare
david-banon-tecnativa
added a commit
to Tecnativa/stock-logistics-workflow
that referenced
this pull request
Jun 23, 2025
Based off OCA#1855 TT52372
carlosdauden
approved these changes
Jun 24, 2025
|
|
||
| name = fields.Char( | ||
| index=True, | ||
| readonly=False, # allow edition in draft state |
Contributor
There was a problem hiding this comment.
Is it necessary to set False, which is the default value?
carlosdauden
suggested changes
Jun 24, 2025
| invisible="not use_oca_batch_validation" | ||
| /> | ||
| </xpath> | ||
| <xpath expr="//div[@name='button_box']" position="inside"> |
carlosdauden
approved these changes
Jun 24, 2025
david-banon-tecnativa
added a commit
to Tecnativa/stock-logistics-workflow
that referenced
this pull request
Jun 24, 2025
Based off OCA#1855 TT52372
david-banon-tecnativa
added a commit
to Tecnativa/stock-logistics-workflow
that referenced
this pull request
Jun 25, 2025
Based off OCA#1855 TT52372
david-banon-tecnativa
added a commit
to Tecnativa/stock-logistics-workflow
that referenced
this pull request
Jun 25, 2025
Based off OCA#1855 TT52372
carlos-lopez-tecnativa
suggested changes
Aug 26, 2025
Comment on lines
+25
to
+26
| location_name = operation.location_id.name_get()[0][1] | ||
| location_dest_name = operation.location_dest_id.name_get()[0][1] |
There was a problem hiding this comment.
Suggested change
| location_name = operation.location_id.name_get()[0][1] | |
| location_dest_name = operation.location_dest_id.name_get()[0][1] | |
| location_name = operation.location_id.display_name | |
| location_dest_name = operation.location_dest_id.display_name |
| <thead> | ||
| <th>Product</th> | ||
| <th>Carrier</th> | ||
| <th class="text-right">QTY</th> |
There was a problem hiding this comment.
Suggested change
| <th class="text-right">QTY</th> | |
| <th class="text-end">QTY</th> |
| <td> | ||
| <span t-esc="carrier.name" /> | ||
| </td> | ||
| <td class="text-right"> |
There was a problem hiding this comment.
Suggested change
| <td class="text-right"> | |
| <td class="text-end"> |
| <tfoot> | ||
| <tr> | ||
| <td /> | ||
| <td id="total_label" class="text-right"> |
There was a problem hiding this comment.
Suggested change
| <td id="total_label" class="text-right"> | |
| <td id="total_label" class="text-end"> |
Comment on lines
+130
to
+132
| <td id="total_qty" class="text-right"> | ||
| <strong t-esc="total_qty" /> | ||
| </td> |
There was a problem hiding this comment.
Suggested change
| <td id="total_qty" class="text-right"> | |
| <strong t-esc="total_qty" /> | |
| </td> | |
| <td id="total_qty" class="text-end"> | |
| <strong t-out="total_qty" /> | |
| </td> |
| <span t-field="product.display_name" /> | ||
| </td> | ||
| <td> | ||
| <span t-esc="carrier.name" /> |
There was a problem hiding this comment.
And check the remaining occurrences
Suggested change
| <span t-esc="carrier.name" /> | |
| <span t-out="carrier.name" /> |
Contributor
|
@yankinmax can you commit changes requested? |
|
Superseded by #2120 |
david-banon-tecnativa
added a commit
to Tecnativa/stock-logistics-workflow
that referenced
this pull request
Oct 24, 2025
Based off OCA#1855 TT52372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
22 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.