[16.0][ADD] purchase_stock_price_variance #1893
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobuQuartile
approved these changes
Mar 11, 2025
nobuQuartile
left a comment
nobuQuartile
left a comment
There was a problem hiding this comment.
LGTM
Code review and Functional review
yostashiro
approved these changes
Mar 12, 2025
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
Just very minor non-blocking points. LGTM.
purchase_stock_price_variance/tests/test_purchase_stock_price_variance.py
Outdated
Show resolved
Hide resolved
purchase_stock_price_variance/tests/test_purchase_stock_price_variance.py
Show resolved
Hide resolved
purchase_stock_price_variance/security/purchase_stock_price_variance_security.xml
Outdated
Show resolved
Hide resolved
Contributor
|
This PR has the |
AungKoKoLin1997
force-pushed
the
16.0-add-purchase_stock_price_variance
branch
3 times, most recently
from
3ed70a7 to
8469f13
Compare
AungKoKoLin1997
force-pushed
the
16.0-add-purchase_stock_price_variance
branch
from
8469f13 to
19dff71
Compare
Contributor
Author
|
@oca/stock-logistics-workflow-maintainers |
AungKoKoLin1997
force-pushed
the
16.0-add-purchase_stock_price_variance
branch
from
19dff71 to
c2d54ea
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
AungKoKoLin1997
force-pushed
the
16.0-add-purchase_stock_price_variance
branch
from
c2d54ea to
65b3676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module checks the variance between the purchase price and the product's standard price at the time of receipt picking validation. If the variance exceeds a given threshold, the notification can be left in the chatter. Additionally, an error can be triggered before receiving the stock if needed.
@qrtl QT4947