[16.0][ADD] lead_time_profile #1908
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmequignon
suggested changes
Apr 3, 2025
Member
mmequignon
left a comment
mmequignon
left a comment
There was a problem hiding this comment.
I think this is lacking tests
AungKoKoLin1997
force-pushed
the
16.0-add-lead_time_profile
branch
from
3d3dd11 to
4a78f33
Compare
Contributor
Author
Added some test cases. |
AungKoKoLin1997
force-pushed
the
16.0-add-lead_time_profile
branch
from
4a78f33 to
fb01303
Compare
| company = self.company_id | ||
| if self.partner_id: | ||
| if partner == self.partner_id: | ||
| score += company.lead_time_profile_partner_factor |
Contributor
There was a problem hiding this comment.
My question is about factor: should it be addition instead of multiplication ?
Contributor
Author
There was a problem hiding this comment.
We use addition because each factor is an independent weight. With multiplication, different match combinations (or factors equal to 1) could collapse to the same score, which distorts the results.
AungKoKoLin1997
force-pushed
the
16.0-add-lead_time_profile
branch
from
fb01303 to
1aaae33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module provides a generic way to manage lead times using lead time profiles. It selects the most suitable profile based on predefined rules and calculates the lead time accordingly.
The module is designed to be used as a base module.
@qrtl QT4790