Skip to content

Conversation

@chienandalu
Copy link
Member

cc @moduon @rafaelbn @yajo MT-9255

@chienandalu chienandalu force-pushed the 16.0-add-stock_picking_line_no_print branch 2 times, most recently from c3e7abf to fe55e9b Compare May 28, 2025 15:22
@chienandalu chienandalu force-pushed the 16.0-add-stock_picking_line_no_print branch 3 times, most recently from 808788f to 85c356d Compare May 29, 2025 10:35
@chienandalu chienandalu requested a review from yajo May 29, 2025 10:35
@chienandalu chienandalu force-pushed the 16.0-add-stock_picking_line_no_print branch from 85c356d to 238d176 Compare June 16, 2025 14:25
@rafaelbn rafaelbn added this to the 16.0 milestone Jun 20, 2025
@EmilioPascual EmilioPascual force-pushed the 16.0-add-stock_picking_line_no_print branch from 238d176 to ab3ca33 Compare July 28, 2025 06:43
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @yajo you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@rafaelbn
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-1967:16.0-add-stock_picking_line_no_print failed with output:

remote: Permission to moduon/stock-logistics-workflow.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/stock-logistics-workflow/': The requested URL returned error: 403

Copy link
Contributor

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review status: Not OK. A revision is required.
Reason: After disabling “Display in report” on a move, saving, and then confirming the picking, the printed delivery slip still includes that line; it should be hidden, so the printing logic is not honoring the flag once the picking is confirmed.
The following tests were executed.

  • Test 1: Hide a move from delivery slip — Steps: disable “Display in report” on one move, save, confirm the picking, print delivery slip — Result: NOT OK; the hidden move is still printed — Expected: the move should not appear in the report.
  • No additional tests were run until this issue is resolved.
image image

@chienandalu
Copy link
Member Author

@Gelojr the report you show in the screenshot isn't the delivery slip but the internal operations one which logically must show the lines normally

@Gelojr
Copy link
Contributor

Gelojr commented Sep 24, 2025 via email

Copy link
Contributor

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your excellent work and contribution, @chienandalu, but the review status is incorrect.
Reason:
I'm not sure if the result of test 3 is as expected.
The result of test 4 is incorrect. After validation, the printed delivery note does not respect the 'Show in report' checkbox; a line is printed whose checkbox is not selected.
The following tests have been performed:

  • Test 1: Hide a movement with detailed operations enabled. Result: correct.
  • Test 2: Change visibility and reprint with Detailed Operations enabled. Result: Correct (the second printout excludes the unchecked movement, as expected).
  • Test 3: Not sure if it's correct
  1. I add 3units of product A to line 1.
  2. Then I add product B to line 2, also with 3 units. Uncheck Display in report
  3. Then I add the same product, B, to line 3, but this time with 2 units.
  4. I save. When I print, prints line 1 (3 units) and line 3 (2 units)
  5. If valid, products B on lines 2 and 3 are grouped and printed together as 5 units on a single line. Result: I don't know if this is the expected behaviour.
  • Test 4: Result: Incorrect.
  1. Create a delivery with three products.
  2. Set the delivered quantity for line 1 = 0 units with 'Show in report' checked.
  3. The delivered quantity for line 2 = 3 units with 'Show in report' unchecked.
  4. The delivered quantity for line 3 = 5 units with 'Show in report' checked.
  5. Save and print: only line 3 is printed (correct).
  6. Validate and print again: lines 2 and 3 are printed. However, line 2 should not be printed because its indicator is not checked.

@yajo
Copy link
Member

yajo commented Oct 17, 2025

the review status is incorrect

@chienandalu could you please attend the review? Tests are ❌ too. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants