Skip to content

Conversation

@renatonlima
Copy link
Member

Current Scenario

The stock_picking_invoice_link module, which adds the relationship between the invoice and stock picking, depends on the sale_stock module, but the purchase_stock_picking_invoice_link module depends on stock_picking_invoice_link, making it mandatory to install both the purchase and sale modules, thus losing modularity.

Proposed Solution

The sale dependency on stock_picking_invoice_link was removed, and a new sale_stock_picking_invoice_link module was created. In this way, the stock_picking_invoice_link module is a base module for the sale_stock_picking_invoice_link and purchase_stock_picking_invoice_link modules, preserving modularity.

@renatonlima renatonlima force-pushed the 16.0-stock_picking_invoice_link-split-sale branch 3 times, most recently from fddcfa4 to 5bb24b4 Compare July 9, 2025 23:56
@renatonlima renatonlima force-pushed the 16.0-stock_picking_invoice_link-split-sale branch 2 times, most recently from be74faf to fdafa8b Compare July 10, 2025 00:39
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 10, 2025
@pedrobaeza
Copy link
Member

Although the idea is good, I'm afraid we can't do this in a stable version, as it supposes to break some installations due to the lack of the new module (not all deployment methods auto-download and auto-install new modules). This should be done in a new version.

@rvalyi
Copy link
Member

rvalyi commented Jul 10, 2025

Although the idea is good, I'm afraid we can't do this in a stable version, as it supposes to break some installations due to the lack of the new module (not all deployment methods auto-download and auto-install new modules). This should be done in a new version.

@pedrobaeza that's legit and that's why he also made a similar PR in v18 #2023

@renatonlima renatonlima force-pushed the 16.0-stock_picking_invoice_link-split-sale branch from fdafa8b to 9b34321 Compare July 10, 2025 13:00
…module as a base for the modules sale_stock_picking_invoice_link and purchase_stock_picking_invoice_link
@renatonlima renatonlima force-pushed the 16.0-stock_picking_invoice_link-split-sale branch from 9b34321 to 2078f3a Compare July 10, 2025 13:18
@rvalyi rvalyi marked this pull request as draft July 10, 2025 14:42
@rvalyi
Copy link
Member

rvalyi commented Jul 10, 2025

so I reverted the PR to draft to avoid merging by mistake as indeed this an impacting dependency change and we will focus on getting the merge in 18.0 instead to avoid impacting stable instances all around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants