Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions stock_picking_batch_set_quantity/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ Stock Picking Batch Set Quantity
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--workflow-lightgray.png?logo=github
:target: https://github.com/OCA/stock-logistics-workflow/tree/15.0/stock_picking_batch_set_quantity
:target: https://github.com/OCA/stock-logistics-workflow/tree/18.0/stock_picking_batch_set_quantity
:alt: OCA/stock-logistics-workflow
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_batch_set_quantity
:target: https://translation.odoo-community.org/projects/stock-logistics-workflow-18-0/stock-logistics-workflow-18-0-stock_picking_batch_set_quantity
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-workflow&target_branch=15.0
:target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-workflow&target_branch=18.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|
Expand All @@ -39,38 +39,38 @@ quantity in quantity done fields.
Usage
=====

#. Go to *Inventory > Operations > Batch Transfers*
1. Go to *Inventory > Operations > Batch Transfers*

* Go to Detailed Operations or Operations page
* Click button to fill quantity done
- Go to Detailed Operations or Operations page
- Click button to fill quantity done

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/stock-logistics-workflow/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/stock-logistics-workflow/issues/new?body=module:%20stock_picking_batch_set_quantity%0Aversion:%2015.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/OCA/stock-logistics-workflow/issues/new?body=module:%20stock_picking_batch_set_quantity%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~
-------

* Tecnativa

Contributors
~~~~~~~~~~~~
------------

* `Tecnativa <https://www.tecnativa.com>`_:
- `Tecnativa <https://www.tecnativa.com>`__:

* Carlos Dauden
- Carlos Dauden

Maintainers
~~~~~~~~~~~
-----------

This module is maintained by the OCA.

Expand All @@ -82,6 +82,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/stock-logistics-workflow <https://github.com/OCA/stock-logistics-workflow/tree/15.0/stock_picking_batch_set_quantity>`_ project on GitHub.
This module is part of the `OCA/stock-logistics-workflow <https://github.com/OCA/stock-logistics-workflow/tree/18.0/stock_picking_batch_set_quantity>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
2 changes: 1 addition & 1 deletion stock_picking_batch_set_quantity/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"name": "Stock Picking Batch Set Quantity",
"summary": "Adds buttons to set all reserved quantity in quantity done fields",
"version": "15.0.1.0.0",
"version": "18.0.1.0.0",
"development_status": "Beta",
"category": "Sale",
"website": "https://github.com/OCA/stock-logistics-workflow",
Expand Down
1 change: 0 additions & 1 deletion stock_picking_batch_set_quantity/models/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from . import stock_move
from . import stock_move_line
8 changes: 5 additions & 3 deletions stock_picking_batch_set_quantity/models/stock_move.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
class StockMove(models.Model):
_inherit = "stock.move"

def action_set_quantities_to_reservation(self):
"""Public method to be called from button"""
self._set_quantities_to_reservation()
def action_set_quantity(self):
self.ensure_one()
self._action_assign()
if self.quantity:
self.state = "done"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, as you can't set state manually. In fact, the idea of the module is to assign quantities, but as I see lately, v18 already pre-assign quantities, so this module doesn't make sense for the new version. On the target version, by default, the reserved quantities wasn't set, so this button was useful for setting that quantities, but now, they are pre-set, so no need of it. Can you confirm?

25 changes: 0 additions & 25 deletions stock_picking_batch_set_quantity/models/stock_move_line.py

This file was deleted.

2 changes: 2 additions & 0 deletions stock_picking_batch_set_quantity/readme/CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [Tecnativa](https://www.tecnativa.com):
- Carlos Dauden
3 changes: 0 additions & 3 deletions stock_picking_batch_set_quantity/readme/CONTRIBUTORS.rst

This file was deleted.

3 changes: 3 additions & 0 deletions stock_picking_batch_set_quantity/readme/USAGE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
1. Go to *Inventory \> Operations \> Batch Transfers*
- Go to Detailed Operations or Operations page
- Click button to fill quantity done
4 changes: 0 additions & 4 deletions stock_picking_batch_set_quantity/readme/USAGE.rst

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,48 +7,19 @@
ref="stock_picking_batch.view_picking_move_tree_inherited"
/>
<field name="arch" type="xml">
<xpath expr="//field[@name='quantity_done']" position="attributes">
<attribute
name="decoration-success"
>quantity_done &gt; 0 and quantity_done == reserved_availability</attribute>
<xpath expr="//field[@name='quantity']" position="attributes">
<attribute name="decoration-success">picked</attribute>
</xpath>
<xpath expr="//field[@name='reserved_availability']" position="after">
<button
name="action_set_quantities_to_reservation"
attrs="{'invisible': [
'|',
('parent.state', '!=', 'in_progress'),
('parent.show_validate', '=', False)]}"
title="Set quantities"
type="object"
groups="stock.group_stock_user"
icon="fa-arrow-right"
/>
</xpath>
</field>
</record>

<record model="ir.ui.view" id="view_move_line_tree">
<field name="model">stock.move.line</field>
<field name="inherit_id" ref="stock_picking_batch.view_move_line_tree" />
<field name="arch" type="xml">
<xpath expr="//field[@name='product_uom_qty']" position="after">
<button
name="action_set_quantities_to_reservation"
attrs="{'invisible': [
'|',
('parent.state', '!=', 'in_progress'),
('parent.show_validate', '=', False)]}"
title="Set quantities"
name="action_set_quantity"
invisible="state in ['done', 'cancel'] or picked"
title="Set picked"
type="object"
groups="stock.group_stock_user"
icon="fa-arrow-right"
icon="oi-arrow-right"
/>
</xpath>
<xpath expr="//field[@name='qty_done']" position="after">
<xpath expr="//field[@name='product_uom_id']" position="move" />
</xpath>
</field>
</record>

</odoo>