[17.0][ADD] stock picking portal #2148
Conversation
Task: 3612 [IMP] stock_picking_portal: tests for portal Add tests for portal.py Task: 3612
Currently translated at 100.0% (68 of 68 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_portal Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_portal/it/
jelenapoblet
left a comment
jelenapoblet
left a comment
There was a problem hiding this comment.
Functional review OK. I'm missing an Icon and a short description to keep the style of the portal in v17.
Maybe we can use this open source project for isometric style icons: https://www.isocons.app/
|
@antoniodavid could you please review this one ? |
There was a problem hiding this comment.
@crrodrigueztrujillo Code reviews look good to me, but you should squash & merge the last three commits.
|
@crrodrigueztrujillo Please update the PR title by changing "ADD" to "MIG". Also, mention that you’re handling the module migration in #1421. As previously stated in this thread, remember to squash the latest commits as well. |
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
|
|
||
|
|
||
| @tagged("post_install", "-at_install") | ||
| class TestPortalConfigSettings(TransactionCase): |
There was a problem hiding this comment.
From the OCA's migration guide to 17:
Use BaseCommon as base test class to reduce overhead from tracking and boost the test suite.
|
|
||
|
|
||
| @tagged("post_install", "-at_install") | ||
| class TestPickingLinkWizard(TransactionCase): |
7 participants
@BinhexTeam
This module implements the following features:
used
Users have access to the following stock operations: